@Jan ... why is registry access done through the separate thread

[WaldemarH]

Hi Jan,

I'm trying to cleanup the code and move it to TCHAR and I'm looking at the registry calls and have no idea why would you want to send registry requests to another thread and then wait for it to finish the work before continuing ?

The only reason for me would be if registry access would somehow take a really long time and you would still want the message pump to track for specific message.

Any clarification on this would be much appreciated.

Best regards
Waldemar

EDIT:
A little search would answer my question... the only time the registry thread is used is during shutdown or user log-off, so that app stores the registry values and that the main thread message loop stays running.
In other case Windows could kill the app prematurelly.

[greenozon]

Agree on the TCHAR tacticts..
but one need also to replace lots of api calls, eg:
sprintf
etc

do you work in a separate fork or how does the merge happens (if any)?
I'm asking cause I also have some ideas/desire to invest efforts into this great product

[WaldemarH]

Yeah I know... LOOOOTS of calls :) ... I was thinking what would be the best way to do it and we have:

1. switch to WCHAR
2. use UTF8

With the first we have the issue that Salamander's code is written for ANSI character set.
With the second we have the issue that Salamander's code is written for ANSI character set. :) ... it doesn't understand multiple bytes long characters.

And as in both options we have the same issue I've decided that as I will be cleaning the code anyway let just switch to TCHAR which will not influence ANSI at this time in anyway and at the end we'll be able to switch to Unicode with one switch... of course at that time we'll need LOOOTS of testing. :)

And as always every journey starts with the first step. :)

BrW

[greenozon]

agree 100 percents!
could we collaborate maybe in a single repo?

[WaldemarH]

If you want we can also have a meeting so that I would show you what I have done and in which direction I'm currently going and then you could join on other parts?
My main idea was to start on smaller dialogs then switch to other parts.
Now in the mean time I'm also cleaning the helper functions, so that when "a dialog" will be finished it will really be finished and no other stuff will have to be done.

[greenozon]

great idea!
I"ll need to refresh my knowledge of the code
I'll be back soon
what repo are you working in?

[WaldemarH]

On my own clone, but haven't pushed it to github yet. Plan was to do that after I'll finish with Find dialog.
Currently I need to finish the registry cleanup and then it will be buildable again.

From which country are you? .. to check what time can we do the meeting.

[ags1234]

of course at that time we'll need LOOOTS of testing. :)

Don't know programming, but I may be able to help with testing new builds.

[WaldemarH]

All testing is welcome. :)

[WaldemarH]

@greenozon I've checked your github and I see you have forked a lot on reverse engineering stuff.... aa yeah that were the days... at XP time I also worked on reverse engineering and "fixing" the apps if they blocked some usage of the app. ;) .. I even wrote ida2sice plugin for ida... it would still need more loving but SIce life ended so the plugin died too... it's a bummer.

[greenozon]

@WaldemarH hi!
lets sync after Easter Holidays!

[WaldemarH]

Yeah no problem.. I'm cleaning registry functions anyway and still need time.

Anyway God bless everybody and wish you all the peace and love through the Holidays.

[melloware]

@WaldemarH @greenozon i am also available for testing builds