Skip to content

Commit 48726cc

Browse files
committed
[General] fix
1 parent 4ad5257 commit 48726cc

5 files changed

Lines changed: 8 additions & 46 deletions

File tree

include/openminecraft-shell/renderer/worldrenderer.hpp

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,6 @@ using namespace openminecraft::renderer::common;
3434
// INFO: The renderer test definition, behaves like a renderer handler (and it should be)
3535
namespace openminecraftshell::renderer
3636
{
37-
// INFO: The uniform buffer data structure used for the renderer
38-
// INFO: model, view, proj for object rendering
39-
#pragma pack(1)
40-
struct LightingUniform
41-
{
42-
glm::vec3 lightDirection;
43-
float _pad1;
44-
glm::vec3 lightColor;
45-
float _pad2;
46-
glm::vec3 ambientColor;
47-
float _pad3;
48-
};
49-
#pragma pack()
5037
// INFO: simple vertex structure
5138
using VertexStruct = basics::OMVertex<glm::vec3, glm::vec2>;
5239

@@ -65,7 +52,7 @@ class OMWorldRenderer : public OMRendererHandler
6552
void record();
6653

6754
// INFO: these are the resource handles used for rendering
68-
OMRendererBuffer *uniformBuffer, *voxelModelBuffer, *lightingBuffer, *cameraBuffer;
55+
OMRendererBuffer *uniformBuffer, *voxelModelBuffer, *cameraBuffer;
6956
wrap::OMRendererTempTarget *tempTarget;
7057
wrap::OMVoxelManager *voxelManager;
7158
data::OMTextureAtlas *textureAtlas;
@@ -83,9 +70,6 @@ class OMWorldRenderer : public OMRendererHandler
8370

8471
std::shared_ptr<OMShader> outputVtx;
8572
std::shared_ptr<OMShader> outputFrg;
86-
87-
std::chrono::high_resolution_clock::time_point tp;
88-
bool timing = false;
8973
};
9074
} // namespace openminecraftshell::renderer
9175

src/openminecraft-core/renderer/vk/om_renderer_layer_vk.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,13 @@
1919
#include "vulkan/vulkan_enums.hpp"
2020
#include "vulkan/vulkan_structs.hpp"
2121
#include <SDL3/SDL_vulkan.h>
22+
#include <chrono>
2223
#include <cstdlib>
2324
#include <cstring>
2425
#include <memory>
2526
#include <string>
2627
#include <system_error>
28+
#include <thread>
2729
#include <utility>
2830
#include <vector>
2931

src/openminecraft/application.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ void OMApplication::mainLoop(OMBackend backend)
115115
{
116116
using data::block::blockstateRegistry;
117117
world::OMChunk<16> cnk(cx, cy, cz);
118-
cnk.setBlock(0, 0, 0, blockstateRegistry.id(data::OMIdentifier("minecraft:blue_stained_glass[]")));
118+
cnk.setBlock(0, 0, 0, blockstateRegistry.id(data::OMIdentifier("minecraft:white_stained_glass[]")));
119119
cnk.setBlock(0, 1, 1, blockstateRegistry.id(data::OMIdentifier("minecraft:copper_ore[]")));
120120
cnk.setBlock(2, 0, 0,
121121
blockstateRegistry.id(data::OMIdentifier("minecraft:grass_block[snowy=false]")));

src/openminecraft/data/block/om_block_registry.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ void registerBlocks()
4242
OMBlock().isSoild(false).prop("shape", {"ascending_east", "ascending_north", "ascending_east", "ascending_west",
4343
"east_west", "north_east", "north_south", "north_west", "south_east",
4444
"south_west"}));
45-
blockRegistery.registerItem(OMIdentifier("minecraft:blue_stained_glass"),
45+
blockRegistery.registerItem(OMIdentifier("minecraft:white_stained_glass"),
4646
OMBlock().isSoild(false).isTranslucent(true));
4747
}
4848
} // namespace openminecraftshell::data::block

src/openminecraft/renderer/worldrenderer.cpp

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
#include "glm/ext/matrix_float4x4.hpp"
44
#include "glm/ext/matrix_transform.hpp"
55
#include "glm/ext/vector_float3.hpp"
6-
#include "glm/ext/vector_float4.hpp"
7-
#include "glm/geometric.hpp"
86
#include "openminecraft-shell/data/block/om_block_registery.hpp"
97
#include "openminecraft-shell/data/block/om_blockstate_registry.hpp"
108
#include "openminecraft-shell/data/block/om_blockstate_resolver.hpp"
@@ -22,7 +20,6 @@
2220
#include "openminecraft/renderer/common/wrap/om_renderer_voxel.hpp"
2321
#include "openminecraft/world/om_world_chunkmanager.hpp"
2422

25-
#include <chrono>
2623
#include <functional>
2724
#include <glm/glm.hpp>
2825
#include <memory>
@@ -41,11 +38,7 @@ OMWorldRenderer::OMWorldRenderer(OMRenderer *renderer, std::shared_ptr<basics::O
4138
uniformBuffer = renderer->allocateBuffer(Uniform, sizeof(glm::mat4));
4239
auto model = glm::rotate(glm::mat4(1.0f), glm::radians(-90.0f), glm::vec3(1.0f, 0.0f, 0.0f));
4340
uniformBuffer->updateData(&model);
44-
voxelModelBuffer = renderer->allocateBuffer(Uniform, sizeof(glm::mat4));
45-
glm::mat4 m(1.0f);
46-
voxelModelBuffer->updateData(&m);
4741
cameraBuffer = renderer->allocateBuffer(Uniform, sizeof(glm::mat4));
48-
lightingBuffer = renderer->allocateBuffer(Uniform, sizeof(LightingUniform));
4942

5043
outputFrg = renderer->shaderManager.preprocess("core/bilt.frag.glsl", Fragment, GLSLSource, format);
5144
outputVtx = renderer->shaderManager.preprocess("core/bilt.vert.glsl", Vertex, GLSLSource, format);
@@ -92,26 +85,8 @@ OMWorldRenderer::OMWorldRenderer(OMRenderer *renderer, std::shared_ptr<basics::O
9285
voxelManager->bindCameraBuffer(cameraBuffer);
9386
}
9487

95-
static float ang = 0.0f;
96-
9788
void OMWorldRenderer::beforeFrame()
9889
{
99-
if (!timing)
100-
{
101-
tp = std::chrono::high_resolution_clock::now();
102-
timing = true;
103-
}
104-
LightingUniform li;
105-
li.lightDirection = glm::normalize(glm::vec3(0.5, 0.5, 0.5));
106-
li.lightColor = glm::vec3(1.0);
107-
li.ambientColor = glm::vec3(0.05);
108-
109-
auto cam = camera->fetchProjMat() * camera->fetchViewMat();
110-
111-
cameraBuffer->updateData(&cam);
112-
lightingBuffer->updateData(&li);
113-
ang += 0.001f;
114-
11590
voxelManager->update(*camera);
11691
}
11792

@@ -122,6 +97,9 @@ void OMWorldRenderer::record()
12297

12398
void OMWorldRenderer::afterFrame()
12499
{
100+
auto cam = camera->fetchProjMat() * camera->fetchViewMat();
101+
102+
cameraBuffer->updateData(&cam);
125103
}
126104

127105
void OMWorldRenderer::submitTasks()
@@ -134,10 +112,8 @@ void OMWorldRenderer::submitTasks()
134112
}
135113
OMWorldRenderer::~OMWorldRenderer()
136114
{
137-
delete voxelModelBuffer;
138115
delete uniformBuffer;
139116
delete cameraBuffer;
140-
delete lightingBuffer;
141117
delete voxelManager;
142118
delete blockstateResolver;
143119
delete textureAtlas;

0 commit comments

Comments
 (0)