fix(geocoding-motis): validate config URLs are http(s) at setup

Fail fast with a clear error if the endpoint/transitousUrl config values are
malformed or non-http(s), instead of failing later with an opaque fetch error.
Allows localhost (the self-hosted MOTIS default), so this is a shape check, not
a private-address SSRF guard.

Author: Medformatik

integrations/geocoding-motis/index.ts

@@ -1,7 +1,11 @@
 import type { IntegrationContext } from "@openmapx/integration-framework";
 import { motisGeocodingService, setMotisLocalUrl, setTransitousUrl } from "./provider.js";
+import { assertHttpUrlConfig } from "./validate-config-url.js";
 
 export function setup(ctx: IntegrationContext): void {
+  assertHttpUrlConfig(ctx.config.endpoint, "endpoint");
+  assertHttpUrlConfig(ctx.config.transitousUrl, "transitousUrl");
+
   // Resolution order: service registry → manifest config → MOTIS_URL env →
   // localhost fallback. Mirrors transit-motis-local + live-transit-motis +
   // services/data-manager so ops can set MOTIS_URL once for the whole stack.

integrations/geocoding-motis/validate-config-url.test.ts

@@ -0,0 +1,18 @@
+import { describe, expect, it } from "vitest";
+import { assertHttpUrlConfig } from "./validate-config-url";
+
+describe("assertHttpUrlConfig", () => {
+  it("accepts http(s) URLs including localhost, and empty/undefined", () => {
+    expect(() => assertHttpUrlConfig("http://localhost:8081", "endpoint")).not.toThrow();
+    expect(() => assertHttpUrlConfig("https://motis.example.org", "endpoint")).not.toThrow();
+    expect(() => assertHttpUrlConfig(undefined, "endpoint")).not.toThrow();
+    expect(() => assertHttpUrlConfig("", "endpoint")).not.toThrow();
+  });
+
+  it("rejects non-http(s) and malformed URLs", () => {
+    expect(() => assertHttpUrlConfig("file:///etc/passwd", "endpoint")).toThrow();
+    expect(() => assertHttpUrlConfig("gopher://x", "endpoint")).toThrow();
+    expect(() => assertHttpUrlConfig("not a url", "endpoint")).toThrow();
+    expect(() => assertHttpUrlConfig(123, "endpoint")).toThrow();
+  });
+});

integrations/geocoding-motis/validate-config-url.ts

@@ -0,0 +1,21 @@
+/**
+ * Throw a clear error if an admin-supplied config URL is set but is not a
+ * syntactically valid http(s) URL. Allows localhost — a self-hosted MOTIS at
+ * `http://localhost:8081` is the legitimate default — so this is a fail-fast
+ * shape check, not a private-address SSRF guard.
+ */
+export function assertHttpUrlConfig(value: unknown, name: string): void {
+  if (value === undefined || value === null || value === "") return;
+  if (typeof value !== "string") {
+    throw new Error(`geocoding-motis config "${name}" must be a string URL`);
+  }
+  let parsed: URL;
+  try {
+    parsed = new URL(value);
+  } catch {
+    throw new Error(`geocoding-motis config "${name}" is not a valid URL: ${value}`);
+  }
+  if (parsed.protocol !== "http:" && parsed.protocol !== "https:") {
+    throw new Error(`geocoding-motis config "${name}" must use http(s): ${value}`);
+  }
+}