fix: transit and other bug fixes

Author: Medformatik

apps/api/src/routes/__tests__/transit.test.ts

@@ -112,7 +112,7 @@ const MOCK_STOP = {
   lat: 52.525,
   lng: 13.369,
   modes: ["rail"],
-  provider: "transitous",
+  provider: "mo",
 };
 
 const MOCK_DEPARTURE = {
@@ -123,7 +123,7 @@ const MOCK_DEPARTURE = {
   headsign: "Hamburg Hbf",
   canceled: false,
   route: { id: "r:1", shortName: "ICE 1", longName: "ICE Berlin-Hamburg", mode: "rail" },
-  providers: ["transitous"],
+  providers: ["mo"],
 };
 
 const MOCK_ROUTE = {
@@ -140,7 +140,7 @@ const MOCK_ALERT = {
   title: "Delay on ICE 1",
   description: "Due to construction work",
   severity: "warning",
-  providers: ["transitous"],
+  providers: ["mo"],
   affectedRouteIds: [],
   affectedStopIds: [],
 };
@@ -160,7 +160,7 @@ const MOCK_PLAN = {
 const MOCK_VEHICLE_JOURNEY = {
   id: "db:trip_123",
   name: "ICE 1",
-  provider: "transitous",
+  provider: "mo",
   stops: [],
 };
 

apps/api/src/services/__tests__/motis-geocoding.test.ts

@@ -128,7 +128,7 @@ describe("autocomplete", () => {
       lat: 52.52,
       lng: 13.37,
       modes: ["bus", "rail"],
-      provider: "transitous",
+      provider: "mo",
     });
     expect(results[0].rawCategory).toBe("train_station");
   });

apps/api/src/services/integration-health.ts

@@ -118,13 +118,15 @@ export async function executeIntegrationHealthCheck(
     };
   }
 
-  // URL template interpolation
+  // URL template interpolation (fall back to static url if template produces a broken URL)
   let checkUrl: string;
   if (hc.urlTemplate) {
-    checkUrl = (hc.urlTemplate as string).replace(
+    const resolved = (hc.urlTemplate as string).replace(
       /\$\{(\w+)\}/g,
       (_, key: string) => process.env[key] ?? "",
     );
+    const hasHost = /^https?:\/\/[^/]/.test(resolved);
+    checkUrl = hasHost ? resolved : ((hc.url as string | undefined) ?? resolved);
   } else if (hc.url) {
     checkUrl = hc.url as string;
   } else {

apps/api/src/services/transit/__tests__/dedup.test.ts

@@ -210,7 +210,7 @@ describe("deduplicateStops", () => {
     const stop2 = makeStop({
       id: "mo:2",
       name: "Berlin Hbf",
-      provider: "transitous",
+      provider: "mo",
       lat: 52.5251,
       lng: 13.3691,
     });
@@ -262,7 +262,7 @@ describe("deduplicateStops", () => {
       makeStop({
         id: "mo:1",
         name: "Berlin Hbf",
-        provider: "transitous",
+        provider: "mo",
         lat: 52.525,
         lng: 13.369,
       }),
@@ -299,7 +299,7 @@ describe("deduplicateStops", () => {
       makeStop({
         id: "mo:1",
         name: "Berlin Hauptbahnhof",
-        provider: "transitous",
+        provider: "mo",
         lat: 52.5251,
         lng: 13.3691,
       }),
@@ -314,7 +314,7 @@ describe("deduplicateStops", () => {
       makeStop({
         id: "mo:2",
         name: "Friedrichstraße",
-        provider: "transitous",
+        provider: "mo",
         lat: 52.5206,
         lng: 13.3868,
       }),

apps/api/src/services/transit/__tests__/orchestrator.test.ts

@@ -0,0 +1,188 @@
+import type { TransitProvider } from "@openmapx/core";
+import { describe, expect, it, vi } from "vitest";
+import { TransitOrchestrator } from "../orchestrator";
+
+function makeProvider(overrides: Partial<TransitProvider>): TransitProvider {
+  return {
+    id: "test-provider",
+    prefix: "tp:",
+    coverage: { bbox: [-180, -90, 180, 90] },
+    priority: 1,
+    capabilities: {
+      stops: true,
+      departures: true,
+      arrivals: true,
+      search: true,
+      tripPlanning: true,
+      alerts: true,
+      vehicles: true,
+    },
+    ...overrides,
+  };
+}
+
+describe("TransitOrchestrator.getRoutesForStop", () => {
+  it("derives routes from departures when provider route lookup is missing", async () => {
+    const departures = vi.fn().mockResolvedValue([
+      {
+        tripId: "trip-1",
+        route: {
+          id: "tp:r-1",
+          shortName: "Bus 1",
+          longName: "Bus 1",
+          mode: "bus",
+          color: "00AA00",
+        },
+        headsign: "Downtown",
+        scheduledAt: "2026-04-06T10:00:00Z",
+      },
+      {
+        tripId: "trip-2",
+        route: {
+          id: "tp:r-2",
+          shortName: "12345",
+          longName: "Trip Number",
+          mode: "bus",
+          color: "AA0000",
+        },
+        headsign: "Somewhere",
+        scheduledAt: "2026-04-06T10:05:00Z",
+      },
+    ]);
+
+    const orchestrator = new TransitOrchestrator();
+    orchestrator.register(
+      makeProvider({
+        id: "test-provider",
+        prefix: "tp:",
+        getDepartures: departures,
+      }),
+    );
+
+    const routes = await orchestrator.getRoutesForStop("tp:stop-1");
+
+    expect(departures).toHaveBeenCalledWith("tp:stop-1", 720);
+    expect(routes).toHaveLength(1);
+    expect(routes[0]).toMatchObject({
+      id: "tp:r-1",
+      shortName: "Bus 1",
+      longName: "Bus 1",
+      mode: "bus",
+      color: "00AA00",
+    });
+  });
+
+  it("uses provider route lookup when available and non-empty", async () => {
+    const getRoutesForStop = vi.fn().mockResolvedValue([
+      {
+        id: "tp:r-1",
+        shortName: "U1",
+        longName: "Main Line",
+        mode: "subway",
+        operatorName: "",
+      },
+    ]);
+    const departures = vi.fn().mockResolvedValue([]);
+
+    const orchestrator = new TransitOrchestrator();
+    orchestrator.register(
+      makeProvider({
+        id: "test-provider",
+        prefix: "tp:",
+        getRoutesForStop,
+        getDepartures: departures,
+      }),
+    );
+
+    const routes = await orchestrator.getRoutesForStop("tp:stop-1");
+
+    expect(routes).toHaveLength(1);
+    expect(getRoutesForStop).toHaveBeenCalledWith("tp:stop-1");
+    expect(departures).not.toHaveBeenCalled();
+  });
+});
+
+describe("TransitOrchestrator.getRouteStops", () => {
+  it("derives stop sequence from departure trip detail when provider route-stops lookup is missing", async () => {
+    const departures = vi.fn().mockResolvedValue([
+      {
+        tripId: "tp:trip-1",
+        route: {
+          id: "tp:r-1",
+          shortName: "Bus 1",
+          longName: "Bus 1",
+          mode: "bus",
+          color: "00AA00",
+        },
+        headsign: "Downtown",
+        scheduledAt: "2026-04-06T10:00:00Z",
+      },
+    ]);
+
+    const getVehicleJourney = vi.fn().mockResolvedValue({
+      id: "tp:trip-1",
+      name: "Bus 1",
+      provider: "test-provider",
+      stops: [
+        { stopId: "tp:s1", name: "First", lat: 50.1, lng: 6.1, platform: "1" },
+        { stopId: "tp:s2", name: "Second", lat: 50.2, lng: 6.2, platform: "2" },
+      ],
+    });
+
+    const orchestrator = new TransitOrchestrator();
+    orchestrator.register(
+      makeProvider({
+        id: "test-provider",
+        prefix: "tp:",
+        getDepartures: departures,
+        getVehicleJourney,
+      }),
+    );
+
+    const stops = await orchestrator.getRouteStops("tp:r-1", "tp:hint-stop");
+
+    expect(departures).toHaveBeenCalledWith("tp:hint-stop", 720);
+    expect(getVehicleJourney).toHaveBeenCalledWith("tp:trip-1");
+    expect(stops).toHaveLength(2);
+    expect(stops[0]).toMatchObject({
+      id: "tp:s1",
+      name: "First",
+      lat: 50.1,
+      lng: 6.1,
+      platformCode: "1",
+    });
+  });
+
+  it("uses provider route-stops endpoint when available and non-empty", async () => {
+    const getRouteStops = vi.fn().mockResolvedValue([
+      {
+        id: "tp:s1",
+        name: "First",
+        lat: 50.1,
+        lng: 6.1,
+        modes: ["bus"],
+        provider: "test-provider",
+      },
+    ]);
+    const departures = vi.fn().mockResolvedValue([]);
+    const getVehicleJourney = vi.fn().mockResolvedValue(null);
+
+    const orchestrator = new TransitOrchestrator();
+    orchestrator.register(
+      makeProvider({
+        id: "test-provider",
+        prefix: "tp:",
+        getRouteStops,
+        getDepartures: departures,
+        getVehicleJourney,
+      }),
+    );
+
+    const stops = await orchestrator.getRouteStops("tp:r-1", "tp:hint-stop");
+
+    expect(stops).toHaveLength(1);
+    expect(getRouteStops).toHaveBeenCalledWith("tp:r-1", "tp:hint-stop");
+    expect(departures).not.toHaveBeenCalled();
+    expect(getVehicleJourney).not.toHaveBeenCalled();
+  });
+});