refactor(admin): drop dead style-provider settings; base style is env-only

The web map selects its base style from NEXT_PUBLIC_STYLE_PROVIDER (maptiler |
openmapx), read at runtime via the EnvProvider context. The admin "Style
Provider" (MAP_STYLE_PROVIDER) and "Custom Style URL" (CUSTOM_STYLE_URL) fields
were keyed to different variables with a different value set and were read by no
code — saving them changed nothing. Remove both.

The Map group now keeps only the MapTiler API Key (env MAPTILER_KEY), consumed
by the server-side /api/maptiler proxy; drop its now-orphaned showWhen gate so
it always renders.

Author: Medformatik

apps/api/src/routes/__tests__/admin-settings.test.ts

@@ -176,6 +176,25 @@ describe("GET /admin/settings", () => {
     }
   });
 
+  it("keeps the live MapTiler key but drops the dead style-provider controls from the map group", async () => {
+    const res = await app.inject({ method: "GET", url: "/admin/settings" });
+    const body = res.json();
+
+    const map = body.groups.find((g: { id: string }) => g.id === "map");
+    const keys = map.settings.map((s: { key: string }) => s.key);
+
+    // The base style provider is env-only (NEXT_PUBLIC_STYLE_PROVIDER); the old
+    // MAP_STYLE_PROVIDER / CUSTOM_STYLE_URL admin fields drove nothing and are gone.
+    expect(keys).toContain("maptilerApiKey");
+    expect(keys).not.toContain("styleProvider");
+    expect(keys).not.toContain("customStyleUrl");
+
+    // With the provider dropdown gone, the key must not be gated behind a
+    // (now non-existent) styleProvider value — it always renders.
+    const apiKey = map.settings.find((s: { key: string }) => s.key === "maptilerApiKey");
+    expect(apiKey.showWhen).toBeUndefined();
+  });
+
   it("rejects unauthenticated requests with 401", async () => {
     mockRequireAdmin.mockRejectedValueOnce(
       Object.assign(new Error("Authentication required"), { statusCode: 401 }),

apps/api/src/routes/admin-settings.ts

@@ -27,8 +27,7 @@ interface SettingDef {
   /**
    * Show this setting only when another setting in the same group has a
    * matching value. Evaluated client-side against the current local form
-   * state. Used in the Map panel so MapTiler / Custom-style fields don't
-   * render when the chosen Style Provider doesn't need them.
+   * state — lets a panel hide fields that don't apply to the current choice.
    */
   showWhen?: { key: string; equals: unknown | unknown[] };
 }
@@ -205,35 +204,15 @@ const SETTING_DEFS: SettingDef[] = [
     default: true,
   },
   // Map
-  {
-    group: "map",
-    key: "styleProvider",
-    label: "Style Provider",
-    description: "Where to load the base map style from.",
-    type: "select",
-    options: ["maptiler", "self-hosted", "custom"],
-    env: "MAP_STYLE_PROVIDER",
-    default: "maptiler",
-  },
   {
     group: "map",
     key: "maptilerApiKey",
     label: "MapTiler API Key",
+    description: "MapTiler Cloud API key for the built-in MapTiler tile and style proxy.",
     type: "string",
     secret: true,
     env: "MAPTILER_KEY",
     default: "",
-    showWhen: { key: "styleProvider", equals: "maptiler" },
-  },
-  {
-    group: "map",
-    key: "customStyleUrl",
-    label: "Custom Style URL",
-    description: "Used when style provider is set to 'custom'.",
-    type: "string",
-    env: "CUSTOM_STYLE_URL",
-    default: "",
-    showWhen: { key: "styleProvider", equals: "custom" },
   },
   // Data-Use Policy
   {

apps/web/src/components/admin/settings/SystemSettings.tsx

@@ -288,10 +288,9 @@ function SettingsGroupPanel({
       const body: Record<string, unknown> = {};
       for (const s of group.settings) {
         if (s.envOverride) continue;
-        // Don't write fields hidden by their showWhen predicate — we'd
-        // otherwise clobber the stored value of the inactive provider
-        // (e.g. saving with styleProvider=self-hosted shouldn't reset
-        // maptilerApiKey or customStyleUrl).
+        // Don't write fields hidden by their showWhen predicate — saving while
+        // a field is hidden would clobber the stored value of the option that
+        // isn't currently active.
         if (!isVisible(s, localValues)) continue;
         body[s.key] = localValues[s.key];
       }

apps/web/src/components/admin/settings/__tests__/SystemSettings.test.tsx

@@ -41,43 +41,6 @@ afterEach(() => {
 });
 
 describe("SystemSettings env-override handling", () => {
-  it("hides the env-overrides badge when the only override is hidden by showWhen", async () => {
-    // Mirrors the Map panel: Style Provider is DB-sourced and visible, while
-    // the env-overridden MapTiler key is hidden because the provider isn't
-    // "maptiler". The panel must not claim an env override the operator can't see.
-    mockGroup("Map", [
-      {
-        group: "map",
-        key: "styleProvider",
-        label: "Style Provider",
-        type: "select",
-        options: ["maptiler", "self-hosted", "custom"],
-        secret: false,
-        value: "self-hosted",
-        source: "database",
-        envVar: "MAP_STYLE_PROVIDER",
-        envOverride: false,
-      },
-      {
-        group: "map",
-        key: "maptilerApiKey",
-        label: "MapTiler API Key",
-        type: "string",
-        secret: true,
-        value: "***",
-        source: "env",
-        envVar: "MAPTILER_KEY",
-        envOverride: true,
-        showWhen: { key: "styleProvider", equals: "maptiler" },
-      },
-    ]);
-
-    render(<SystemSettings />, { wrapper: createQueryWrapper() });
-
-    await screen.findByRole("button", { name: /save map/i });
-    expect(screen.queryByText("env overrides")).toBeNull();
-  });
-
   it("shows the env-overrides badge and disables a visible env-overridden field", async () => {
     mockGroup("Data-Use Policy", [
       {