fix: improve parameter definition validation and error reporting

This commit includes several improvements to parameter validation:
1. Add explicit validation for None values in allowedValues across all parameter types
2. Fix error location reporting in validation error messages
3. Correct documentation comments for maxValue parameters
4. Fix type casting in JobPathParameterDefinition
5. Add test cases for both implicit and explicit None handling

The changes ensure that explicitly set None values for allowedValues are properly
rejected with clear error messages, while implicitly omitted allowedValues
continue to work correctly.

Signed-off-by: Roman Yakobenchuk <66849711+ryyakobe@users.noreply.github.com>

Author: ryyakobe

src/openjd/model/v2023_09/_model.py

@@ -1187,6 +1187,10 @@ def _validate_max_length(cls, value: Optional[int], info: ValidationInfo) -> Opt
     def _validate_allowed_values_item(
         cls, value: AllowedParameterStringValueList, info: ValidationInfo
     ) -> AllowedParameterStringValueList:
+        if value is None:
+            raise ValueError(
+                "allowedValues cannot be None. The field must contain at least one value or be omitted entirely."
+            )
         min_length = info.data.get("minLength")
         max_length = info.data.get("maxLength")
         errors = list[InitErrorDetails]()
@@ -1397,7 +1401,7 @@ class JobPathParameterDefinition(OpenJDModel_v2023_09, JobParameterInterface):
             "default",
         },
         adds_fields=lambda this, symtab: {
-            "value": symtab[f"RawParam.{cast(JobStringParameterDefinition,this).name}"]
+            "value": symtab[f"RawParam.{cast(JobPathParameterDefinition,this).name}"]
         },
     )
 
@@ -1427,8 +1431,12 @@ def _validate_max_length(cls, value: Optional[int], info: ValidationInfo) -> Opt
     @field_validator("allowedValues")
     @classmethod
     def _validate_allowed_values_item(
-        cls, value: ParameterStringValue, info: ValidationInfo
-    ) -> ParameterStringValue:
+        cls, value: AllowedParameterStringValueList, info: ValidationInfo
+    ) -> AllowedParameterStringValueList:
+        if value is None:
+            raise ValueError(
+                "allowedValues cannot be None. The field must contain at least one value or be omitted entirely."
+            )
         min_length = info.data.get("minLength")
         max_length = info.data.get("maxLength")
         errors = list[InitErrorDetails]()
@@ -1438,7 +1446,7 @@ def _validate_allowed_values_item(
                     errors.append(
                         InitErrorDetails(
                             type="value_error",
-                            loc=("allowedValues", i),
+                            loc=(i,),
                             ctx={"error": ValueError("Value is shorter than minLength.")},
                             input=item,
                         )
@@ -1448,7 +1456,7 @@ def _validate_allowed_values_item(
                     errors.append(
                         InitErrorDetails(
                             type="value_error",
-                            loc=("allowedValues", i),
+                            loc=(i,),
                             ctx={"error": ValueError("Value is longer than maxLength.")},
                             input=item,
                         )
@@ -1586,7 +1594,7 @@ class JobIntParameterDefinition(OpenJDModel_v2023_09):
         allowedValues (Optional[AllowedIntParameterList]): Explicit list of values that the
             parameter is allowed to take on.
         minValue (Optional[int]): Minimum value that the parameter is allowed to be.
-        maxValue (Optional[int]): Minimum value that the parameter is allowed to be.
+        maxValue (Optional[int]): Maximum value that the parameter is allowed to be.
     """
 
     name: Identifier
@@ -1647,7 +1655,14 @@ def _validate_max_value_type(cls, value: Optional[Any]) -> Optional[Any]:
 
     @field_validator("allowedValues", mode="before")
     @classmethod
-    def _validate_allowed_values_item_type(cls, value: Any) -> Any:
+    def _validate_allowed_values_item_type(
+        cls, value: AllowedIntParameterList
+    ) -> AllowedIntParameterList:
+        if value is None:
+            raise ValueError(
+                "allowedValues cannot be None. The field must contain at least one value or be omitted entirely."
+            )
+
         errors = list[InitErrorDetails]()
         for i, item in enumerate(value):
             if isinstance(item, bool) or not isinstance(item, (int, str)):
@@ -1688,7 +1703,13 @@ def _validate_max_value(cls, value: Optional[int], info: ValidationInfo) -> Opti
 
     @field_validator("allowedValues")
     @classmethod
-    def _validate_allowed_values_item(cls, value: list[int], info: ValidationInfo) -> list[int]:
+    def _validate_allowed_values_item(
+        cls, value: AllowedIntParameterList, info: ValidationInfo
+    ) -> AllowedIntParameterList:
+        if value is None:
+            raise ValueError(
+                "allowedValues cannot be None. The field must contain at least one value or be omitted entirely."
+            )
         min_value = info.data.get("minValue")
         max_value = info.data.get("maxValue")
         errors = list[InitErrorDetails]()
@@ -1709,7 +1730,7 @@ def _validate_allowed_values_item(cls, value: list[int], info: ValidationInfo) -
                         InitErrorDetails(
                             type="value_error",
                             loc=(i,),
-                            ctx={"error": ValueError("Value larger than minValue.")},
+                            ctx={"error": ValueError("Value larger than maxValue.")},
                             input=item,
                         )
                     )
@@ -1832,7 +1853,7 @@ class JobFloatParameterDefinition(OpenJDModel_v2023_09):
         allowedValues (Optional[AllowedFloatParameterList]): Explicit list of values that the
             parameter is allowed to take on.
         minValue (Optional[Decimal]): Minimum value that the parameter is allowed to be.
-        maxValue (Optional[Decimal]): Minimum value that the parameter is allowed to be.
+        maxValue (Optional[Decimal]): Maximum value that the parameter is allowed to be.
     """
 
     name: Identifier
@@ -1885,8 +1906,12 @@ def _validate_max_value(
     @field_validator("allowedValues")
     @classmethod
     def _validate_allowed_values_item(
-        cls, value: list[Decimal], info: ValidationInfo
-    ) -> list[Decimal]:
+        cls, value: AllowedFloatParameterList, info: ValidationInfo
+    ) -> AllowedFloatParameterList:
+        if value is None:
+            raise ValueError(
+                "allowedValues cannot be None. The field must contain at least one value or be omitted entirely."
+            )
         min_value = info.data.get("minValue")
         max_value = info.data.get("maxValue")
         errors = list[InitErrorDetails]()