Commit 6e30ad0
authored
PoolOptions(JsonObject) does not initialize defaults first, unlike its
no-arg constructor and unlike WebClientOptions(JsonObject). The vertx
template's two-arg ApiClient constructor delegates with an empty pool
config, so buildWebClient built PoolOptions(new JsonObject()), leaving
maxLifetimeUnit null (and pool sizes 0). The first API call then threw
a NullPointerException from HttpClientImpl via WebClient.create.
Overlay poolConfig on the serialized no-arg defaults so absent keys keep
their documented values while explicit pool settings still apply.
Regenerated the vertx5 and vertx5-supportVertxFuture samples.
1 parent 1cfe9bf commit 6e30ad0
3 files changed
Lines changed: 29 additions & 3 deletions
File tree
- modules/openapi-generator/src/main/resources/Java/libraries/vertx
- samples/client/petstore/java
- vertx5-supportVertxFuture/src/main/java/org/openapitools/client
- vertx5/src/main/java/org/openapitools/client
Lines changed: 13 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
731 | 731 | | |
732 | 732 | | |
733 | 733 | | |
734 | | - | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
735 | 747 | | |
736 | 748 | | |
737 | 749 | | |
| |||
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
664 | 664 | | |
665 | 665 | | |
666 | 666 | | |
667 | | - | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
668 | 675 | | |
669 | 676 | | |
670 | 677 | | |
| |||
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
664 | 664 | | |
665 | 665 | | |
666 | 666 | | |
667 | | - | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
668 | 675 | | |
669 | 676 | | |
670 | 677 | | |
| |||
0 commit comments