Make php's array a primitive (#10093)

Fixes a bug where code generation would sometimes treat arrays as
objects and break serialization and code documentation.

Author: neclimdul

docs/generators/php-laravel.md

@@ -40,6 +40,7 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 
 <ul class="column-ul">
 <li>DateTime</li>
+<li>array</li>
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>

docs/generators/php-lumen.md

@@ -40,6 +40,7 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 
 <ul class="column-ul">
 <li>DateTime</li>
+<li>array</li>
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>

docs/generators/php-mezzio-ph.md

@@ -41,6 +41,7 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 
 <ul class="column-ul">
 <li>DateTime</li>
+<li>array</li>
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>

docs/generators/php-slim-deprecated.md

@@ -40,6 +40,7 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 
 <ul class="column-ul">
 <li>DateTime</li>
+<li>array</li>
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>

docs/generators/php-slim4.md

@@ -41,6 +41,7 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 
 <ul class="column-ul">
 <li>DateTime</li>
+<li>array</li>
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>

docs/generators/php.md

@@ -41,6 +41,7 @@ These options may be applied as additional-properties (cli) or configOptions (pl
 
 <ul class="column-ul">
 <li>DateTime</li>
+<li>array</li>
 <li>bool</li>
 <li>boolean</li>
 <li>byte</li>

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPhpCodegen.java

@@ -89,6 +89,7 @@ public AbstractPhpCodegen() {
                         "float",
                         "string",
                         "object",
+                        "array",
                         "DateTime",
                         "mixed",
                         "number",

modules/openapi-generator/src/test/java/org/openapitools/codegen/php/AbstractPhpCodegenTest.java

@@ -17,10 +17,16 @@
 
 package org.openapitools.codegen.php;
 
+import io.swagger.v3.oas.models.OpenAPI;
+import io.swagger.v3.oas.models.media.Schema;
+
 import org.openapitools.codegen.CodegenConstants;
+import org.openapitools.codegen.CodegenModel;
 import org.openapitools.codegen.CodegenOperation;
+import org.openapitools.codegen.CodegenProperty;
 import org.openapitools.codegen.CodegenType;
 import org.openapitools.codegen.languages.AbstractPhpCodegen;
+import org.openapitools.codegen.TestUtils;
 import org.testng.Assert;
 import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;
@@ -122,6 +128,24 @@ public static Object[][] composerNames() {
         };
     }
 
+    @Test(description = "Issue #8945")
+    public void testArrayOfArrays() {
+        final OpenAPI openAPI = TestUtils.parseFlattenSpec("src/test/resources/3_0/issue_8945.yaml");
+        final AbstractPhpCodegen codegen = new P_AbstractPhpCodegen();
+
+        Schema test1 = openAPI.getComponents().getSchemas().get("MyResponse");
+        CodegenModel cm1 = codegen.fromModel("MyResponse", test1);
+
+        // Make sure we got the container object.
+        Assert.assertEquals(cm1.getDataType(), "object");
+        Assert.assertEquals(codegen.getTypeDeclaration("MyResponse"), "\\php\\Model\\MyResponse");
+
+        // Assert the array type is properly detected.
+        CodegenProperty cp1 = cm1.vars.get(0);
+        cp1 = codegen.fromProperty("ArrayProp", test1);
+        Assert.assertTrue(cp1.isPrimitiveType);
+    }
+
     private static class P_AbstractPhpCodegen extends AbstractPhpCodegen {
         @Override
         public CodegenType getTag() {

modules/openapi-generator/src/test/resources/3_0/issue_8945.yaml

@@ -0,0 +1,50 @@
+openapi: 3.0.1
+info:
+  title: OpenAPI Petstore
+  description: "for schemas with properties and required ensure correct hasVars, hasRequired, vars, and requiredVars"
+  license:
+    name: Apache-2.0
+    url: https://www.apache.org/licenses/LICENSE-2.0.html
+  version: 1.0.0
+servers:
+  - url: http://petstore.swagger.io:80/v2
+tags: []
+paths:
+  /sut:
+    get:
+      operationId: getArrayOfArrays
+      responses:
+        '200':
+          description: OK
+          schema:
+            $ref: '#/definitions/MyResponse'
+components:
+  schemas:
+    MyResponse:
+      type: object
+      properties:
+        ArrayOfArrays:
+          type: array
+          items:
+            $ref: '#/components/schemas/ArrayProp'
+        ArrayOfObjects:
+          type: array
+          items:
+            $ref: '#/components/schemas/ObjectProp'
+    ArrayOfArrays:
+      type: array
+      items:
+        $ref: '#/components/schemas/ArrayProp'
+    ArrayOfObjects:
+      type: array
+      items:
+        $ref: '#/components/schemas/ObjectProp'
+    ArrayProp:
+      type: array
+      items:
+        type: string
+    ObjectProp:
+      type: object
+      properties:
+        name:
+          type: string

samples/client/petstore/php/OpenAPIClient-php/docs/Model/AdditionalPropertiesClass.md

@@ -5,6 +5,6 @@
 Name | Type | Description | Notes
 ------------ | ------------- | ------------- | -------------
 **map_property** | **array<string,string>** |  | [optional]
-**map_of_map_property** | [**array<string,array<string,string>>**](array.md) |  | [optional]
+**map_of_map_property** | **array<string,array<string,string>>** |  | [optional]
 
 [[Back to Model list]](../../README.md#models) [[Back to API list]](../../README.md#endpoints) [[Back to README]](../../README.md)