From a4f419c2d9fd946886f4f4956089b009938df961 Mon Sep 17 00:00:00 2001 From: JSv4 Date: Thu, 20 Aug 2026 14:34:50 -0500 Subject: [PATCH] ci: the gate comment said NOT YET REQUIRED; it is now required #2267 landed the job with a comment stating main had no required_status_checks object. That was true when written and false ~15 minutes later, once require_backend_ci_gate.sh --apply ran. Leaving it would be the same defect this repo keeps finding -- a document asserting a gate's state in the present tense without it being so. Records the enforce_admins=false caveat alongside it, and keeps the pointer to `gh api .../branches/main/protection` as the authority over the comment. Co-Authored-By: Claude Opus 5 --- .github/workflows/backend.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml index c7aef390e..ebd1d055e 100644 --- a/.github/workflows/backend.yml +++ b/.github/workflows/backend.yml @@ -293,11 +293,12 @@ jobs: # leaves a red linter mergeable (a job skipped by its own `if:` reports # SUCCESS to branch protection, and a red linter skips pytest). # - # NOT YET REQUIRED as of this commit: `main` has no `required_status_checks` - # object at all, so merging this job gates nothing by itself. Turn it on - # with .github/scripts/require_backend_ci_gate.sh --apply, and check with - # `gh api repos/{owner}/{repo}/branches/main/protection` whether that has - # happened rather than assuming this comment is current. + # Required on `main` as of 2026-08-20 (PR #2267). Note `enforce_admins` is + # false, so an admin can still bypass it. Re-apply or move it with + # .github/scripts/require_backend_ci_gate.sh --apply, and confirm the + # current state with + # `gh api repos/{owner}/{repo}/branches/main/protection` + # rather than assuming this comment is still accurate. # # `if: always()` is what makes this requirable: it reports on every PR, # including ones where every job above it was skipped.