Commit 2003199
committed
Show loader instead of not-found for mobile annotation deep-links
When deep-linking directly to an annotation on mobile before anything is
cached, the document and its annotations take a few seconds to load. During
that window the mobile Annotation sheet resolved the selected id against an
empty annotation set and rendered "This annotation is no longer available.",
wrongly implying the annotation was gone.
Thread the document loader's loading flag into MobileAnnotationDetail and
render a subtle spinning loader while loading is true and the annotation is
not yet resolved. The not-found message now only appears once loading settles
and the annotation is still unresolved.1 parent 7945fc7 commit 2003199
3 files changed
Lines changed: 69 additions & 4 deletions
File tree
- frontend/src/components/knowledge_base/document/layouts
- mobile
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
12 | 27 | | |
13 | 28 | | |
14 | 29 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
480 | 480 | | |
481 | 481 | | |
482 | 482 | | |
483 | | - | |
| 483 | + | |
484 | 484 | | |
485 | 485 | | |
486 | 486 | | |
| |||
Lines changed: 53 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
25 | 54 | | |
26 | 55 | | |
27 | 56 | | |
| |||
66 | 95 | | |
67 | 96 | | |
68 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
69 | 105 | | |
70 | 106 | | |
71 | 107 | | |
| |||
85 | 121 | | |
86 | 122 | | |
87 | 123 | | |
| 124 | + | |
88 | 125 | | |
89 | 126 | | |
90 | 127 | | |
| |||
99 | 136 | | |
100 | 137 | | |
101 | 138 | | |
102 | | - | |
| 139 | + | |
103 | 140 | | |
104 | | - | |
| 141 | + | |
105 | 142 | | |
106 | 143 | | |
107 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
108 | 158 | | |
109 | 159 | | |
110 | 160 | | |
| |||
0 commit comments