diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index e692024..f47824d 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -86,7 +86,12 @@ jobs: # needs no chart of its own. helm: name: Publish the Helm chart - needs: release-please + # Also on `docker`, not just on the release: the chart is packaged with the + # release version as its appVersion, so pushing it before the image exists + # publishes a chart that points at a tag nobody can pull yet - and leaves + # one published for good if the image build fails. `needs` implies success, + # so a skipped or failed docker job skips the chart too. + needs: [release-please, docker] if: needs.release-please.outputs.release_created == 'true' runs-on: ubuntu-latest permissions: