Skip to content

Commit fddec93

Browse files
TheMeinerLPclaude
andcommitted
fix(ci): publish the Helm chart only after the image
The helm job only depended on release-please, so it ran in parallel with the image build. Packaging and pushing a chart takes seconds while the build context, image build, chunked Harbor upload and signing take minutes, so the chart was reliably published pointing at an appVersion whose image did not exist yet - and stayed published even when the image build failed. Depend on the docker job as well, which also gates the chart on that job succeeding. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent a460177 commit fddec93

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

.github/workflows/release-please.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,12 @@ jobs:
8686
# needs no chart of its own.
8787
helm:
8888
name: Publish the Helm chart
89-
needs: release-please
89+
# Also on `docker`, not just on the release: the chart is packaged with the
90+
# release version as its appVersion, so pushing it before the image exists
91+
# publishes a chart that points at a tag nobody can pull yet - and leaves
92+
# one published for good if the image build fails. `needs` implies success,
93+
# so a skipped or failed docker job skips the chart too.
94+
needs: [release-please, docker]
9095
if: needs.release-please.outputs.release_created == 'true'
9196
runs-on: ubuntu-latest
9297
permissions:

0 commit comments

Comments
 (0)