From 5e4eb4f390d57a5277c2504c35d336f770111804 Mon Sep 17 00:00:00 2001 From: Matt Richardson Date: Mon, 6 Jul 2026 09:11:03 +1000 Subject: [PATCH] Cleanup @NotNull annotations --- .../server/OctopusBuildInformationBuildStartProcessor.java | 3 ++- .../teamcity/server/OctopusBuildInformationRunType.java | 2 ++ .../octopus/teamcity/server/OctopusCreateReleaseRunType.java | 2 ++ .../octopus/teamcity/server/OctopusDeployReleaseRunType.java | 2 ++ .../octopus/teamcity/server/OctopusPackPackageRunType.java | 2 ++ .../octopus/teamcity/server/OctopusPromoteReleaseRunType.java | 2 ++ .../octopus/teamcity/server/OctopusPushPackageRunType.java | 2 ++ 7 files changed, 14 insertions(+), 1 deletion(-) diff --git a/octopus-server/src/main/java/octopus/teamcity/server/OctopusBuildInformationBuildStartProcessor.java b/octopus-server/src/main/java/octopus/teamcity/server/OctopusBuildInformationBuildStartProcessor.java index a8231672..98c32732 100644 --- a/octopus-server/src/main/java/octopus/teamcity/server/OctopusBuildInformationBuildStartProcessor.java +++ b/octopus-server/src/main/java/octopus/teamcity/server/OctopusBuildInformationBuildStartProcessor.java @@ -11,6 +11,7 @@ import jetbrains.buildServer.serverSide.WebLinks; import jetbrains.buildServer.vcs.VcsRootInstanceEntry; import octopus.teamcity.common.OctopusConstants; +import org.jetbrains.annotations.NotNull; public class OctopusBuildInformationBuildStartProcessor implements BuildStartContextProcessor { @@ -25,7 +26,7 @@ public OctopusBuildInformationBuildStartProcessor( } @Override - public void updateParameters(final BuildStartContext buildStartContext) { + public void updateParameters(@NotNull final BuildStartContext buildStartContext) { try { boolean buildContainsBuildInformationStep = buildStartContext.getRunnerContexts().stream() diff --git a/octopus-server/src/main/java/octopus/teamcity/server/OctopusBuildInformationRunType.java b/octopus-server/src/main/java/octopus/teamcity/server/OctopusBuildInformationRunType.java index 9cc54b05..5011e9e3 100644 --- a/octopus-server/src/main/java/octopus/teamcity/server/OctopusBuildInformationRunType.java +++ b/octopus-server/src/main/java/octopus/teamcity/server/OctopusBuildInformationRunType.java @@ -47,11 +47,13 @@ public String getType() { return OctopusConstants.METADATA_RUNNER_TYPE; } + @NotNull @Override public String getDisplayName() { return "OctopusDeploy: Build Information"; } + @NotNull @Override public String getDescription() { return "Collect information related to the build, including commit messages, and store in custom build information in Octopus."; diff --git a/octopus-server/src/main/java/octopus/teamcity/server/OctopusCreateReleaseRunType.java b/octopus-server/src/main/java/octopus/teamcity/server/OctopusCreateReleaseRunType.java index acd959ec..c0c2769c 100644 --- a/octopus-server/src/main/java/octopus/teamcity/server/OctopusCreateReleaseRunType.java +++ b/octopus-server/src/main/java/octopus/teamcity/server/OctopusCreateReleaseRunType.java @@ -31,11 +31,13 @@ public String getType() { return OctopusConstants.CREATE_RELEASE_RUNNER_TYPE; } + @NotNull @Override public String getDisplayName() { return "OctopusDeploy: Create release"; } + @NotNull @Override public String getDescription() { return "Creates and, optionally, deploys releases in Octopus Deploy"; diff --git a/octopus-server/src/main/java/octopus/teamcity/server/OctopusDeployReleaseRunType.java b/octopus-server/src/main/java/octopus/teamcity/server/OctopusDeployReleaseRunType.java index cf24f63e..4926785e 100644 --- a/octopus-server/src/main/java/octopus/teamcity/server/OctopusDeployReleaseRunType.java +++ b/octopus-server/src/main/java/octopus/teamcity/server/OctopusDeployReleaseRunType.java @@ -47,11 +47,13 @@ public String getType() { return OctopusConstants.DEPLOY_RELEASE_RUNNER_TYPE; } + @NotNull @Override public String getDisplayName() { return "OctopusDeploy: Deploy release"; } + @NotNull @Override public String getDescription() { return "Deploys a specific release in Octopus Deploy"; diff --git a/octopus-server/src/main/java/octopus/teamcity/server/OctopusPackPackageRunType.java b/octopus-server/src/main/java/octopus/teamcity/server/OctopusPackPackageRunType.java index 610dc292..cbb8ec5b 100644 --- a/octopus-server/src/main/java/octopus/teamcity/server/OctopusPackPackageRunType.java +++ b/octopus-server/src/main/java/octopus/teamcity/server/OctopusPackPackageRunType.java @@ -45,11 +45,13 @@ public String getType() { return OctopusConstants.PACK_PACKAGE_RUNNER_TYPE; } + @NotNull @Override public String getDisplayName() { return "OctopusDeploy: Pack"; } + @NotNull @Override public String getDescription() { return "Packages files (.nupkg, .zip, .tar.gz, etc.)"; diff --git a/octopus-server/src/main/java/octopus/teamcity/server/OctopusPromoteReleaseRunType.java b/octopus-server/src/main/java/octopus/teamcity/server/OctopusPromoteReleaseRunType.java index 70bbae5c..6934b14e 100644 --- a/octopus-server/src/main/java/octopus/teamcity/server/OctopusPromoteReleaseRunType.java +++ b/octopus-server/src/main/java/octopus/teamcity/server/OctopusPromoteReleaseRunType.java @@ -47,11 +47,13 @@ public String getType() { return OctopusConstants.PROMOTE_RELEASE_RUNNER_TYPE; } + @NotNull @Override public String getDisplayName() { return "OctopusDeploy: Promote release"; } + @NotNull @Override public String getDescription() { return "Promotes a release from one environment to another with Octopus Deploy"; diff --git a/octopus-server/src/main/java/octopus/teamcity/server/OctopusPushPackageRunType.java b/octopus-server/src/main/java/octopus/teamcity/server/OctopusPushPackageRunType.java index cd2d35e3..0b75157e 100644 --- a/octopus-server/src/main/java/octopus/teamcity/server/OctopusPushPackageRunType.java +++ b/octopus-server/src/main/java/octopus/teamcity/server/OctopusPushPackageRunType.java @@ -47,11 +47,13 @@ public String getType() { return OctopusConstants.PUSH_PACKAGE_RUNNER_TYPE; } + @NotNull @Override public String getDisplayName() { return "OctopusDeploy: Push Packages"; } + @NotNull @Override public String getDescription() { return "Pushes package files (.nupkg, .zip, .tar.gz, etc.) to an Octopus Deploy server";