Fix CI Runners

Author: pgodwin

.github/workflows/pr-ci.yml

@@ -84,6 +84,7 @@ jobs:
           - "afp macgarden macip"
           - "afp sqlite_cnid"
           - "all"
+          - "ipx netbeui smb"
     steps:
       - name: Checkout
         uses: actions/checkout@v4

.gitignore

@@ -42,4 +42,5 @@ go.work.sum
 .macgarden/
 
 .captures/
-captures/
+captures/
+classicstack

.golangci.yml

@@ -17,26 +17,24 @@ linters:
     - revive
     - staticcheck
     - unused
-
-linters-settings:
-  errorlint:
-    errorf: true
-    asserts: true
-    comparison: true
-  revive:
+  settings:
+    errorlint:
+      errorf: true
+      asserts: true
+      comparison: true
+    revive:
+      rules:
+        - name: var-naming
+        - name: package-comments
+        - name: exported
+          disabled: true
+    gocritic:
+      disabled-checks:
+        - ifElseChain
+        - singleCaseSwitch
+  exclusions:
     rules:
-      - name: var-naming
-      - name: package-comments
-      - name: exported
-        disabled: true
-  gocritic:
-    disabled-checks:
-      - ifElseChain
-      - singleCaseSwitch
-
-issues:
-  exclude-rules:
-    - path: _test\.go$
-      linters:
-        - errcheck
-        - revive
+      - path: _test\.go$
+        linters:
+          - errcheck
+          - revive

classicstack

@@ -1,8 +1,24 @@
 $ErrorActionPreference = 'Stop'
 
-$packages = go list ./... | Where-Object { $_ -notmatch '(^|/)(dist|icon|icons)($|/)' }
-if (-not $packages) {
-    throw 'No packages found to test'
-}
+$tagSets = @(
+    ''
+    'afp'
+    'afp macgarden'
+    'afp macip'
+    'afp macgarden macip'
+    'afp sqlite_cnid'
+    'all'
+    'ipx netbeui smb'
+)
 
-go test $packages
+foreach ($tags in $tagSets) {
+    Write-Host "=== go test -tags `"$tags`" ==="
+    $packages = & go list -tags $tags ./... | Where-Object { $_ -notmatch '(^|/)(dist|icon|icons)($|/)' }
+    if (-not $packages) {
+        throw "No packages found to test for tags=`"$tags`""
+    }
+    & go test -tags $tags $packages
+    if ($LASTEXITCODE -ne 0) {
+        throw "go test failed for tags=`"$tags`""
+    }
+}

scripts/ci/test.ps1

@@ -12,6 +12,7 @@ tag_sets=(
   "afp macgarden macip"
   "afp sqlite_cnid"
   "all"
+  "ipx netbeui smb"
 )
 
 for tags in "${tag_sets[@]}"; do

scripts/ci/test.sh

@@ -1,4 +1,4 @@
-//go:build macgarden
+//go:build (afp && macgarden) || all
 
 package afp
 
@@ -17,6 +17,7 @@ import (
 	"unicode"
 
 	"github.com/ObsoleteMadness/ClassicStack/netlog"
+	"github.com/ObsoleteMadness/ClassicStack/pkg/vfs"
 	garden "github.com/ObsoleteMadness/ClassicStack/service/macgarden"
 )
 

service/afp/macgarden_fs.go

@@ -1,4 +1,4 @@
-//go:build afp && !macgarden
+//go:build (afp || all) && !macgarden && !all
 
 package afp
 
@@ -11,7 +11,7 @@ import (
 var ErrMacGardenDisabled = errors.New("macgarden backend not built; rebuild with -tags macgarden")
 
 func init() {
-	RegisterFS(FSTypeMacGarden, func(_ VolumeConfig) (FileSystem, error) {
+	RegisterFS(FSTypeMacGarden, func(_ VolumeConfig, _ Options) (FileSystem, error) {
 		return nil, ErrMacGardenDisabled
 	})
 }