Skip to content

Recent change to multiple races concept is a breaking change to a ratified convention #203

Description

@scottfavre

TL;DR - please update the article to preserve the old concept id for vocabulary versions prior to 2025 August to help out ETL authors

See 4e07e31

The ratified convention was to use concept 44814659.

Changing to the new concept 1546847 is a nontrivial change for existing sites:

  • The convention now only works for OMOP instances that are on the 2025 August vocabulary version
  • ETL code changes are required to use the change in the convention (it's just swapping out a concept id, but it is still a change)
  • Existing data needs to be migrated
  • Downstream queries need to be changed (e.g., data quality monitoring efforts, etc.)
  • Any studies that were looking for multiple races with the old concept will have to update to use the new concept.

This is not to suggest that we should not keep updating Themis, the newer concept is objectively better.

Rather, it would be very useful for people relying on Themis to make decisions in their ETLs to have more information than just the latest and greatest:

  • there is necessarily going to be lag between a new vocabulary release or a new Themis convention and implementation in ETLs
  • It is very useful to be able to cite a Themis convention in code when we are following that convention, but if the ratified conventions can change out from under us that is less useful.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions