[IMP] pos_user_restriction: Improve tests

Changes done:
- Remove context (TestPoSCommon already has it)
- Use the new_test_user() method to create users
- Use the BaseCommon class

Author: victoralmau

pos_user_restriction/tests/test_hacks.py

@@ -1,4 +1,4 @@
-from odoo.tests import tagged
+from odoo.tests import new_test_user, tagged
 
 from odoo.addons.point_of_sale.tests.common import TestPoSCommon
 
@@ -8,29 +8,10 @@ class TestHacks(TestPoSCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
-        cls.env = cls.env(
-            context=dict(
-                cls.env.context,
-                tracking_disable=True,
-                no_reset_password=True,
-            )
-        )
-        cls.pos_user_assigned_pos = cls.env["res.users"].create(
-            {
-                "login": "pos_user_assigned_pos",
-                "name": "pos_user_assigned_pos",
-                "groups_id": [
-                    (
-                        6,
-                        0,
-                        [
-                            cls.env.ref(
-                                "pos_user_restriction.group_assigned_points_of_sale_user"
-                            ).id
-                        ],
-                    )
-                ],
-            }
+        cls.pos_user_assigned_pos = new_test_user(
+            cls.env,
+            login="pos_user_assigned_pos",
+            groups="pos_user_restriction.group_assigned_points_of_sale_user",
         )
         cls.config = cls.basic_config
 

pos_user_restriction/tests/test_pos_user_restriction.py

@@ -1,40 +1,21 @@
-from odoo.tests.common import TransactionCase
+from odoo.tests import new_test_user
 
+from odoo.addons.base.tests.common import BaseCommon
 
-class TestUserRestriction(TransactionCase):
+
+class TestUserRestriction(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
-        cls.env = cls.env(
-            context=dict(
-                cls.env.context,
-                tracking_disable=True,
-                no_reset_password=True,
-            )
-        )
-        cls.pos_user = cls.env["res.users"].create(
-            {
-                "login": "pos_user",
-                "name": "pos_user",
-                "groups_id": [(6, 0, [cls.env.ref("point_of_sale.group_pos_user").id])],
-            }
+        cls.pos_user = new_test_user(
+            cls.env,
+            login="pos_user",
+            groups="point_of_sale.group_pos_user",
         )
-        cls.pos_user_assigned_pos = cls.env["res.users"].create(
-            {
-                "login": "pos_user_assigned_pos",
-                "name": "pos_user_assigned_pos",
-                "groups_id": [
-                    (
-                        6,
-                        0,
-                        [
-                            cls.env.ref(
-                                "pos_user_restriction.group_assigned_points_of_sale_user"
-                            ).id
-                        ],
-                    )
-                ],
-            }
+        cls.pos_user_assigned_pos = new_test_user(
+            cls.env,
+            login="pos_user_assigned_pos",
+            groups="pos_user_restriction.group_assigned_points_of_sale_user",
         )
         cls.pos_config_main = cls.env.ref("point_of_sale.pos_config_main")
         cls.pos_config_model = cls.env["pos.config"]