Skip to content

Honoring TWINE_ environment variables #154

Description

@ndejong

Currently the slap-cli publish sub-command does not honor the TWINE_* environment variables where-as twine-cli utility does -
https://twine.readthedocs.io/en/stable/index.html#configuration

Twine supports the following - TWINE_USERNAME, TWINE_PASSWORD, TWINE_REPOSITORY, TWINE_REPOSITORY_URL, TWINE_CERT, TWINE_NON_INTERACTIVE

These all map to options that are set with Cleo based options in src/slap/ext/application/publish.py that currently get passed through to Twine from slap-cli.

I'd propose simply recrafting all the respective options with something like below as appropriate for each -

option("username", "u", flag=False, default=os.getenv("TWINE_USERNAME", None))

For reference Cleo option.py looks like it should be okay with this.

Seems like a pretty simple thing, but before I charge right in and submit a PR, is this something that sounds about right to you?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions