Skip to content

Commit a3e4733

Browse files
Archive planning files for #20 + #43
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 6bdd64b commit a3e4733

5 files changed

Lines changed: 29 additions & 0 deletions

File tree

planning/archive/2026-05-issues-20-43-cd-compare-defaults-pvalue/.gitkeep

Whitespace-only changes.
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
## Outcome
2+
3+
Two tightly coupled `cd_compare()` improvements landed together on
4+
one branch (issue #20 explicitly says "should land together" with
5+
#43). #20 wired the de-facto vignette framing
6+
(`window_a = 2015:2025`, `window_b = 1951:1980` — recent decade vs
7+
WMO-style standard normal) into the function as defaults so first-time
8+
users get a sensible answer with `cd::cd_compare(ts)`. #43 added a
9+
`test = "t"` argument (default) that emits a `p_value` column via
10+
Welch's two-sample t-test on the annual values within each window;
11+
`test = "wilcox"` switches to Mann-Whitney U; `test = NULL` skips and
12+
drops the column. Rows where either window has < 8 non-NA years get
13+
NA + a single batched warning naming affected variable/period rows.
14+
Both regional vignettes now show bare `cd::cd_compare(ts)` recipes
15+
and report both p-values side-by-side (`Δ p (windows)` from
16+
cd_compare + `Trend p (75-yr)` from cd_trend's MK), framed in
17+
narrative as different-question tests. Mid-PR the user flagged that
18+
the cumulative-impact section ("Recent vs Pre-warming") was buried
19+
~300 lines down between Snowpack and Spatial Pattern with a
20+
methodological-sounding heading; reordered it to come directly after
21+
Trends and renamed to "Recent Decade vs Pre-Warming Reference" so
22+
the headline +2 °C number lands before DTR/Snow/Spatial drill-down.
23+
Compare-table chunk recomputes `cmp` from cached `ts` to flow the
24+
new column through without re-running the heavy precompute scripts;
25+
`data-raw/<vignette>_vignette_data.R` updated for next refresh.
26+
181/0 tests, lint clean, both vignettes render.
27+
28+
Closed by: PR #73 (squash `338c7e5`) → release commit `6bdd64b
29+
Release v0.3.0` → tag `v0.3.0`.

planning/active/findings.md renamed to planning/archive/2026-05-issues-20-43-cd-compare-defaults-pvalue/findings.md

File renamed without changes.

planning/active/progress.md renamed to planning/archive/2026-05-issues-20-43-cd-compare-defaults-pvalue/progress.md

File renamed without changes.

planning/active/task_plan.md renamed to planning/archive/2026-05-issues-20-43-cd-compare-defaults-pvalue/task_plan.md

File renamed without changes.

0 commit comments

Comments
 (0)