Skip to content

Commit 0a6a10a

Browse files
Remove bcsnowdata from Suggests; data-raw deps stay outside DESCRIPTION
The pkgdown CI on the squash-merge of #55 failed because bcsnowdata is GitHub-only (bcgov/bcsnowdata) and pak couldn't resolve it from CRAN/PPM. Convention in this repo (matching how bcdata and fresh are already handled in other data-raw scripts) is that data-raw scripts manage their own ad-hoc deps; the developer running the script installs what's needed. data-raw/qa_snow_validation.R header now includes the pak::pak() install instruction.
1 parent ad95143 commit 0a6a10a

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

DESCRIPTION

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ Roxygen: list(markdown = TRUE)
2323
RoxygenNote: 7.3.3
2424
Suggests:
2525
aws.s3,
26-
bcsnowdata,
2726
bookdown,
2827
ecmwfr,
2928
ggplot2,

data-raw/qa_snow_validation.R

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@
1717
# Filed against #48 Phase 3.
1818
#
1919
# Prerequisites:
20-
# - bcgov/bcsnowdata (in DESCRIPTION Suggests)
20+
# - bcgov/bcsnowdata installed locally (not in DESCRIPTION; data-raw
21+
# scripts manage their own deps per the cd convention). Install with:
22+
# pak::pak("bcgov/bcsnowdata")
23+
# (also requires `reshape` as a transitive dep)
2124
# - cd package installed (or devtools::load_all())
2225
# - Network access for ASWS / manual data + S3 reads
2326
#

0 commit comments

Comments
 (0)