Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Commit 4e38c8f

Browse files
committed
Revert unrelated RNG change
1 parent 2591827 commit 4e38c8f

6 files changed

Lines changed: 11 additions & 29 deletions

File tree

‎Cargo.toml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ itertools = "0.14.0"
3737
num-bigint = "0.4.6"
3838
num-integer = "0.1.46"
3939
num-traits = "0.2.19"
40-
rand = "0.9"
41-
rand_chacha = "0.9"
40+
rand = "0.9.2"
4241
rayon = { version = "1.10.0", optional = true }
4342
sha3 = "0.10.8"
4443
thiserror = "2.0.12"

‎src/transcript.rs‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -184,13 +184,6 @@ impl<I: Integer> ZipTranscript<I> for KeccakTranscript {
184184
self.get_integer_challenge::<Int<1>>().as_words()[0]
185185
}
186186

187-
fn sample_bytes(&mut self, buf: &mut [u8]) {
188-
buf.copy_from_slice(self.get_random_bytes(buf.len()).as_slice());
189-
self.hasher.update([0x12]);
190-
self.hasher.update(buf);
191-
self.hasher.update([0x34]);
192-
}
193-
194187
fn sample_unique_columns(
195188
&mut self,
196189
range: ark_std::ops::Range<usize>,

‎src/zip/code_raa.rs‎

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ pub struct RaaCode<ZT: ZipTypes> {
2323
num_proximity_testing: usize,
2424

2525
/// Randomness seed for the first permutation
26-
perm_1_seed: [u8; 32],
26+
perm_1_seed: u64,
2727

2828
/// Randomness seed for the second permutation
29-
perm_2_seed: [u8; 32],
29+
perm_2_seed: u64,
3030

3131
phantom: PhantomData<ZT>,
3232
}
@@ -71,10 +71,8 @@ impl<ZT: ZipTypes> RaaCode<ZT> {
7171
ZT::K::num_bits()
7272
);
7373

74-
let mut perm_1_seed = [0; 32];
75-
transcript.sample_bytes(&mut perm_1_seed);
76-
let mut perm_2_seed = [0; 32];
77-
transcript.sample_bytes(&mut perm_2_seed);
74+
let perm_1_seed = transcript.get_u64();
75+
let perm_2_seed = transcript.get_u64();
7876

7977
Self {
8078
row_len,
@@ -175,7 +173,6 @@ where
175173
#[cfg(test)]
176174
mod tests {
177175
use ark_std::{vec, vec::Vec};
178-
use itertools::Itertools;
179176
use num_traits::Zero;
180177

181178
use crate::{
@@ -248,13 +245,13 @@ mod tests {
248245

249246
#[test]
250247
fn shuffle_is_deterministic_for_a_given_seed() {
251-
let original: Vec<I> = (1..=1000).map(I::from).collect();
248+
let original: Vec<I> = (1..=10).map(I::from).collect();
252249
let mut vec1 = original.clone();
253250
let mut vec2 = original.clone();
254251
let mut vec3 = original.clone();
255252

256-
let seed1 = (0..32).collect_array().unwrap();
257-
let seed2 = (1..33).collect_array().unwrap();
253+
let seed1 = 12345;
254+
let seed2 = 54321;
258255

259256
shuffle_seeded(&mut vec1, seed1);
260257
shuffle_seeded(&mut vec2, seed1);

‎src/zip/pcs/structs.rs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ impl<K: Integer> MultilinearZipData<K> {
5757
pub trait ZipTranscript<I: Integer> {
5858
fn get_encoding_element(&mut self) -> I;
5959
fn get_u64(&mut self) -> u64;
60-
fn sample_bytes(&mut self, buf: &mut [u8]);
6160
fn sample_unique_columns(
6261
&mut self,
6362
range: ark_std::ops::Range<usize>,

‎src/zip/pcs/tests.rs‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,6 @@ impl<L: Integer> ZipTranscript<L> for MockTranscript {
3535
self.counter += 1;
3636
self.counter as u64
3737
}
38-
fn sample_bytes(&mut self, buf: &mut [u8]) {
39-
for byte in buf.iter_mut() {
40-
self.counter += 1;
41-
*byte = (self.counter % 256) as u8;
42-
}
43-
}
4438
fn sample_unique_columns(
4539
&mut self,
4640
range: Range<usize>,

‎src/zip/utils.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use ark_std::{
44
vec::Vec,
55
};
66
use num_integer::Integer as NumInteger;
7-
use rand::{SeedableRng, seq::SliceRandom};
7+
use rand::{SeedableRng, rngs::StdRng, seq::SliceRandom};
88

99
use crate::traits::{Integer, Words};
1010

@@ -136,8 +136,8 @@ pub(super) fn expand<N: Integer, M: Integer + for<'a> From<&'a N>>(narrow_int: &
136136
}
137137

138138
/// Reorder the elements in slice using the given randomness seed
139-
pub(super) fn shuffle_seeded<T>(slice: &mut [T], seed: [u8; 32]) {
140-
let mut rng = rand_chacha::ChaCha8Rng::from_seed(seed);
139+
pub(super) fn shuffle_seeded<T>(slice: &mut [T], seed: u64) {
140+
let mut rng = StdRng::seed_from_u64(seed);
141141
slice.shuffle(&mut rng);
142142
}
143143

0 commit comments

Comments
 (0)