fix(subscription): log send failures to the journal

Author: edospadoni

core/imageroot/var/lib/nethserver/cluster/bin/send-cluster-backup

@@ -59,6 +59,7 @@ elif [[ -f "${encrypted_file}" ]]; then
             fi
             curl \
                 --silent \
+                --show-error \
                 --location-trusted \
                 --fail-with-body \
                 --max-time 900 \

core/imageroot/var/lib/nethserver/cluster/bin/send-heartbeat

@@ -38,9 +38,14 @@ function send_heartbeat_nsent ()
         return 0
     fi
 
-    curl -m 30 --retry 3 -L -s -X POST \
+    # Surface failures (DNS, TLS, timeouts, HTTP errors) in the journal
+    # instead of swallowing them; the || keeps set -e and the loop alive.
+    local err
+    err=$(curl -m 30 --retry 3 -L -sSf -X POST \
         --user "${system_id:?}:${auth_token:?}" \
-        "${collect_url}/heartbeat" >/dev/null || :
+        -o /dev/null -w 'HTTP %{http_code}' \
+        "${collect_url}/heartbeat" 2>&1) || \
+        echo "<4>[WARNING] heartbeat send failed: ${err}" 1>&2
 }
 
 function send_heartbeat_nscom ()

core/imageroot/var/lib/nethserver/cluster/bin/send-inventory

@@ -36,12 +36,17 @@ function send_inventory_nsent ()
         return 0
     fi
 
-    print-phonehome | \
-    curl -m 180 --retry 3 -L -s -X POST \
+    # Surface failures (DNS, TLS, timeouts, HTTP errors) in the journal
+    # instead of swallowing them; the || keeps set -e satisfied.
+    local err
+    err=$(print-phonehome | \
+    curl -m 180 --retry 3 -L -sSf -X POST \
         --user "${system_id:?}:${auth_token:?}" \
         -H "Content-Type: application/json" \
         --data-binary @- \
-        "${collect_url}/inventory" >/dev/null || :
+        -o /dev/null -w 'HTTP %{http_code}' \
+        "${collect_url}/inventory" 2>&1) || \
+        echo "<4>[WARNING] inventory send failed: ${err}" 1>&2
 }
 
 function send_inventory_nscom ()