[CSTACKEX-216] Review Comments for Igroup Name Length (#79)

### Description

Issue: "getIgroupName() truncates the full "cs__" string as a whole. If
svmName is long, this can truncate away most or all of the hostUuid
portion, increasing the chance of igroup name collisions across
different hosts (and also throws a NullPointerException if hostUuid is
null). Consider validating inputs and truncating svmName first so the
host UUID remains intact (or, if hostUuid itself is too long, truncate
only the UUID)."

Fix: In typical deployments, truncation likely never triggers bcz total
length will remain less than 96. But to avoid any issues for future
where svm limits get exceeded, will change the igroup format to
cs_hostUuid_svmName

Note: This is a breaking change for existing deployments. Igroups
already on ONTAP use the old format (cs_svm1_hostname). After this
change, CloudStack will look for cs_<uuid>_svm1 and may not find
existing igroup

<!---
*******************************************************************************
-->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*******************************************************************************
-->

### Types of changes

- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)

### Feature/Enhancement Scale or Bug Severity

#### Feature/Enhancement Scale

- [ ] Major
- [ ] Minor

#### Bug Severity

- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial

### Screenshots (if appropriate):

<img width="1383" height="321" alt="image"
src="https://github.com/user-attachments/assets/d051a3d3-7069-4936-a21c-d53b1ba368f6"
/>
<img width="1505" height="766" alt="image"
src="https://github.com/user-attachments/assets/128256ef-d000-41a3-9359-78f48d45eced"
/>


### How Has This Been Tested?

1- Created 1st VM on ISCSI Storage pool - Igroup got create with new
name format attached a screen shot and lun got mapped
2- Create 2nd VM on same storage pool - Igroup got reused and lun got
mapped
3- Storage Pool to enter maintenance mode - All Luns got unmapped and
igroup also got deleted
4- Storage Pool to cancel maintenance mode - New Igroup got created with
same name format and All Luns got mapped again.
5-Create a new CloudStack volume and attched to the instance - used the
existing igroup and mapped the lun
6- Delete All VMs - Igroup got deleted

#### How did you try to break this feature and the system with this
change?

<!-- see how your change affects other areas of the code, etc. -->

<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->

Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

Author: suryag1201

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/OntapStorageUtils.java

@@ -149,9 +149,9 @@ public static StorageStrategy getStrategyByStoragePoolDetails(Map<String, String
     }
 
     public static String getIgroupName(String svmName, String hostUuid) {
-        //Igroup name format: cs_svmName_hostUuid
+        //Igroup name format: cs_hostUuid_svmName
         String sanitizedHostUuid = hostUuid.replaceAll("[^a-zA-Z0-9_-]", "_");
-        String igroupName = OntapStorageConstants.CS + OntapStorageConstants.UNDERSCORE + svmName + OntapStorageConstants.UNDERSCORE + sanitizedHostUuid;
+        String igroupName = OntapStorageConstants.CS + OntapStorageConstants.UNDERSCORE + sanitizedHostUuid + OntapStorageConstants.UNDERSCORE + svmName;
         // ONTAP igroup names are limited to 96 characters; truncate if longer.
         if (igroupName.length() > OntapStorageConstants.IGROUP_NAME_MAX_LENGTH) {
             igroupName = igroupName.substring(0, OntapStorageConstants.IGROUP_NAME_MAX_LENGTH);

plugins/storage/volume/ontap/src/test/java/org/apache/cloudstack/storage/utils/OntapStorageUtilsTest.java

@@ -29,7 +29,7 @@ public class OntapStorageUtilsTest {
     public void getIgroupName_returnsExpectedFormat_whenWithinLimit() {
         String result = OntapStorageUtils.getIgroupName("svm1", "host-uuid-123");
 
-        assertEquals("cs_svm1_host-uuid-123", result);
+        assertEquals("cs_host-uuid-123_svm1", result);
         assertTrue(result.length() <= OntapStorageConstants.IGROUP_NAME_MAX_LENGTH);
     }
 
@@ -38,20 +38,20 @@ public void getIgroupName_sanitizesInvalidCharacters() {
         // Characters outside [a-zA-Z0-9_-] in the host uuid must be replaced with '_'.
         String result = OntapStorageUtils.getIgroupName("svm1", "host.uuid:123/abc");
 
-        assertEquals("cs_svm1_host_uuid_123_abc", result);
+        assertEquals("cs_host_uuid_123_abc_svm1", result);
     }
 
     @Test
     public void getIgroupName_doesNotTruncate_whenExactlyAtMaxLength() {
-        // Format: cs(2) + _(1) + svmName + _(1) + hostUuid
+        // Format: cs(2) + _(1) + hostUuid + _(1) + svmName
         // For an overall length of 96 with a 4-char uuid, svmName must be 88 chars.
         String svmName = "a".repeat(88);
         String hostUuid = "uuid";
 
         String result = OntapStorageUtils.getIgroupName(svmName, hostUuid);
 
         assertEquals(OntapStorageConstants.IGROUP_NAME_MAX_LENGTH, result.length());
-        assertEquals("cs_" + svmName + "_" + hostUuid, result);
+        assertEquals("cs_" + hostUuid + "_" + svmName, result);
     }
 
     @Test
@@ -63,15 +63,15 @@ public void getIgroupName_truncates_whenExceedingMaxLength() {
 
         assertEquals(OntapStorageConstants.IGROUP_NAME_MAX_LENGTH, result.length());
         // The truncated value must still be a prefix of the full, untruncated name.
-        String fullName = "cs_" + svmName + "_" + hostUuid;
+        String fullName = "cs_" + hostUuid + "_" + svmName;
         assertEquals(fullName.substring(0, OntapStorageConstants.IGROUP_NAME_MAX_LENGTH), result);
         assertTrue(result.startsWith("cs_"));
     }
 
     @Test
     public void getIgroupName_truncates_whenOneCharOverMaxLength() {
         // Build a name that is exactly one character over the limit (97 chars):
-        // svmName of 89 chars + 4-char uuid -> 2 + 1 + 89 + 1 + 4 = 97.
+        // svmName of 89 chars + 4-char uuid -> 2 + 1 + 4 + 1 + 89 = 97.
         String svmName = "a".repeat(89);
         String hostUuid = "uuid";