fix: cache selector group UIAppearance accessors

DjDeveloperr · DjDeveloperr · commit c26766ef18e3 · 2026-06-29T10:23:36.000-04:00
diff --git a/HANDOFF.md b/HANDOFF.md
@@ -111,6 +111,36 @@ During this thread `agent-device` was version `0.18.0`; the npm package is
 
 ## Current Verified State
 
+Update from 2026-06-29 10:22 EDT:
+
+- Simulator-only rule remains active. Do not use physical iPhone/iPad devices.
+- GitHub Actions run `28376322394` on `9699fefc` kept setup, dependency
+  install, FFI boundary, V8 download, libffi build, metadata generation,
+  NativeScript build, CLI build, and macOS tests green, but still failed iOS
+  only in `ApiTests.js Appearance`: `UILabel.appearance().textColor` read
+  back `undefined`.
+- CI disproved the protocol-accessor cache as the final missing path. The
+  likely bypass is the generated selector-group functions installed as JS
+  property accessors by `Install.mm`, which call metadata selectors directly
+  instead of `NativeApiObjectHostObject::get/set` or protocol accessors.
+- Runtime fix in progress:
+  - Prepared Objective-C invocations now record the JS property name for
+    one-argument metadata property setters such as `setTextColor:`.
+  - Selector-group property getters now consult the target-class-scoped
+    UIAppearance expando cache before calling UIKit's proxy getter.
+  - JSC, QuickJS, Hermes, and V8 selector-group generated/fast/generic setter
+    paths now populate the same cache after a successful native setter call.
+- Local verification after this patch:
+  - Runtime RN JS tests passed:
+    `for f in packages/react-native/test/*.test.js; do node "$f" || exit 1; done`.
+  - `npm run check:ffi-boundaries` passed.
+  - `git diff --check` passed.
+  - `npm run build:macos-cli` passed.
+- Not done:
+  - Commit/push the selector-group UIAppearance cache fix and watch fresh PR
+    CI.
+  - If CI turns green, resume the dedicated simulator-only RNS parity sweep.
+
 Update from 2026-06-29 09:38 EDT:
 
 - Simulator-only rule remains active. Do not use physical iPhone/iPad devices.
diff --git a/NativeScript/ffi/hermes/NativeApiJsi.mm b/NativeScript/ffi/hermes/NativeApiJsi.mm
@@ -175,6 +175,13 @@ throw JSError(runtime,
 
         const bool propertyGetterCall =
             entry.hasMember && entry.member.property && count == 0;
+        if (propertyGetterCall) {
+          Value appearanceExpando = cachedAppearanceProxyPropertyValue(
+              runtime, bridge, receiver, entry.member.name);
+          if (!appearanceExpando.isUndefined()) {
+            return appearanceExpando;
+          }
+        }
         const std::string* selectorNamePtr = &entry.selectorName;
         const NativeApiMember* selectedMember =
             entry.hasMember ? &entry.member : nullptr;
@@ -267,6 +274,8 @@ throw JSError(runtime,
           GsdObjCContext ctx{runtime, bridge, receiver, prepared->selector,
                              args, prepared->signature.returnType};
           if (invoker(ctx)) {
+            cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver,
+                                                    *prepared, args, count);
             return std::move(ctx.result);
           }
         }
diff --git a/NativeScript/ffi/jsc/NativeApiJSCSelectorGroups.mm b/NativeScript/ffi/jsc/NativeApiJSCSelectorGroups.mm
@@ -112,6 +112,11 @@ throw JSError(
     GsdObjCContext ctx{runtime,  bridge,    receiver, prepared.selector,
                        runtime.context(), arguments, signature.returnType};
     if (invoker(ctx)) {
+      if (providedCount > 0) {
+        Value setterValue = Value::borrowed(runtime, arguments[0]);
+        cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver,
+                                                prepared, &setterValue, 1);
+      }
       return ctx.result;
     }
   }
@@ -126,6 +131,9 @@ throw JSError(
     if (tryCallFastEngineObjCSelector(runtime, bridge, receiver, prepared,
                                       fastArgs, providedCount, Nil,
                                       &fastResult)) {
+      cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver,
+                                              prepared, fastArgs,
+                                              providedCount);
       fastResult = tagPreparedStaticAppearanceSelectorResult(
           runtime, bridge, receiver, prepared, std::move(fastResult));
       return fastResult.local(runtime);
@@ -198,6 +206,11 @@ NativeApiReturnStorage returnStorage(
     throw JSError(
         runtime, errorMessage != nullptr ? errorMessage : "Unknown NSError");
   }
+  if (providedCount > 0) {
+    Value setterValue = Value::borrowed(runtime, arguments[0]);
+    cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver,
+                                            prepared, &setterValue, 1);
+  }
   if (initializerClassWrapper) {
     id resultObject = nil;
     if (isObjectiveCObjectType(returnType)) {
@@ -270,6 +283,13 @@ throw JSError(runtime,
 
     const bool propertyGetterCall =
         entry.hasMember && entry.member.property && argumentCount == 0;
+    if (propertyGetterCall) {
+      Value appearanceExpando = cachedAppearanceProxyPropertyValue(
+          runtime, data->bridge, receiver, entry.member.name);
+      if (!appearanceExpando.isUndefined()) {
+        return appearanceExpando.local(runtime);
+      }
+    }
     const std::string* selectorNamePtr = &entry.selectorName;
     const NativeApiMember* selectedMember =
         entry.hasMember ? &entry.member : nullptr;
diff --git a/NativeScript/ffi/quickjs/NativeApiQuickJSSelectorGroups.mm b/NativeScript/ffi/quickjs/NativeApiQuickJSSelectorGroups.mm
@@ -111,6 +111,11 @@ throw JSError(
     GsdObjCContext ctx{runtime,           bridge,    receiver, prepared.selector,
                        runtime.context(), arguments, signature.returnType};
     if (invoker(ctx)) {
+      if (providedCount > 0) {
+        Value setterValue = Value::borrowed(runtime, arguments[0]);
+        cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver,
+                                                prepared, &setterValue, 1);
+      }
       return ctx.result;
     }
   }
@@ -125,6 +130,9 @@ throw JSError(
     if (tryCallFastEngineObjCSelector(runtime, bridge, receiver, prepared,
                                       fastArgs, providedCount, Nil,
                                       &fastResult)) {
+      cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver,
+                                              prepared, fastArgs,
+                                              providedCount);
       fastResult = tagPreparedStaticAppearanceSelectorResult(
           runtime, bridge, receiver, prepared, std::move(fastResult));
       return fastResult.local(runtime);
@@ -198,6 +206,11 @@ NativeApiReturnStorage returnStorage(
     throw JSError(
         runtime, errorMessage != nullptr ? errorMessage : "Unknown NSError");
   }
+  if (providedCount > 0) {
+    Value setterValue = Value::borrowed(runtime, arguments[0]);
+    cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver,
+                                            prepared, &setterValue, 1);
+  }
   if (initializerClassWrapper) {
     id resultObject = nil;
     if (isObjectiveCObjectType(returnType)) {
@@ -292,6 +305,13 @@ throw JSError(runtime,
 
     const bool propertyGetterCall =
         entry.hasMember && entry.member.property && count == 0;
+    if (propertyGetterCall) {
+      Value appearanceExpando = cachedAppearanceProxyPropertyValue(
+          runtime, data->bridge, receiver, entry.member.name);
+      if (!appearanceExpando.isUndefined()) {
+        return appearanceExpando.local(runtime);
+      }
+    }
     const std::string* selectorNamePtr = &entry.selectorName;
     const NativeApiMember* selectedMember =
         entry.hasMember ? &entry.member : nullptr;
diff --git a/NativeScript/ffi/shared/bridge/Invocation.mm b/NativeScript/ffi/shared/bridge/Invocation.mm
@@ -521,6 +521,7 @@ bool signatureSupportedForEngineInvocation(
   SEL selector = nullptr;
   Class receiverClass = Nil;
   std::string selectorName;
+  std::string propertySetterName;
   NativeApiSignature signature;
   ObjCPreparedInvoker preparedInvoker = nullptr;
   void* engineInvoker = nullptr;  // Engine-neutral GSD invoker (ObjCGsdInvoker)
@@ -539,6 +540,17 @@ bool preparedObjCInvocationIsInit(
   return prepared.isInitMethod;
 }
 
+void cachePreparedAppearanceProxySetterValue(
+    Runtime& runtime, const std::shared_ptr<NativeApiBridge>& bridge,
+    id receiver, const NativeApiPreparedObjCInvocation& prepared,
+    const Value* args, size_t count) {
+  if (prepared.propertySetterName.empty() || args == nullptr || count == 0) {
+    return;
+  }
+  cacheAppearanceProxyPropertyValue(runtime, bridge, receiver,
+                                    prepared.propertySetterName, args[0]);
+}
+
 bool isFastEngineObjectType(const NativeApiType& type) {
   switch (type.kind) {
     case metagen::mdTypeAnyObject:
@@ -1472,6 +1484,12 @@ throw JSError(
   prepared->selector = selector;
   prepared->receiverClass = receiverIsClass ? lookupClass : Nil;
   prepared->selectorName = selectorName;
+  if (member != nullptr && member->property && !member->name.empty() &&
+      !member->setterSelectorName.empty() &&
+      selectorName == member->setterSelectorName &&
+      selectorArgumentCount(selectorName) == 1) {
+    prepared->propertySetterName = member->name;
+  }
   prepared->signature = std::move(*signature);
   prepared->preparedInvoker = lookupObjCPreparedInvoker(
       dispatchIdForEngineSignature(prepared->signature,
@@ -1531,11 +1549,15 @@ throw JSError(runtime,
   if (tryCallGeneratedEngineObjCSelector(runtime, bridge, receiver, prepared,
                                          args, count, dispatchSuperClass,
                                          &fastResult)) {
+    cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver,
+                                            prepared, args, count);
     return tagPreparedStaticAppearanceSelectorResult(
         runtime, bridge, receiver, prepared, std::move(fastResult));
   }
   if (tryCallFastEngineObjCSelector(runtime, bridge, receiver, prepared, args,
                                     count, dispatchSuperClass, &fastResult)) {
+    cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver,
+                                            prepared, args, count);
     return tagPreparedStaticAppearanceSelectorResult(
         runtime, bridge, receiver, prepared, std::move(fastResult));
   }
@@ -1624,6 +1646,8 @@ NativeApiReturnStorage returnStorage(
     throw JSError(
         runtime, errorMessage != nullptr ? errorMessage : "Unknown NSError");
   }
+  cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver, prepared,
+                                          args, count);
   Value result = convertNativeReturnValue(runtime, bridge, returnType,
                                           returnStorage.data());
   return tagPreparedStaticAppearanceSelectorResult(
diff --git a/NativeScript/ffi/v8/NativeApiV8SelectorGroups.mm b/NativeScript/ffi/v8/NativeApiV8SelectorGroups.mm
@@ -106,6 +106,11 @@ throw JSError(
                        runtime.context(),
                        signature.returnType};
     if (invoker(ctx)) {
+      if (providedCount > 0) {
+        Value setterValue = Value::borrowed(runtime, info[0]);
+        cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver,
+                                                prepared, &setterValue, 1);
+      }
       return;
     }
   }
@@ -120,6 +125,9 @@ throw JSError(
     if (tryCallFastEngineObjCSelector(runtime, bridge, receiver, prepared,
                                       fastArgs, providedCount, Nil,
                                       &fastResult)) {
+      cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver,
+                                              prepared, fastArgs,
+                                              providedCount);
       fastResult = tagPreparedStaticAppearanceSelectorResult(
           runtime, bridge, receiver, prepared, std::move(fastResult));
       info.GetReturnValue().Set(fastResult.local(runtime));
@@ -193,6 +201,11 @@ NativeApiReturnStorage returnStorage(
     throw JSError(
         runtime, errorMessage != nullptr ? errorMessage : "Unknown NSError");
   }
+  if (providedCount > 0) {
+    Value setterValue = Value::borrowed(runtime, info[0]);
+    cachePreparedAppearanceProxySetterValue(runtime, bridge, receiver,
+                                            prepared, &setterValue, 1);
+  }
   if (initializerClassWrapper) {
     id resultObject = nil;
     if (isObjectiveCObjectType(returnType)) {
@@ -263,6 +276,14 @@ throw JSError(runtime,
 
     const bool propertyGetterCall =
         entry.hasMember && entry.member.property && count == 0;
+    if (propertyGetterCall) {
+      Value appearanceExpando = cachedAppearanceProxyPropertyValue(
+          runtime, data->bridge, receiver, entry.member.name);
+      if (!appearanceExpando.isUndefined()) {
+        info.GetReturnValue().Set(appearanceExpando.local(runtime));
+        return;
+      }
+    }
     const std::string* selectorNamePtr = &entry.selectorName;
     const NativeApiMember* selectedMember =
         entry.hasMember ? &entry.member : nullptr;
@@ -389,6 +410,12 @@ throw JSError(runtime,
                          runtime.context(),
                          prepared->signature.returnType};
       if (invoker(ctx)) {
+        if (count > 0) {
+          Value setterValue = Value::borrowed(runtime, info[0]);
+          cachePreparedAppearanceProxySetterValue(runtime, data->bridge,
+                                                  receiver, *prepared,
+                                                  &setterValue, 1);
+        }
         return;
       }
     }
diff --git a/PROGRESS.md b/PROGRESS.md
@@ -17,6 +17,38 @@ TypeScript/UI worklets.
 
 ## Latest Update - 2026-06-29
 
+### 2026-06-29 10:22 EDT - cached selector-group UIAppearance accessors
+
+- Goal:
+  - Keep PR #46 on the generic runtime primitive path and unblock the final
+    simulator-only RN Screens parity sweep; no physical devices were used.
+- CI finding:
+  - GitHub Actions run `28376322394` on `9699fefc` kept setup, dependencies,
+    FFI boundary check, V8 download, libffi build, metadata generation,
+    NativeScript build, CLI build, and macOS tests green, but still failed iOS
+    `ApiTests.js Appearance` only: `UILabel.appearance().textColor` read back
+    as `undefined`.
+  - That disproved the protocol-accessor cache as the remaining path. The
+    failing assignment/readback is consistent with metadata property accessors
+    installed by `Install.mm`, where JS getter/setter functions call selector
+    groups directly and bypass object-host/protocol accessors.
+- Changes:
+  - Prepared Objective-C invocations now record the JS property name for
+    one-argument metadata property setters.
+  - Selector-group property getters now consult the target-class-scoped
+    UIAppearance expando cache before calling through to UIKit's proxy getter.
+  - JSC, QuickJS, Hermes, and V8 selector-group generated/fast/generic setter
+    paths now populate that cache after successful native setter calls.
+- Verification:
+  - Runtime RN JS tests passed:
+    `for f in packages/react-native/test/*.test.js; do node "$f" || exit 1; done`.
+  - `npm run check:ffi-boundaries` passed.
+  - `git diff --check` passed.
+  - `npm run build:macos-cli` passed.
+- Still next:
+  - Commit/push the selector-group cache fix, watch fresh PR CI, then return
+    to the dedicated simulator-only RNS parity sweep if CI is green.
+
 ### 2026-06-29 09:38 EDT - cached protocol-backed UIAppearance accessors
 
 - Goal:
