fix: preserve initializer bridge state

Author: DjDeveloperr

NativeScript/ffi/shared/bridge/ClassBuilder.mm

@@ -105,6 +105,19 @@ void rememberNativeApiKnownExposedMethod(
     return std::nullopt;
   }
 
+  std::shared_ptr<NativeApiObjectHostObject> resultHostObject;
+  if (result.isObject()) {
+    Object resultObjectValue = result.asObject(runtime);
+    if (resultObjectValue.isHostObject<NativeApiObjectHostObject>(runtime)) {
+      resultHostObject =
+          resultObjectValue.getHostObject<NativeApiObjectHostObject>(runtime);
+    }
+  }
+
+  if (resultHostObject != nullptr && resultHostObject != receiverHostObject) {
+    resultHostObject->detachObjectPreservingBridgeState(receiver);
+  }
+
   Value preserved(runtime, receiverValue);
   bridge->rememberRoundTripValue(runtime, receiver, preserved);
   return preserved;

NativeScript/ffi/shared/bridge/HostObjects.mm

@@ -1044,6 +1044,24 @@ void disownObject(id expected) {
     }
   }
 
+  void detachObjectPreservingBridgeState(id expected) {
+    if (object_ != expected) {
+      return;
+    }
+
+    id object = object_;
+    bool releaseObject = ownsObject_;
+    ownsObject_ = false;
+    wrapperRetainedObject_ = false;
+    object_ = nil;
+    if (lifetimeState_ != nullptr) {
+      lifetimeState_->clear();
+    }
+    if (releaseObject && object != nil) {
+      [object release];
+    }
+  }
+
   static bool isInitializerSelector(const std::string& selectorName) {
     return selectorName.rfind("init", 0) == 0;
   }

PROGRESS.md

@@ -17,6 +17,43 @@ TypeScript/UI worklets.
 
 ## Latest Update - 2026-06-29
 
+### 2026-06-29 23:30 EDT - initializer result wrapper cache preservation
+
+- Scope check:
+  - This is still RN-module branch CI stabilization after the branch split from
+    `refactor`. The change is a generic NativeScript JS-subclass runtime fix, not
+    a React Native Screens native implementation and not a Node-API/direct-engine
+    backend refactor change.
+  - Simulator-only rule remains active; no physical devices were used.
+- Finding:
+  - The remaining `NSMutableArrayMethods` failure path still points at
+    JS-backed Objective-C subclass wrapper churn around `init`/native callbacks.
+  - Initializer self-preservation restored the original JS receiver, but the
+    temporary native init-result wrapper could still tear down round-trip/object
+    expando bridge state for the same native pointer when it was collected.
+- Change:
+  - Added a `NativeApiObjectHostObject` detach helper for temporary initializer
+    result wrappers. It releases that wrapper's native ownership without clearing
+    bridge round-trip or object-expando state owned by the restored receiver.
+  - `preservedNativeApiInitializerSelfReturn` now detaches a distinct temporary
+    result wrapper before remembering the original receiver as the authoritative
+    round-trip value.
+  - Removed the temporary `NSMutableArrayMethods` JS/Objective-C trace logging
+    from the test fixture.
+- Verification:
+  - Focused runtime source guards passed:
+    `runtime-instance-selector-base-dispatch`, `runtime-js-subclass-expando`, and
+    `runtime-indexed-collection-alias`.
+  - Runtime RN JS tests passed:
+    `for f in packages/react-native/test/*.test.js; do node "$f" || exit 1; done`.
+  - `git diff --check` passed.
+  - `npm run check:ffi-boundaries` passed.
+  - `npm run build:macos-cli` passed.
+- Still next:
+  - Commit/push this clean runtime fix and watch fresh PR CI. If it clears the
+    iOS simulator runtime tests, return to the dedicated RNS simulator parity
+    sweep against original RNS.
+
 ### 2026-06-29 22:20 EDT - indexed collection fast enumeration for JS subclasses
 
 - CI finding:

packages/react-native/test/runtime-instance-selector-base-dispatch.test.js

@@ -41,6 +41,8 @@ for (const relativePath of [
   assert(
     source.includes("receiverHostObject->object() != receiver") &&
       source.includes("NativeApiObjectHostObject::nativeObjectFromValue(runtime, result)") &&
+      source.includes("resultHostObject != receiverHostObject") &&
+      source.includes("detachObjectPreservingBridgeState(receiver)") &&
       source.includes("bridge->rememberRoundTripValue(runtime, receiver,") &&
       source.includes("return preserved;"),
     `${relativePath}: initializer dispatch should preserve the original JS receiver when native init returns self`,
@@ -71,4 +73,18 @@ for (const relativePath of [
   );
 }
 
+for (const relativePath of [
+  "NativeScript/ffi/shared/bridge/HostObjects.mm",
+  "packages/react-native/native-api/ffi/shared/bridge/HostObjects.mm",
+]) {
+  const source = fs.readFileSync(path.join(repoRoot, relativePath), "utf8");
+  assert(
+    source.includes("void detachObjectPreservingBridgeState(id expected)") &&
+      source.includes("if (releaseObject && object != nil)") &&
+      source.includes("[object release];") &&
+      !source.includes("detachObjectPreservingBridgeState(id expected) {\n    if (object_ == expected) {\n      if (bridge_ != nullptr"),
+    `${relativePath}: temporary initializer result wrappers should detach without clearing live receiver bridge state`,
+  );
+}
+
 console.log("runtime instance selector base dispatch tests passed");

test/runtime/fixtures/TNSTestNativeCallbacks.m

@@ -331,44 +331,20 @@ + (void)recordsPointer:(TNSSimpleStruct*)object {
 }
 
 + (void)apiNSMutableArrayMethods:(NSMutableArray*)object {
-  NSLog(@"[NSMutableArrayMethods] native enter object=%p class=%@", object, NSStringFromClass([object class]));
-  NSLog(@"[NSMutableArrayMethods] native before add b");
   [object addObject:@"b"];
-  NSLog(@"[NSMutableArrayMethods] native after add b");
-  NSLog(@"[NSMutableArrayMethods] native before add x");
   [object addObject:@"x"];
-  NSLog(@"[NSMutableArrayMethods] native after add x");
-  NSLog(@"[NSMutableArrayMethods] native before add c");
   [object addObject:@"c"];
-  NSLog(@"[NSMutableArrayMethods] native after add c");
-  NSLog(@"[NSMutableArrayMethods] native before add y");
   [object addObject:@"y"];
-  NSLog(@"[NSMutableArrayMethods] native after add y");
-  NSLog(@"[NSMutableArrayMethods] native before add z");
   [object addObject:@"z"];
-  NSLog(@"[NSMutableArrayMethods] native after add z");
-  NSLog(@"[NSMutableArrayMethods] native before insert a");
   [object insertObject:@"a" atIndex:0];
-  NSLog(@"[NSMutableArrayMethods] native after insert a");
-  NSLog(@"[NSMutableArrayMethods] native before remove index 2");
   [object removeObjectAtIndex:2];
-  NSLog(@"[NSMutableArrayMethods] native after remove index 2");
-  NSLog(@"[NSMutableArrayMethods] native before remove last");
   [object removeLastObject];
-  NSLog(@"[NSMutableArrayMethods] native after remove last");
-  NSLog(@"[NSMutableArrayMethods] native before subscript replace");
   object[3] = @"d";
-  NSLog(@"[NSMutableArrayMethods] native after subscript replace");
-  NSLog(@"[NSMutableArrayMethods] native before count/hash");
   TNSLog([NSString stringWithFormat:@"%tu%tu", [object count], [object hash]]);
-  NSLog(@"[NSMutableArrayMethods] native after count/hash");
 
-  NSLog(@"[NSMutableArrayMethods] native before enumeration");
   for (id x in object) {
-    NSLog(@"[NSMutableArrayMethods] native enumerate %@", x);
     TNSLog([NSString stringWithFormat:@"%@", x]);
   }
-  NSLog(@"[NSMutableArrayMethods] native exit");
 }
 
 + (void)apiSwizzle:(TNSSwizzleKlass*)object {

test/runtime/runner/app/tests/ApiTests.js

@@ -249,11 +249,8 @@ describe(module.id, function () {
     it("NSMutableArrayMethods", function () {
         var JSMutableArray = NSMutableArray.extend({
             init: function () {
-                console.log("[NSMutableArrayMethods] js init enter", this.nativeAddress);
                 var self = NSMutableArray.prototype.init.apply(this, arguments);
-                console.log("[NSMutableArrayMethods] js init base returned", self === this, self.nativeAddress);
                 self._array = [];
-                console.log("[NSMutableArrayMethods] js init array ready", self._array.length);
                 return self;
             },
 // TODO
@@ -263,40 +260,27 @@ describe(module.id, function () {
 //                NSMutableArray.prototype.dealloc.apply(this, arguments);
 //            },
             insertObjectAtIndex: function (anObject, index) {
-                console.log("[NSMutableArrayMethods] js insert enter", anObject, index, this._array && this._array.length);
                 this._array.splice(index, 0, anObject);
-                console.log("[NSMutableArrayMethods] js insert exit", this._array.length);
             },
             removeObjectAtIndex: function (index) {
-                console.log("[NSMutableArrayMethods] js remove enter", index, this._array && this._array.length);
                 this._array.splice(index, 1);
-                console.log("[NSMutableArrayMethods] js remove exit", this._array.length);
             },
             addObject: function (anObject) {
-                console.log("[NSMutableArrayMethods] js add enter", anObject, this._array && this._array.length);
                 this._array.push(anObject);
-                console.log("[NSMutableArrayMethods] js add exit", this._array.length);
             },
             removeLastObject: function () {
-                console.log("[NSMutableArrayMethods] js removeLast enter", this._array && this._array.length);
                 this._array.pop();
-                console.log("[NSMutableArrayMethods] js removeLast exit", this._array.length);
             },
             replaceObjectAtIndexWithObject: function (index, anObject) {
-                console.log("[NSMutableArrayMethods] js replace enter", index, anObject, this._array && this._array.length);
                 this._array[index] = anObject;
-                console.log("[NSMutableArrayMethods] js replace exit", this._array.length);
             },
             objectAtIndex: function (index) {
-                console.log("[NSMutableArrayMethods] js objectAtIndex", index, this._array && this._array.length);
                 return this._array[index];
             },
             get count() {
-                console.log("[NSMutableArrayMethods] js count", this._array && this._array.length);
                 return this._array.length;
             },
             get hash() {
-                console.log("[NSMutableArrayMethods] js hash enter");
                 return this.count;
             }
         }, {
@@ -305,9 +289,7 @@ describe(module.id, function () {
 
         (function () {
             var array = new JSMutableArray();
-            console.log("[NSMutableArrayMethods] js before native callback", array.nativeAddress, array._array && array._array.length);
             TNSTestNativeCallbacks.apiNSMutableArrayMethods(array);
-            console.log("[NSMutableArrayMethods] js after native callback", array._array && array._array.length);
         }());
         gc();