test: expose iOS simulator hangs

Author: DjDeveloperr

.github/workflows/ci.yml

@@ -53,5 +53,6 @@ jobs:
           IOS_TEST_TIMEOUT_MS: "600000"
           IOS_TEST_INACTIVITY_TIMEOUT_MS: "180000"
           IOS_LOG_JUNIT: "1"
+          IOS_TEST_VERBOSE_SPECS: "1"
           IOS_SIMCTL_QUERY_TIMEOUT_MS: "10000"
         run: npm run test:ios

HANDOFF.md

@@ -110,6 +110,43 @@ During this thread `agent-device` was version `0.18.0`; the npm package is
 
 ## Current Verified State
 
+Update from 2026-06-29 17:34 EDT:
+
+- Simulator-only rule remains active. Do not use physical iPhone/iPad devices.
+- Draft PR #46 branch is still
+  `codex/rn-module-fabric-turbomodule-worklets` and cleanly separated from the
+  original Node-API/direct-engine `refactor` goal.
+- GitHub Actions run `28402087730` on `99889cb0` kept setup, dependency
+  install, FFI boundary check, V8 download, libffi build, metadata generation,
+  NativeScript build, CLI build, and macOS tests green.
+- The previous iOS simulator `ApiTests.js Appearance`
+  `UILabel.appearance().textColor` readback assertion did not reappear, so the
+  stable backend runtime key fix appears to have cleared that blocker.
+- Current iOS simulator blocker:
+  - Full-suite iOS launched `TestRunner`, printed `Application Start!`, then
+    five skipped-spec markers, and later failed because post-timeout
+    diagnostics threw while running:
+    `xcrun simctl spawn <udid> ps -axo pid,ppid,stat,etime,command`.
+  - The failure log therefore did not identify the hanging Jasmine spec.
+- Current test-runner fix:
+  - iOS simulator post-timeout diagnostics now treat `simctl log show` and
+    `simctl spawn ... ps` failures as warning text instead of throwing away
+    the underlying timeout context.
+  - CI now sets `IOS_TEST_VERBOSE_SPECS=1` so the next authoritative iOS
+    simulator run names each spec start/done and should expose the real
+    hanging spec.
+- Local verification:
+  - `node packages/react-native/test/ios-runner-diagnostics.test.js` passed.
+  - Runtime RN JS tests passed:
+    `for f in packages/react-native/test/*.test.js; do node "$f" || exit 1; done`.
+  - `git diff --check` passed.
+  - `npm run check:ffi-boundaries` passed.
+- Not done:
+  - Commit/push the iOS runner diagnostics patch and watch fresh PR CI.
+  - Use the named hanging spec from CI to continue fixing the runtime/RN
+    primitive, not by adding retries/timers or simulator-only shims.
+  - If CI turns green, resume the dedicated simulator-only RNS parity sweep.
+
 Update from 2026-06-29 16:55 EDT:
 
 - Simulator-only rule remains active. Do not use physical iPhone/iPad devices.

PROGRESS.md

@@ -17,6 +17,40 @@ TypeScript/UI worklets.
 
 ## Latest Update - 2026-06-29
 
+### 2026-06-29 17:34 EDT - iOS simulator hang diagnostics
+
+- Goal:
+  - Keep PR #46 on the RN module / generic runtime primitive branch and stay
+    simulator-only. No physical devices were used.
+- CI finding:
+  - GitHub Actions run `28402087730` on `99889cb0` kept setup, dependency
+    install, FFI boundary check, V8 download, libffi build, metadata
+    generation, NativeScript build, CLI build, and macOS tests green.
+  - The previous iOS `ApiTests.js Appearance`
+    `UILabel.appearance().textColor` failure did not reappear, which points to
+    the stable runtime-expando key fix clearing that blocker.
+  - The current iOS simulator run still hung after `Application Start!` and
+    five skipped-spec markers, but the failure was obscured when post-timeout
+    diagnostics threw on `xcrun simctl spawn ... ps`.
+- Changes:
+  - Made iOS runner post-timeout simulator log and process snapshot collection
+    best-effort. Diagnostic failures now print warnings instead of replacing
+    the actual test timeout context.
+  - Enabled `IOS_TEST_VERBOSE_SPECS=1` in CI so the next iOS simulator run
+    names each spec start/done and exposes the real hanging spec.
+  - Added a source guard for the diagnostic behavior and CI verbose-spec flag.
+- Verification:
+  - `node packages/react-native/test/ios-runner-diagnostics.test.js` passed.
+  - Runtime RN JS tests passed:
+    `for f in packages/react-native/test/*.test.js; do node "$f" || exit 1; done`.
+  - `git diff --check` passed.
+  - `npm run check:ffi-boundaries` passed.
+- Still next:
+  - Commit/push this diagnostics patch and watch the fresh PR CI.
+  - Use the named iOS simulator hanging spec to fix the runtime/RN primitive
+    path directly.
+  - If CI turns green, resume the dedicated simulator-only RNS parity sweep.
+
 ### 2026-06-29 16:55 EDT - stable runtime keys for object expandos
 
 - Goal:

packages/react-native/test/ios-runner-diagnostics.test.js

@@ -0,0 +1,28 @@
+const assert = require("assert");
+const fs = require("fs");
+const path = require("path");
+
+const repoRoot = path.resolve(__dirname, "../../..");
+const runner = fs.readFileSync(path.join(repoRoot, "scripts/run-tests-ios.js"), "utf8");
+const ci = fs.readFileSync(path.join(repoRoot, ".github/workflows/ci.yml"), "utf8");
+
+assert(
+  runner.includes("function collectSimulatorProcessSnapshot(udid, options = {})") &&
+    runner.includes("if (options.includeErrors)") &&
+    runner.includes("WARNING: unable to collect simulator process snapshot") &&
+    runner.includes("collectSimulatorProcessSnapshot(udid, { includeErrors: true })"),
+  "iOS test runner diagnostics should report simctl ps failures without throwing away the test timeout context",
+);
+
+assert(
+  runner.includes("WARNING: unable to collect recent simulator logs") &&
+    runner.includes("simctl exited ${result.status}"),
+  "iOS test runner diagnostics should report simctl log collection failures without aborting diagnostics",
+);
+
+assert(
+  ci.includes('IOS_TEST_VERBOSE_SPECS: "1"'),
+  "CI should emit per-spec iOS simulator logs so hung runtime specs are identifiable",
+);
+
+console.log("iOS runner diagnostics tests passed");

scripts/run-tests-ios.js

@@ -967,22 +967,28 @@ function collectRecentSimulatorLogs(udid, pid) {
         ? `processID == ${pid}`
         : 'process == "TestRunner"';
 
-    const result = run("xcrun", [
-        "simctl",
-        "spawn",
-        udid,
-        "log",
-        "show",
-        "--style",
-        "compact",
-        "--last",
-        simulatorLogLookback,
-        "--predicate",
-        predicate
-    ]);
+    let result;
+    try {
+        result = run("xcrun", [
+            "simctl",
+            "spawn",
+            udid,
+            "log",
+            "show",
+            "--style",
+            "compact",
+            "--last",
+            simulatorLogLookback,
+            "--predicate",
+            predicate
+        ]);
+    } catch (error) {
+        return `WARNING: unable to collect recent simulator logs: ${error.message}`;
+    }
 
     if (result.status !== 0) {
-        return "";
+        const detail = (result.stderr || result.stdout || "").trim();
+        return `WARNING: unable to collect recent simulator logs (simctl exited ${result.status}${detail ? `: ${detail}` : ""}).`;
     }
 
     const text = result.stdout || "";
@@ -1065,11 +1071,26 @@ function readJunitFileState(udid) {
     };
 }
 
-function collectSimulatorProcessSnapshot(udid) {
-    const result = run("xcrun", ["simctl", "spawn", udid, "ps", "-axo", "pid,ppid,stat,etime,command"], {
-        timeout: simctlQueryTimeoutMs
-    });
+function collectSimulatorProcessSnapshot(udid, options = {}) {
+    let result;
+    try {
+        result = run("xcrun", ["simctl", "spawn", udid, "ps", "-axo", "pid,ppid,stat,etime,command"], {
+            timeout: simctlQueryTimeoutMs
+        });
+    } catch (error) {
+        if (options.includeErrors) {
+            return `WARNING: unable to collect simulator process snapshot: ${error.message}`;
+        }
+
+        return null;
+    }
+
     if (result.status !== 0) {
+        if (options.includeErrors) {
+            const detail = (result.stderr || result.stdout || "").trim();
+            return `WARNING: unable to collect simulator process snapshot (simctl exited ${result.status}${detail ? `: ${detail}` : ""}).`;
+        }
+
         return null;
     }
 
@@ -1125,7 +1146,7 @@ function formatInactivityDiagnostics(udid, state, pid) {
     }
     sections.push(`--- App container state ---\n${junitSummaryLines.join("\n")}`);
 
-    const processSnapshot = collectSimulatorProcessSnapshot(udid);
+    const processSnapshot = collectSimulatorProcessSnapshot(udid, { includeErrors: true });
     if (processSnapshot) {
         sections.push(`--- Simulator process snapshot ---\n${processSnapshot}`);
     }