fix: preserve init receiver native identity

Author: DjDeveloperr

NativeScript/ffi/shared/bridge/ClassBuilder.mm

@@ -119,7 +119,7 @@ void rememberNativeApiKnownExposedMethod(
   }
 
   Value preserved(runtime, receiverValue);
-  bridge->rememberRoundTripValue(runtime, receiver, preserved);
+  bridge->rememberNativeObjectRoundTripValue(runtime, receiver, preserved);
   return preserved;
 }
 

NativeScript/ffi/shared/bridge/ObjCBridge.mm

@@ -674,6 +674,13 @@ void rememberRoundTripValue(Runtime& runtime, const void* native,
 #endif
   }
 
+  void rememberNativeObjectRoundTripValue(Runtime& runtime, id object,
+                                          const Value& value,
+                                          bool stringLikeNative = false) {
+    rememberRoundTripValue(runtime, object, value, stringLikeNative,
+                           nativeObjectClassKey(object));
+  }
+
   void rememberScopedRoundTripValue(Runtime& runtime, const void* native,
                                     const Value& value,
                                     bool stringLikeNative = false,

PROGRESS.md

@@ -17,6 +17,43 @@ TypeScript/UI worklets.
 
 ## Latest Update - 2026-06-30
 
+### 2026-06-30 00:32 EDT - preserved init receivers use native-object round-trip keys
+
+- Scope check:
+  - This is still generic NativeScript JS-subclass construction/runtime identity
+    work for PR #46. It is not React Native Screens-specific and does not touch
+    the original `refactor` branch's direct-engine backend goal.
+  - Simulator-only rule remains active; no physical devices were used.
+- CI finding:
+  - GitHub Actions run `28419724124` on `ca530965` built successfully but failed
+    macOS tests before iOS ran.
+  - The single failure was
+    `InheritanceTests.js ExposeVariadicSelector`: a native call into a
+    JS-exposed selector returned a wrapper for the same native object, but not
+    the identical JS object expected by `toBe(object)`.
+  - The alloc/init constructor path exposed that initializer-preserved wrappers
+    were being stored in the round-trip cache without the native-object class
+    validation key used by ordinary native return marshalling.
+- Change:
+  - Added `NativeApiBridge::rememberNativeObjectRoundTripValue(...)`, which
+    stores persistent native-object wrapper identity with the same validation key
+    that `makeNativeObjectValue`/native return conversion later requires.
+  - `preservedNativeApiInitializerSelfReturn` now uses that helper when
+    re-establishing the original JS receiver after native `init` returns `self`.
+  - Source coverage guards that preserved initializer receivers use the
+    native-object round-trip path rather than the unvalidated generic path.
+- Verification:
+  - Runtime RN JS tests passed:
+    `for f in packages/react-native/test/*.test.js; do node "$f" || exit 1; done`.
+  - `git diff --check` passed.
+  - `npm run check:ffi-boundaries` passed.
+  - `npm run build:macos-cli` passed.
+- Still next:
+  - Commit/push this identity-cache correction and watch fresh PR CI. macOS
+    should get past `InheritanceTests.js ExposeVariadicSelector`; iOS then needs
+    to prove whether the zero-argument alloc/init constructor path fixes
+    `ApiTests.js NSMutableArrayMethods`.
+
 ### 2026-06-30 00:10 EDT - JS subclasses use remembered alloc/init construction
 
 - Scope check:

packages/react-native/test/runtime-instance-selector-base-dispatch.test.js

@@ -53,7 +53,7 @@ for (const relativePath of [
       source.includes("NativeApiObjectHostObject::nativeObjectFromValue(runtime, result)") &&
       source.includes("resultHostObject != receiverHostObject") &&
       source.includes("detachObjectPreservingBridgeState(receiver)") &&
-      source.includes("bridge->rememberRoundTripValue(runtime, receiver,") &&
+      source.includes("bridge->rememberNativeObjectRoundTripValue(runtime, receiver,") &&
       source.includes("return preserved;"),
     `${relativePath}: initializer dispatch should preserve the original JS receiver when native init returns self`,
   );
@@ -64,6 +64,20 @@ for (const relativePath of [
   );
 }
 
+for (const relativePath of [
+  "NativeScript/ffi/shared/bridge/ObjCBridge.mm",
+  "packages/react-native/native-api/ffi/shared/bridge/ObjCBridge.mm",
+]) {
+  const source = fs.readFileSync(path.join(repoRoot, relativePath), "utf8");
+
+  assert(
+    source.includes("void rememberNativeObjectRoundTripValue(Runtime& runtime, id object,") &&
+      source.includes("rememberRoundTripValue(runtime, object, value, stringLikeNative,") &&
+      source.includes("nativeObjectClassKey(object));"),
+    `${relativePath}: preserved native object wrappers should use the same validation key as native return marshalling`,
+  );
+}
+
 for (const relativePath of [
   "NativeScript/ffi/jsc/NativeApiJSCSelectorGroups.mm",
   "NativeScript/ffi/v8/NativeApiV8SelectorGroups.mm",