fix(ffi): re-adopt init result on host object for JS override return-this

When a JS override calls super.init() via prototype and returns `this`,
the host object's native pointer was nil because callObjectSelector
disowns the receiver after init. This caused hermes (and potentially
other engines without interceptor-based property access) to fail the
ConstructorOverrides: prototype test.

Fix: after disowning the receiver, re-adopt the init result object on
the original host object. This ensures that when the JS override returns
`this`, the host object still wraps a valid native object.

Tests: all engines 713/0 (hermes was 712/1, now fixed)

Author: DjDeveloperr

NativeScript/ffi/shared/bridge/HostObjects.mm

@@ -681,16 +681,23 @@ throw JSError(runtime,
     if (initializer) {
       id resultObject = nativeObjectFromValue(runtime, result);
       disownObject(receiver);
-      if (resultObject != nil && classWrapper) {
-        bridge_->setObjectExpando(runtime, resultObject,
-                                  "__nativeApiClassWrapper",
-                                  Value(runtime, *classWrapper));
-        if (result.isObject()) {
-          Value prototypeValue = classWrapper->getProperty(runtime, "prototype");
-          if (prototypeValue.isObject()) {
-            Object resultValue = result.asObject(runtime);
-            Object prototype = prototypeValue.asObject(runtime);
-            SetNativeApiObjectPrototype(runtime, resultValue, prototype);
+      if (resultObject != nil) {
+        // Re-adopt the init result on this host object so that JS overrides
+        // returning `this` still have a valid native object.
+        object_ = resultObject;
+        ownsObject_ = true;
+        [object_ retain];
+        if (classWrapper) {
+          bridge_->setObjectExpando(runtime, resultObject,
+                                    "__nativeApiClassWrapper",
+                                    Value(runtime, *classWrapper));
+          if (result.isObject()) {
+            Value prototypeValue = classWrapper->getProperty(runtime, "prototype");
+            if (prototypeValue.isObject()) {
+              Object resultValue = result.asObject(runtime);
+              Object prototype = prototypeValue.asObject(runtime);
+              SetNativeApiObjectPrototype(runtime, resultValue, prototype);
+            }
           }
         }
       }
@@ -726,16 +733,23 @@ throw JSError(runtime,
     if (initializer) {
       id resultObject = nativeObjectFromValue(runtime, result);
       disownObject(receiver);
-      if (resultObject != nil && classWrapper) {
-        bridge_->setObjectExpando(runtime, resultObject,
-                                  "__nativeApiClassWrapper",
-                                  Value(runtime, *classWrapper));
-        if (result.isObject()) {
-          Value prototypeValue = classWrapper->getProperty(runtime, "prototype");
-          if (prototypeValue.isObject()) {
-            Object resultValue = result.asObject(runtime);
-            Object prototype = prototypeValue.asObject(runtime);
-            SetNativeApiObjectPrototype(runtime, resultValue, prototype);
+      if (resultObject != nil) {
+        // Re-adopt the init result on this host object so that JS overrides
+        // returning `this` still have a valid native object.
+        object_ = resultObject;
+        ownsObject_ = true;
+        [object_ retain];
+        if (classWrapper) {
+          bridge_->setObjectExpando(runtime, resultObject,
+                                    "__nativeApiClassWrapper",
+                                    Value(runtime, *classWrapper));
+          if (result.isObject()) {
+            Value prototypeValue = classWrapper->getProperty(runtime, "prototype");
+            if (prototypeValue.isObject()) {
+              Object resultValue = result.asObject(runtime);
+              Object prototype = prototypeValue.asObject(runtime);
+              SetNativeApiObjectPrototype(runtime, resultValue, prototype);
+            }
           }
         }
       }