fix: tag static UIAppearance selector results

DjDeveloperr · DjDeveloperr · commit 45c6df658dc4 · 2026-06-29T08:31:27.000-04:00
diff --git a/HANDOFF.md b/HANDOFF.md
@@ -111,6 +111,33 @@ During this thread `agent-device` was version `0.18.0`; the npm package is
 
 ## Current Verified State
 
+Update from 2026-06-29 08:28 EDT:
+
+- Simulator-only rule remains active. Do not use physical iPhone/iPad devices.
+- GitHub Actions run `28369500611` on `3ad3920a` kept macOS green and failed
+  iOS only in `ApiTests.js Appearance`:
+  `UILabel.appearance().textColor` still read back `undefined`.
+- Follow-up runtime fix in progress:
+  - Static `appearance*` selector results are now tagged at the prepared
+    selector / selector-group return path, not only at the class-host
+    `appearance` wrapper.
+  - V8/JSC/QuickJS/Hermes generated-dispatch fast paths now route static
+    `appearance*` returns through tag-aware paths, so UIAppearance setter
+    caches can key values by the target native class.
+- Local verification after this patch:
+  - `npm run build:macos-cli` passed and compiled the edited V8 bridge.
+  - Runtime RN JS tests passed:
+    `for f in packages/react-native/test/*.test.js; do node "$f" || exit 1; done`.
+  - `npm run check:ffi-boundaries` passed.
+  - `git diff --check` passed.
+  - `npm run build:ios-sim` and a JSC macOS CLI compile attempt were blocked
+    before runtime compilation by the known local metadata-generator
+    `libclang.dylib` x86_64/arm64 mismatch.
+- Not done:
+  - Commit/push this static UIAppearance selector-tag fix and watch fresh PR
+    CI.
+  - If CI turns green, resume the dedicated simulator-only RNS parity sweep.
+
 Update from 2026-06-29 04:45 EDT:
 
 - Simulator-only rule was reaffirmed. Do not use physical iPhone/iPad devices
diff --git a/NativeScript/ffi/hermes/NativeApiJsi.mm b/NativeScript/ffi/hermes/NativeApiJsi.mm
@@ -260,7 +260,8 @@ throw JSError(runtime,
         // disown handling, or implicit NSError-out argument).
         if (prepared->gsdEngineCallable && gsdDispatchClass == Nil &&
             count == prepared->gsdEngineArgumentCount &&
-            !(!receiverIsClass && prepared->isInitMethod)) {
+            !(!receiverIsClass && prepared->isInitMethod) &&
+            !isPreparedStaticAppearanceSelector(*prepared)) {
           auto invoker =
               reinterpret_cast<ObjCGsdInvoker>(prepared->engineInvoker);
           GsdObjCContext ctx{runtime, bridge, receiver, prepared->selector,
diff --git a/NativeScript/ffi/jsc/NativeApiJSCSelectorGroups.mm b/NativeScript/ffi/jsc/NativeApiJSCSelectorGroups.mm
@@ -106,7 +106,8 @@ throw JSError(
   // return value — bypassing all generic marshalling.
   if (prepared.gsdEngineCallable && dispatchSuperClass == Nil &&
       providedCount == prepared.gsdEngineArgumentCount &&
-      !initializerClassWrapper && !isNSErrorOutMethod) {
+      !initializerClassWrapper && !isNSErrorOutMethod &&
+      !isPreparedStaticAppearanceSelector(prepared)) {
     auto invoker = reinterpret_cast<ObjCGsdInvoker>(prepared.engineInvoker);
     GsdObjCContext ctx{runtime,  bridge,    receiver, prepared.selector,
                        runtime.context(), arguments, signature.returnType};
@@ -125,6 +126,8 @@ throw JSError(
     if (tryCallFastEngineObjCSelector(runtime, bridge, receiver, prepared,
                                       fastArgs, providedCount, Nil,
                                       &fastResult)) {
+      fastResult = tagPreparedStaticAppearanceSelectorResult(
+          runtime, bridge, receiver, prepared, std::move(fastResult));
       return fastResult.local(runtime);
     }
   }
@@ -209,6 +212,8 @@ throw JSError(
                                Value(runtime, *initializerClassWrapper));
     }
   }
+  tagPreparedStaticAppearanceNativeReturn(
+      runtime, bridge, receiver, prepared, returnType, returnStorage.data());
   return setJSCEngineReturnValue(runtime, bridge, returnType,
                                  returnStorage.data(), prepared.selectorName);
 }
diff --git a/NativeScript/ffi/quickjs/NativeApiQuickJSSelectorGroups.mm b/NativeScript/ffi/quickjs/NativeApiQuickJSSelectorGroups.mm
@@ -105,7 +105,8 @@ throw JSError(
   // return value — bypassing all generic marshalling.
   if (prepared.gsdEngineCallable && dispatchSuperClass == Nil &&
       providedCount == prepared.gsdEngineArgumentCount &&
-      !initializerClassWrapper && !isNSErrorOutMethod) {
+      !initializerClassWrapper && !isNSErrorOutMethod &&
+      !isPreparedStaticAppearanceSelector(prepared)) {
     auto invoker = reinterpret_cast<ObjCGsdInvoker>(prepared.engineInvoker);
     GsdObjCContext ctx{runtime,           bridge,    receiver, prepared.selector,
                        runtime.context(), arguments, signature.returnType};
@@ -124,6 +125,8 @@ throw JSError(
     if (tryCallFastEngineObjCSelector(runtime, bridge, receiver, prepared,
                                       fastArgs, providedCount, Nil,
                                       &fastResult)) {
+      fastResult = tagPreparedStaticAppearanceSelectorResult(
+          runtime, bridge, receiver, prepared, std::move(fastResult));
       return fastResult.local(runtime);
     }
   }
@@ -209,6 +212,8 @@ throw JSError(
                                Value(runtime, *initializerClassWrapper));
     }
   }
+  tagPreparedStaticAppearanceNativeReturn(
+      runtime, bridge, receiver, prepared, returnType, returnStorage.data());
   return setQuickJSEngineReturnValue(runtime, bridge, returnType,
                                      returnStorage.data(),
                                      prepared.selectorName);
diff --git a/NativeScript/ffi/shared/bridge/HostObjects.mm b/NativeScript/ffi/shared/bridge/HostObjects.mm
@@ -1847,6 +1847,43 @@ throw JSError(
   std::shared_ptr<NativeApiObjectLifetimeState> lifetimeState_;
 };
 
+bool isStaticAppearanceSelector(bool receiverIsClass,
+                                const std::string& selectorName) {
+  return receiverIsClass && selectorName.rfind("appearance", 0) == 0;
+}
+
+void tagStaticAppearanceNativeResult(
+    Runtime& runtime, const std::shared_ptr<NativeApiBridge>& bridge,
+    Class appearanceClass, id native) {
+  if (bridge == nullptr || appearanceClass == Nil || native == nil) {
+    return;
+  }
+  const char* className = class_getName(appearanceClass);
+  if (className == nullptr || className[0] == '\0') {
+    return;
+  }
+  bridge->setObjectExpando(runtime, native, kNativeApiAppearanceClassNameExpando,
+                           makeString(runtime, className));
+}
+
+Value tagStaticAppearanceSelectorResult(
+    Runtime& runtime, const std::shared_ptr<NativeApiBridge>& bridge,
+    id receiver, bool receiverIsClass, const std::string& selectorName,
+    Value result) {
+  if (!isStaticAppearanceSelector(receiverIsClass, selectorName) ||
+      !result.isObject()) {
+    return result;
+  }
+  Object resultObject = result.asObject(runtime);
+  if (!resultObject.isHostObject<NativeApiObjectHostObject>(runtime)) {
+    return result;
+  }
+  tagStaticAppearanceNativeResult(
+      runtime, bridge, static_cast<Class>(receiver),
+      resultObject.getHostObject<NativeApiObjectHostObject>(runtime)->object());
+  return result;
+}
+
 class NativeApiClassHostObject final : public HostObject {
  public:
   NativeApiClassHostObject(std::shared_ptr<NativeApiBridge> bridge,
diff --git a/NativeScript/ffi/shared/bridge/Invocation.mm b/NativeScript/ffi/shared/bridge/Invocation.mm
@@ -1487,6 +1487,34 @@ throw JSError(
   return prepared;
 }
 
+bool isPreparedStaticAppearanceSelector(
+    const NativeApiPreparedObjCInvocation& prepared) {
+  return prepared.receiverClass != Nil &&
+         prepared.selectorName.rfind("appearance", 0) == 0;
+}
+
+Value tagPreparedStaticAppearanceSelectorResult(
+    Runtime& runtime, const std::shared_ptr<NativeApiBridge>& bridge,
+    id receiver, const NativeApiPreparedObjCInvocation& prepared,
+    Value result) {
+  return tagStaticAppearanceSelectorResult(
+      runtime, bridge, receiver, isPreparedStaticAppearanceSelector(prepared),
+      prepared.selectorName, std::move(result));
+}
+
+void tagPreparedStaticAppearanceNativeReturn(
+    Runtime& runtime, const std::shared_ptr<NativeApiBridge>& bridge,
+    id receiver, const NativeApiPreparedObjCInvocation& prepared,
+    const NativeApiType& returnType, void* returnData) {
+  if (!isPreparedStaticAppearanceSelector(prepared) ||
+      !isObjectiveCObjectType(returnType) || returnData == nullptr) {
+    return;
+  }
+  tagStaticAppearanceNativeResult(
+      runtime, bridge, static_cast<Class>(receiver),
+      *static_cast<id*>(returnData));
+}
+
 Value callPreparedObjCSelector(
     Runtime& runtime, const std::shared_ptr<NativeApiBridge>& bridge,
     id receiver, bool receiverIsClass,
@@ -1503,11 +1531,13 @@ throw JSError(runtime,
   if (tryCallGeneratedEngineObjCSelector(runtime, bridge, receiver, prepared,
                                          args, count, dispatchSuperClass,
                                          &fastResult)) {
-    return fastResult;
+    return tagPreparedStaticAppearanceSelectorResult(
+        runtime, bridge, receiver, prepared, std::move(fastResult));
   }
   if (tryCallFastEngineObjCSelector(runtime, bridge, receiver, prepared, args,
                                     count, dispatchSuperClass, &fastResult)) {
-    return fastResult;
+    return tagPreparedStaticAppearanceSelectorResult(
+        runtime, bridge, receiver, prepared, std::move(fastResult));
   }
 
   NativeApiArgumentFrame frame(signature.argumentTypes.size());
@@ -1594,8 +1624,10 @@ NativeApiReturnStorage returnStorage(
     throw JSError(
         runtime, errorMessage != nullptr ? errorMessage : "Unknown NSError");
   }
-  return convertNativeReturnValue(runtime, bridge, returnType,
-                                  returnStorage.data());
+  Value result = convertNativeReturnValue(runtime, bridge, returnType,
+                                          returnStorage.data());
+  return tagPreparedStaticAppearanceSelectorResult(
+      runtime, bridge, receiver, prepared, std::move(result));
 }
 
 Value callObjCSelector(Runtime& runtime,
@@ -1666,12 +1698,16 @@ throw JSError(
   if (tryCallGeneratedEngineObjCSelector(runtime, bridge, receiver,
                                          engineInvocation, args, count,
                                          dispatchSuperClass, &fastResult)) {
-    return fastResult;
+    return tagStaticAppearanceSelectorResult(
+        runtime, bridge, receiver, receiverIsClass, selectorName,
+        std::move(fastResult));
   }
   if (tryCallFastEngineObjCSelector(runtime, bridge, receiver,
                                     engineInvocation, args, count,
                                     dispatchSuperClass, &fastResult)) {
-    return fastResult;
+    return tagStaticAppearanceSelectorResult(
+        runtime, bridge, receiver, receiverIsClass, selectorName,
+        std::move(fastResult));
   }
 
   NativeApiArgumentFrame frame(signature->argumentTypes.size());
@@ -1759,6 +1795,9 @@ NativeApiReturnStorage returnStorage(
     throw JSError(
         runtime, errorMessage != nullptr ? errorMessage : "Unknown NSError");
   }
-  return convertNativeReturnValue(runtime, bridge, returnType,
-                                  returnStorage.data());
+  Value result = convertNativeReturnValue(runtime, bridge, returnType,
+                                          returnStorage.data());
+  return tagStaticAppearanceSelectorResult(
+      runtime, bridge, receiver, receiverIsClass, selectorName,
+      std::move(result));
 }
diff --git a/NativeScript/ffi/v8/NativeApiV8SelectorGroups.mm b/NativeScript/ffi/v8/NativeApiV8SelectorGroups.mm
@@ -94,7 +94,8 @@ throw JSError(
   // generic marshalling.
   if (prepared.gsdEngineCallable && dispatchSuperClass == Nil &&
       providedCount == prepared.gsdEngineArgumentCount &&
-      !initializerClassWrapper && !isNSErrorOutMethod) {
+      !initializerClassWrapper && !isNSErrorOutMethod &&
+      !isPreparedStaticAppearanceSelector(prepared)) {
     auto invoker = reinterpret_cast<ObjCGsdInvoker>(prepared.engineInvoker);
     GsdObjCContext ctx{runtime,
                        bridge,
@@ -119,6 +120,8 @@ throw JSError(
     if (tryCallFastEngineObjCSelector(runtime, bridge, receiver, prepared,
                                       fastArgs, providedCount, Nil,
                                       &fastResult)) {
+      fastResult = tagPreparedStaticAppearanceSelectorResult(
+          runtime, bridge, receiver, prepared, std::move(fastResult));
       info.GetReturnValue().Set(fastResult.local(runtime));
       return;
     }
@@ -204,6 +207,8 @@ throw JSError(
                                Value(runtime, *initializerClassWrapper));
     }
   }
+  tagPreparedStaticAppearanceNativeReturn(
+      runtime, bridge, receiver, prepared, returnType, returnStorage.data());
   setV8EngineReturnValue(runtime, bridge, returnType, returnStorage.data(),
                          prepared.selectorName, info);
 }
@@ -372,7 +377,8 @@ throw JSError(runtime,
     // generated invoker reads args, calls objc_msgSend, and sets the return.
     if (prepared->gsdEngineCallable && dispatchClass == Nil &&
         !prepared->isInitMethod &&
-        count == prepared->gsdEngineArgumentCount) {
+        count == prepared->gsdEngineArgumentCount &&
+        !isPreparedStaticAppearanceSelector(*prepared)) {
       auto invoker = reinterpret_cast<ObjCGsdInvoker>(prepared->engineInvoker);
       GsdObjCContext ctx{runtime,
                          data->bridge,
diff --git a/PROGRESS.md b/PROGRESS.md
@@ -17,6 +17,37 @@ TypeScript/UI worklets.
 
 ## Latest Update - 2026-06-29
 
+### 2026-06-29 08:28 EDT - patched static UIAppearance selector result tagging
+
+- Goal:
+  - Keep PR #46 on the RN-module runtime primitive path and unblock the final
+    simulator-only RNS parity sweep; no physical devices were used.
+- CI finding:
+  - GitHub Actions run `28369500611` kept macOS green but still failed iOS
+    `ApiTests.js Appearance` only:
+    `UILabel.appearance().textColor` read back as `undefined`.
+  - The custom JS selector regression stayed fixed, confirming broad
+    get-time Objective-C probing should remain out of the object hot path.
+- Changes:
+  - Static `appearance*` selector results are now tagged at the prepared
+    selector / selector-group return path, including V8/JSC/QuickJS/Hermes
+    generated-dispatch fast paths.
+  - UIAppearance setter caches can therefore key values by the target class
+    even when `UILabel.appearance()` is served by the generated selector-group
+    path instead of the class-host `appearance` wrapper.
+- Verification:
+  - Runtime RN JS tests passed:
+    `for f in packages/react-native/test/*.test.js; do node "$f" || exit 1; done`.
+  - `npm run check:ffi-boundaries` passed.
+  - `git diff --check` passed.
+  - `npm run build:macos-cli` passed, proving the edited V8 bridge compiles.
+  - `npm run build:ios-sim` and a JSC macOS CLI compile attempt both stopped
+    before runtime compilation on the known local metadata-generator
+    `libclang.dylib` x86_64/arm64 mismatch.
+- Still next:
+  - Commit/push the selector tag fix, watch fresh PR CI, then return to the
+    dedicated simulator-only RNS parity sweep if CI is green.
+
 ### 2026-06-29 04:45 EDT - fixed macOS CI dynamic class identity blocker
 
 - Goal:

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,8 @@ throw JSError(`
`106`	`106`	`// return value — bypassing all generic marshalling.`
`107`	`107`	`if (prepared.gsdEngineCallable && dispatchSuperClass == Nil &&`
`108`	`108`	`providedCount == prepared.gsdEngineArgumentCount &&`
`109`		`- !initializerClassWrapper && !isNSErrorOutMethod) {`
	`109`	`+ !initializerClassWrapper && !isNSErrorOutMethod &&`
	`110`	`+ !isPreparedStaticAppearanceSelector(prepared)) {`
`110`	`111`	`auto invoker = reinterpret_cast<ObjCGsdInvoker>(prepared.engineInvoker);`
`111`	`112`	`GsdObjCContext ctx{runtime, bridge, receiver, prepared.selector,`
`112`	`113`	`runtime.context(), arguments, signature.returnType};`
`@@ -125,6 +126,8 @@ throw JSError(`
`125`	`126`	`if (tryCallFastEngineObjCSelector(runtime, bridge, receiver, prepared,`
`126`	`127`	`fastArgs, providedCount, Nil,`
`127`	`128`	`&fastResult)) {`
	`129`	`+ fastResult = tagPreparedStaticAppearanceSelectorResult(`
	`130`	`+ runtime, bridge, receiver, prepared, std::move(fastResult));`
`128`	`131`	`return fastResult.local(runtime);`
`129`	`132`	`}`
`130`	`133`	`}`
`@@ -209,6 +212,8 @@ throw JSError(`
`209`	`212`	`Value(runtime, *initializerClassWrapper));`
`210`	`213`	`}`
`211`	`214`	`}`
	`215`	`+ tagPreparedStaticAppearanceNativeReturn(`
	`216`	`+ runtime, bridge, receiver, prepared, returnType, returnStorage.data());`
`212`	`217`	`return setJSCEngineReturnValue(runtime, bridge, returnType,`
`213`	`218`	`returnStorage.data(), prepared.selectorName);`
`214`	`219`	`}`