refactor(ffi): split direct engine backends

Author: DjDeveloperr

NativeScript/CMakeLists.txt

@@ -239,20 +239,37 @@ set(FFI_NAPI_SOURCE_FILES
   ffi/napi/ClassBuilder.mm
 )
 
+set(FFI_DIRECT_SHARED_SOURCE_FILES
+  ffi/shared/direct/EmbeddedMetadata.mm
+)
+
 set(FFI_HERMES_DIRECT_SOURCE_FILES
+  ${FFI_DIRECT_SHARED_SOURCE_FILES}
   ffi/hermes/jsi/NativeApiJsi.mm
 )
 
 set(FFI_V8_DIRECT_SOURCE_FILES
+  ${FFI_DIRECT_SHARED_SOURCE_FILES}
   ffi/v8/NativeApiV8.mm
+  ffi/v8/NativeApiV8HostObjects.mm
+  ffi/v8/NativeApiV8Runtime.mm
+  ffi/v8/NativeApiV8Value.mm
 )
 
 set(FFI_JSC_DIRECT_SOURCE_FILES
+  ${FFI_DIRECT_SHARED_SOURCE_FILES}
   ffi/jsc/NativeApiJSC.mm
+  ffi/jsc/NativeApiJSCHostObjects.mm
+  ffi/jsc/NativeApiJSCRuntime.mm
+  ffi/jsc/NativeApiJSCValue.mm
 )
 
 set(FFI_QUICKJS_DIRECT_SOURCE_FILES
+  ${FFI_DIRECT_SHARED_SOURCE_FILES}
+  ffi/quickjs/NativeApiQuickJSHostObjects.mm
   ffi/quickjs/NativeApiQuickJS.mm
+  ffi/quickjs/NativeApiQuickJSRuntime.mm
+  ffi/quickjs/NativeApiQuickJSValue.mm
 )
 
 set(SOURCE_FILES

NativeScript/ffi/hermes/jsi/NativeApiJsi.mm

@@ -14,8 +14,8 @@
 #include <atomic>
 #include <cctype>
 #include <cmath>
-#include <cstdio>
 #include <cstdint>
+#include <cstdio>
 #include <cstdlib>
 #include <cstring>
 #include <limits>
@@ -29,9 +29,9 @@
 #include <unordered_set>
 #include <vector>
 
-#include "ffi.h"
 #include "Metadata.h"
 #include "MetadataReader.h"
+#include "ffi.h"
 
 @protocol NativeApiJsiClassBuilderProtocol
 @end
@@ -60,22 +60,24 @@ @protocol NativeApiJsiClassBuilderProtocol
 using metagen::MDSectionOffset;
 using metagen::MDTypeKind;
 
-#include "NativeApiJsiBridge.inc"
-#include "NativeApiJsiHostObjects.inc"
-#include "NativeApiJsiCallbacks.inc"
-#include "NativeApiJsiConversion.inc"
-#include "NativeApiJsiInvocation.inc"
-#include "NativeApiJsiClassBuilder.inc"
-#include "NativeApiJsiHostObject.inc"
+// clang-format off
+#include "jsi/NativeApiJsiBridge.h"
+#include "jsi/NativeApiJsiHostObjects.h"
+#include "jsi/NativeApiJsiCallbacks.h"
+#include "jsi/NativeApiJsiConversion.h"
+#include "jsi/NativeApiJsiInvocation.h"
+#include "jsi/NativeApiJsiClassBuilder.h"
+#include "jsi/NativeApiJsiHostObject.h"
+// clang-format on
 
 }  // namespace
 
-#include "NativeApiJsiInstall.inc"
+#include "jsi/NativeApiJsiInstall.h"
 
 }  // namespace nativescript
 
-extern "C" void NativeScriptInstallNativeApiJSI(
-    facebook::jsi::Runtime* runtime, const char* metadataPath) {
+extern "C" void NativeScriptInstallNativeApiJSI(facebook::jsi::Runtime* runtime,
+                                                const char* metadataPath) {
   if (runtime == nullptr) {
     return;
   }
@@ -84,5 +86,4 @@ @protocol NativeApiJsiClassBuilderProtocol
   nativescript::InstallNativeApiJSI(*runtime, config);
 }
 
-
 #endif  // TARGET_ENGINE_HERMES

NativeScript/ffi/hermes/jsi/README.md

@@ -5,18 +5,18 @@ API access.
 
 The backend is split by FFI responsibility:
 
-- `NativeApiJsiBridge.inc` owns metadata indexing, symbol lookup, scheduler
+- `../../shared/jsi/NativeApiJsiBridge.h` owns metadata indexing, symbol lookup, scheduler
   state, and bridge lifetime caches.
-- `NativeApiJsiHostObjects.inc` owns class, object, protocol, pointer,
+- `../../shared/jsi/NativeApiJsiHostObjects.h` owns class, object, protocol, pointer,
   reference, struct, and union host objects.
-- `NativeApiJsiCallbacks.inc` owns signatures, libffi callback trampolines,
+- `../../shared/jsi/NativeApiJsiCallbacks.h` owns signatures, libffi callback trampolines,
   JS blocks, and native function pointer callback lifetime.
-- `NativeApiJsiConversion.inc` owns JSI/native type conversion and the
+- `../../shared/jsi/NativeApiJsiConversion.h` owns JSI/native type conversion and the
   `interop` helper surface.
-- `NativeApiJsiInvocation.inc` owns constants, enums, C function calls,
+- `../../shared/jsi/NativeApiJsiInvocation.h` owns constants, enums, C function calls,
   function pointer calls, and Objective-C selector dispatch.
-- `NativeApiJsiHostObject.inc` owns the public API host object exposed to JS.
-- `NativeApiJsiInstall.inc` owns runtime/global installation.
+- `../../shared/jsi/NativeApiJsiHostObject.h` owns the public API host object exposed to JS.
+- `../../shared/jsi/NativeApiJsiInstall.h` owns runtime/global installation.
 
 The core installer is engine-host agnostic: