ci: unit test failure handling

[skip ci]

Author: NathanWalker

TestRunnerTests/Embassy/TCPSocket.swift

@@ -25,17 +25,27 @@ public final class TCPSocket {
     }
 
     /// Whether to ignore SIGPIPE signal or not
+    ///
+    /// NOTE (NativeScript test harness): the get/set deliberately do NOT
+    /// `assert()` on getsockopt/setsockopt failure. This server runs inside the
+    /// XCUITest runner, where any trap aborts the entire run ("Executed 0
+    /// tests"). Some accepted client sockets are already half-closed by the time
+    /// we configure them — notably the runtime's synchronous HTTP module loader
+    /// (NSURLConnection), whose sockets fail getpeername()/setsockopt() with
+    /// EINVAL/ENOTCONN. Treat SO_NOSIGPIPE as best-effort: a later send() on a
+    /// dead socket simply throws and is handled by Transport, instead of the
+    /// whole runner crashing here (assertionFailure in this setter was the
+    /// observed CI failure once getPeerName() was made tolerant).
     var ignoreSigPipe: Bool {
         get {
             #if os(Linux)
                 return false
             #else
                 var value: Int32 = 0
                 var size = socklen_t(MemoryLayout<Int32>.size)
-                assert(
-                    getsockopt(fileDescriptor, SOL_SOCKET, SO_NOSIGPIPE, &value, &size) >= 0,
-                    "Failed to get SO_NOSIGPIPE, errno=\(errno), message=\(lastErrorDescription())"
-                )
+                guard getsockopt(fileDescriptor, SOL_SOCKET, SO_NOSIGPIPE, &value, &size) >= 0 else {
+                    return false
+                }
                 return value == 1
             #endif
         }
@@ -47,15 +57,12 @@ public final class TCPSocket {
                 return
             #else
                 var value: Int32 = newValue ? 1 : 0
-                assert(
-                    setsockopt(
-                        fileDescriptor,
-                        SOL_SOCKET,
-                        SO_NOSIGPIPE,
-                        &value,
-                        socklen_t(MemoryLayout<Int32>.size)
-                        ) >= 0,
-                    "Failed to set SO_NOSIGPIPE, errno=\(errno), message=\(lastErrorDescription())"
+                _ = setsockopt(
+                    fileDescriptor,
+                    SOL_SOCKET,
+                    SO_NOSIGPIPE,
+                    &value,
+                    socklen_t(MemoryLayout<Int32>.size)
                 )
             #endif
         }

TestRunnerTests/Embassy/Transport.swift

@@ -134,9 +134,17 @@ public final class Transport {
                 // (usually means that this function was called by resumeReading)
                 return
             }
-            fatalError("Failed to read, errno=\(errno), message=\(lastErrorDescription())")
+            // NativeScript test harness: do NOT fatalError. This server runs in
+            // the XCUITest runner, where a trap aborts the whole run ("Executed
+            // 0 tests"). A half-closed client socket (e.g. the runtime's
+            // NSURLConnection module loader) makes recv() fail with
+            // ECONNRESET/ENOTCONN/EINVAL — tear the connection down like a peer
+            // close instead of crashing the runner.
+            closedByPeer()
+            return
         } catch {
-            fatalError("Failed to read")
+            closedByPeer()
+            return
         }
         guard data.count > 0 else {
             closedByPeer()
@@ -186,7 +194,7 @@ public final class Transport {
                     socket.close()
                 }
             }
-        } catch let OSError.ioError(number, message) {
+        } catch let OSError.ioError(number, _) {
             switch number {
             case EAGAIN:
                 break
@@ -200,10 +208,14 @@ public final class Transport {
                 closedByPeer()
 
             default:
-                fatalError("Failed to send, errno=\(number), message=\(message)")
+                // NativeScript test harness: do NOT fatalError (it would abort
+                // the XCUITest runner -> "Executed 0 tests"). Any other send()
+                // failure on a half-dead client socket just means the peer is
+                // gone; tear the connection down instead of crashing.
+                closedByPeer()
             }
         } catch {
-            fatalError("Failed to send")
+            closedByPeer()
         }
     }
 }

TestRunnerTests/QUARANTINED_TESTS.md

@@ -67,6 +67,16 @@ server can't serve these requests.
 filter once the server is fixed):
 - `DefaultHTTPServer.handleNewConnection` tolerates `getPeerName()` failure and
   serves the connection with a placeholder peer (instead of crashing/dropping).
+- `TCPSocket.ignoreSigPipe` get/set no longer `assert()` on
+  getsockopt/setsockopt failure — a half-dead loader socket made
+  `setsockopt(SO_NOSIGPIPE)` fail with EINVAL, and the assert trapped (live in
+  the Debug runner build) → `_assertionFailure` aborted the whole run
+  ("Executed 0 tests"). Now best-effort.
+- `Transport.handleRead`/`handleWrite` tear the connection down
+  (`closedByPeer()`) on any unexpected recv/send error instead of `fatalError`,
+  for the same reason: those sockets reach `Transport` once `getPeerName`/
+  `ignoreSigPipe` stopped trapping, and the next event-loop read/write on a
+  dead socket would otherwise crash the runner.
 - `/esm/timeout.mjs` responds via a non-blocking `loop.call(withDelay:)` instead
   of `Thread.sleep` (which wedged the single-threaded server).
 - The server also serves the `/ns/m/…` hot-data aliases and `/ns/core` bridge