add not-supported comments to dom/css agent commands that are not implemented

petekanev · petekanev · commit 0ac17fdd686c · 2017-06-07T10:56:48.000+03:00
diff --git a/runtime/src/main/jni/v8_inspector/src/inspector/v8-css-agent-impl.cpp b/runtime/src/main/jni/v8_inspector/src/inspector/v8-css-agent-impl.cpp
@@ -48,7 +48,7 @@ namespace v8_inspector {
         m_enabled = false;
     }
 
-    // TODO: Pete: implement
+    // Not supported
     void V8CSSAgentImpl::getMatchedStylesForNode(ErrorString *errorString, int in_nodeId,
                                                  Maybe<protocol::CSS::CSSStyle> *out_inlineStyle,
                                                  Maybe<protocol::CSS::CSSStyle> *out_attributesStyle,
@@ -115,7 +115,7 @@ namespace v8_inspector {
         *out_pseudoElements = Maybe<protocol::Array<protocol::CSS::PseudoElementMatches>>(std::move(pseudoElementsArr));
     }
 
-    // TODO: Pete: implement
+    // Not supported
     void V8CSSAgentImpl::getInlineStylesForNode(ErrorString *, int in_nodeId,
                                                 Maybe<protocol::CSS::CSSStyle> *out_inlineStyle,
                                                 Maybe<protocol::CSS::CSSStyle> *out_attributesStyle) {
@@ -208,7 +208,7 @@ namespace v8_inspector {
         *out_fonts = std::move(fontsArr);
     }
 
-    // TODO: Pete: implement
+    // Not supported
     void V8CSSAgentImpl::getStyleSheetText(ErrorString *, const String &in_styleSheetId,
                                            String *out_text) {
         *out_text = "";
diff --git a/runtime/src/main/jni/v8_inspector/src/inspector/v8-dom-agent-impl.cpp b/runtime/src/main/jni/v8_inspector/src/inspector/v8-dom-agent-impl.cpp
@@ -144,6 +144,7 @@ namespace v8_inspector {
     }
 
     // Pete: return empty resolved object - prevents crashes when opening the 'properties', 'event listeners' tabs
+    // Not supported
     void V8DOMAgentImpl::resolveNode(ErrorString*, int in_nodeId, const Maybe<String>& in_objectGroup, std::unique_ptr<protocol::Runtime::RemoteObject>* out_object) {
         auto resolvedNode = protocol::Runtime::RemoteObject::create()
                 .setType("View")
@@ -191,22 +192,26 @@ namespace v8_inspector {
         // Irrelevant
     }
 
+    // Not supported
     void V8DOMAgentImpl::performSearch(ErrorString *, const String &in_query,
                                        const Maybe<protocol::Array<int>> &in_nodeIds,
                                        String *out_searchId, int *out_resultCount) {
 
     }
 
+    // Not supported
     void V8DOMAgentImpl::getSearchResults(ErrorString *, const String &in_searchId, int in_fromIndex,
                                      int in_toIndex,
                                      std::unique_ptr<protocol::Array<int>> *out_nodeIds) {
 
     }
 
+    // Not supported
     void V8DOMAgentImpl::discardSearchResults(ErrorString *, const String &in_searchId) {
 
     }
 
+    // Not supported
     void V8DOMAgentImpl::highlightNode(ErrorString *,
                                        std::unique_ptr<protocol::DOM::HighlightConfig> in_highlightConfig,
                                        const Maybe<int> &in_nodeId,

Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,7 @@ namespace v8_inspector {`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`// Pete: return empty resolved object - prevents crashes when opening the 'properties', 'event listeners' tabs`
	`147`	`+ // Not supported`
`147`	`148`	`void V8DOMAgentImpl::resolveNode(ErrorString, int in_nodeId, const Maybe<String>& in_objectGroup, std::unique_ptr<protocol::Runtime::RemoteObject> out_object) {`
`148`	`149`	`auto resolvedNode = protocol::Runtime::RemoteObject::create()`
`149`	`150`	`.setType("View")`
`@@ -191,22 +192,26 @@ namespace v8_inspector {`
`191`	`192`	`// Irrelevant`
`192`	`193`	`}`
`193`	`194`
	`195`	`+ // Not supported`
`194`	`196`	`void V8DOMAgentImpl::performSearch(ErrorString *, const String &in_query,`
`195`	`197`	`const Maybe<protocol::Array<int>> &in_nodeIds,`
`196`	`198`	`String out_searchId, int out_resultCount) {`
`197`	`199`
`198`	`200`	`}`
`199`	`201`
	`202`	`+ // Not supported`
`200`	`203`	`void V8DOMAgentImpl::getSearchResults(ErrorString *, const String &in_searchId, int in_fromIndex,`
`201`	`204`	`int in_toIndex,`
`202`	`205`	`std::unique_ptr<protocol::Array<int>> *out_nodeIds) {`
`203`	`206`
`204`	`207`	`}`
`205`	`208`
	`209`	`+ // Not supported`
`206`	`210`	`void V8DOMAgentImpl::discardSearchResults(ErrorString *, const String &in_searchId) {`
`207`	`211`
`208`	`212`	`}`
`209`	`213`
	`214`	`+ // Not supported`
`210`	`215`	`void V8DOMAgentImpl::highlightNode(ErrorString *,`
`211`	`216`	`std::unique_ptr<protocol::DOM::HighlightConfig> in_highlightConfig,`
`212`	`217`	`const Maybe<int> &in_nodeId,`