fix(stream): keep visible clients foreground

Author: DjDeveloperr

client/src/features/stream/useLiveStream.ts

@@ -100,7 +100,7 @@ function currentClientBundle(): string {
 }
 
 function isDocumentForeground(): boolean {
-  return document.visibilityState === "visible" && document.hasFocus();
+  return document.visibilityState === "visible";
 }
 
 export function useLiveStream({
@@ -371,17 +371,13 @@ export function useLiveStream({
 
     sendCurrentForegroundState();
     document.addEventListener("visibilitychange", sendCurrentForegroundState);
-    window.addEventListener("focus", sendCurrentForegroundState);
-    window.addEventListener("blur", sendCurrentForegroundState);
     window.addEventListener("pageshow", sendCurrentForegroundState);
     window.addEventListener("pagehide", sendBackgroundState);
     return () => {
       document.removeEventListener(
         "visibilitychange",
         sendCurrentForegroundState,
       );
-      window.removeEventListener("focus", sendCurrentForegroundState);
-      window.removeEventListener("blur", sendCurrentForegroundState);
       window.removeEventListener("pageshow", sendCurrentForegroundState);
       window.removeEventListener("pagehide", sendBackgroundState);
     };

server/src/api/routes.rs

@@ -1408,9 +1408,7 @@ fn client_stats_foreground(stats: &ClientStreamStats) -> Option<bool> {
     if stats.kind != "page" {
         return None;
     }
-    let visible = stats.visibility_state.as_deref() == Some("visible");
-    let focused = stats.focused?;
-    Some(visible && focused)
+    Some(stats.visibility_state.as_deref()? == "visible")
 }
 
 async fn native_inspector_connect(
@@ -6141,7 +6139,7 @@ mod tests {
     }
 
     #[test]
-    fn client_stats_foreground_requires_visible_and_focused_page() {
+    fn client_stats_foreground_uses_page_visibility() {
         let page_stats =
             |visibility_state: Option<&str>, focused: Option<bool>| ClientStreamStats {
                 client_id: "client".to_owned(),
@@ -6157,14 +6155,18 @@ mod tests {
         );
         assert_eq!(
             client_stats_foreground(&page_stats(Some("visible"), Some(false))),
-            Some(false)
+            Some(true)
         );
         assert_eq!(
             client_stats_foreground(&page_stats(Some("hidden"), Some(true))),
             Some(false)
         );
         assert_eq!(
             client_stats_foreground(&page_stats(Some("visible"), None)),
+            Some(true)
+        );
+        assert_eq!(
+            client_stats_foreground(&page_stats(None, Some(true))),
             None
         );
         assert_eq!(