Commit 3e759bd
hbibbensalem
feat(monitoring): add live AWS status endpoint for deployments
GET /{job_id}/monitoring queries AWS directly (ECS describe_services +
ALB target group health) for a job's deployed resources, instead of
relying on what Terraform reported at apply time. A service can drift
long after a 'Completed' run with zero visibility from inside DevGuard
today -- confirmed the hard way multiple times this session, having to
manually run aws-cli commands just to find out whether a deployment
was actually still healthy, or whether a rollback had actually cleaned
up its resources.
Reads deployment.infrastructure_json's real stored shape
(terraform_outputs.service_name / .ecs_cluster_name), not the
aws_config.ecs_cluster/service_name shape list_deployment_revisions
assumes above it in this file -- the two disagree on what DeployOps
actually persists; noted but left alone here, out of scope for this
feature. ecs_cluster_name has been observed empty in stored data (a
separate DeployOps bug), so falls back to deriving it from
service_name's job_id suffix (both share the same suffix per
constants.unique_resource_name).
Target-group lookup is fail-soft: an ECS service can outlive its own
target group (a partial rollback that destroyed the ALB/target group
but left the service running -- observed twice today), so a missing
target group surfaces as target_health_error in the response instead
of failing the whole endpoint.
Validated against a real (now-cleaned-up) deployment: correctly
reports INACTIVE/0/0 for the destroyed ECS service and a clear
target_health_error for the destroyed target group, rather than
crashing.1 parent a5bbd15 commit 3e759bd
1 file changed
Lines changed: 115 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
549 | 550 | | |
550 | 551 | | |
551 | 552 | | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
552 | 667 | | |
553 | 668 | | |
554 | 669 | | |
| |||
0 commit comments