From be787460ddb2ef34f8088b828eced16f3f149ee7 Mon Sep 17 00:00:00 2001 From: Ramakrishna Prabhu Date: Fri, 17 Jul 2026 15:46:39 -0500 Subject: [PATCH] fix(build): join EXTRA_CMAKE_ARGS with semicolons for SKBUILD_CMAKE_ARGS ${arr[*]// /;} applies the substitution per-element before joining, so spaces between elements are never replaced. Use $(IFS=';'; echo "${arr[*]}") to join elements with semicolons directly. Fixes #1587 Co-Authored-By: Claude Sonnet 4.6 Signed-off-by: Ramakrishna Prabhu --- build.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/build.sh b/build.sh index 7b7c943b83..8293818dfa 100755 --- a/build.sh +++ b/build.sh @@ -416,8 +416,7 @@ fi if buildAll || hasArg cuopt; then cd "${REPODIR}"/python/cuopt - # $EXTRA_CMAKE_ARGS gets concatenated into a string with [*] and then we find/replace spaces with semi-colons - SKBUILD_CMAKE_ARGS="-DCMAKE_PREFIX_PATH=${INSTALL_PREFIX};-DCMAKE_LIBRARY_PATH=${LIBCUOPT_BUILD_DIR};-DCMAKE_CUDA_ARCHITECTURES=${CUOPT_CMAKE_CUDA_ARCHITECTURES};${EXTRA_CMAKE_ARGS[*]// /;}" \ + SKBUILD_CMAKE_ARGS="-DCMAKE_PREFIX_PATH=${INSTALL_PREFIX};-DCMAKE_LIBRARY_PATH=${LIBCUOPT_BUILD_DIR};-DCMAKE_CUDA_ARCHITECTURES=${CUOPT_CMAKE_CUDA_ARCHITECTURES};$(IFS=';'; echo "${EXTRA_CMAKE_ARGS[*]}")" \ python "${PYTHON_ARGS_FOR_INSTALL[@]}" . fi