Merge branch 'main' into chore/nvskills-ci-cuopt-routing-api-python

Author: ramakrishnap-nv

ci/check_symbols.sh

@@ -0,0 +1,107 @@
+#!/bin/bash
+# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: Apache-2.0
+
+set -eEuo pipefail
+
+echo "checking for symbol visibility issues"
+
+LIBRARY="${1}"
+
+echo ""
+echo "Checking exported symbols in '${LIBRARY}'"
+symbol_file="$(mktemp)"
+match_file="$(mktemp)"
+trap 'rm -f "${symbol_file}" "${match_file}"' EXIT
+
+# Ignore WEAK and UNIQUE symbols since UNIQUE symbols should be exported and
+# WEAK symbols may come from template instantiations.
+# Ignore symbols containing "_error" since these are likely exception types
+# and should be exported.
+
+readelf --dyn-syms --wide "${LIBRARY}" \
+    | awk '$7 != "UND" && $5 != "WEAK" && $5 != "UNIQUE"' \
+    | c++filt --no-params \
+    | awk '$0 !~ /_error/' \
+    > "${symbol_file}"
+
+patterns=(
+    'cub::'
+    'thrust::'
+    'raft::'
+    'rmm::'
+    'cuopt::mathematical_optimization::detail'
+    'cuopt::routing::detail'
+    'cuopt::detail'
+    'grpc::'
+    'google::protobuf'
+    'tbb::'
+    'absl::'
+    'dejavu::'
+    'papilo::'
+    'boost::'
+)
+
+failed=0
+
+for pattern in "${patterns[@]}"; do
+    echo "Checking for '${pattern}' symbols..."
+
+    awk -v pattern="${pattern}" '
+        BEGIN { has_trailing_scope = (substr(pattern, length(pattern) - 1) == "::") }
+        $1 ~ /^[0-9]+:/ {
+            symbol = ""
+            for (i = 8; i <= NF; ++i) {
+                symbol = symbol (i == 8 ? "" : " ") $i
+            }
+
+            sub(/<.*/, "", symbol)
+            sub(/^.*[[:space:]](for|to)[[:space:]]+/, "", symbol)
+
+            if (has_trailing_scope) {
+                matched = (index(symbol, pattern) == 1)
+            } else {
+                matched = (symbol == pattern || index(symbol, pattern "::") == 1)
+            }
+
+            if (matched) { print }
+        }
+    ' "${symbol_file}" > "${match_file}"
+
+    matches=$(awk 'END { print NR }' "${match_file}")
+    if [[ "${matches}" -ne 0 ]]; then
+        sed -n '1,20p' "${match_file}"
+        echo "ERROR: Found exported symbols in ${LIBRARY} matching the pattern ${pattern}."
+        echo "ERROR: Total matching symbols: ${matches}"
+        failed=1
+    fi
+done
+
+# Required public API symbols that must stay exported. This is a small stability
+# anchor (core C API lifecycle entrypoints), not an exhaustive list: without it,
+# a library whose visibility was over-tightened so the public API is entirely
+# hidden would still pass the forbidden-symbol checks above while being unusable.
+# Keep this set minimal and limited to entrypoints guaranteed to exist.
+required_symbols=(
+    cuOptReadProblem
+    cuOptCreateProblem
+    cuOptSolve
+    cuOptDestroyProblem
+)
+
+exported_funcs="$(readelf --dyn-syms --wide "${LIBRARY}" | awk '$7 != "UND" && $4 == "FUNC" { print $8 }')"
+
+for sym in "${required_symbols[@]}"; do
+    echo "Checking that required symbol '${sym}' is exported..."
+    if ! grep -qxF "${sym}" <<< "${exported_funcs}"; then
+        echo "ERROR: Required public API symbol '${sym}' is not exported from ${LIBRARY}."
+        echo "ERROR: Symbol visibility may be over-restricted and hiding the public API."
+        failed=1
+    fi
+done
+
+if [[ "${failed}" -ne 0 ]]; then
+    exit 1
+fi
+
+echo "No symbol visibility issues found in ${LIBRARY}"

conda/recipes/libcuopt/recipe.yaml

@@ -108,6 +108,7 @@ outputs:
       script:
         content: |
           cmake --install cpp/build
+          ./ci/check_symbols.sh cpp/build/libcuopt.so
       dynamic_linking:
         overlinking_behavior: "error"
       prefix_detection:
@@ -119,6 +120,7 @@ outputs:
       build:
         - cmake ${{ cmake_version }}
         - ${{ stdlib("c") }}
+        - binutils
       host:
         - libboost-devel
         - cuda-version =${{ cuda_version }}

cpp/CMakeLists.txt

@@ -548,6 +548,8 @@ if (NOT SKIP_GRPC_BUILD)
     # at runtime with "undefined symbol: absl::…::Mutex::Dtor".
     set_property(SOURCE ${GRPC_INFRA_FILES} DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
             APPEND PROPERTY COMPILE_OPTIONS "-DNDEBUG")
+    set_property(SOURCE ${PROTO_SRCS} ${GRPC_PROTO_SRCS} ${GRPC_SERVICE_SRCS} ${DATA_PROTO_SRCS} DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
+            APPEND PROPERTY COMPILE_OPTIONS "$<$<COMPILE_LANGUAGE:CXX>:-fvisibility=default>")
 endif (NOT SKIP_GRPC_BUILD)
 
 add_library(cuopt_objs OBJECT
@@ -556,6 +558,9 @@ add_library(cuopt_objs OBJECT
 
 set_target_properties(cuopt_objs
         PROPERTIES POSITION_INDEPENDENT_CODE ON
+        CXX_VISIBILITY_PRESET hidden
+        CUDA_VISIBILITY_PRESET hidden
+        VISIBILITY_INLINES_HIDDEN ON
         CXX_SCAN_FOR_MODULES OFF
 )
 
@@ -683,6 +688,7 @@ target_link_libraries(cuopt_objs
         PRIVATE
         ${CUOPT_PRIVATE_CUDA_LIBS}
         simde::simde
+        OpenMP::OpenMP_CXX
         OpenMP::OpenMP_CUDA
         $<$<BOOL:${CUOPT_ENABLE_GRPC}>:protobuf::libprotobuf>
         $<$<BOOL:${CUOPT_ENABLE_GRPC}>:gRPC::grpc++>

cpp/include/cuopt/error.hpp

@@ -6,13 +6,14 @@
 /* clang-format on */
 #pragma once
 
+#include <cuopt/export.hpp>
 #include "cuopt/mathematical_optimization/constants.h"
 
 #include <stdarg.h>
 
 #include <raft/core/error.hpp>
 
-namespace cuopt {
+namespace CUOPT_EXPORT cuopt {
 
 /**
  * @brief Indicates different type of exceptions which cuOpt might throw
@@ -168,4 +169,4 @@ void execute_cuopt_fail(Args... args)
   throw cuopt::logic_error(msg, error_type_t::RuntimeError);
 }
 
-}  // namespace cuopt
+}  // namespace CUOPT_EXPORT cuopt

cpp/include/cuopt/export.hpp

@@ -0,0 +1,14 @@
+/* clang-format off */
+/*
+ * SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+/* clang-format on */
+
+#pragma once
+
+#if defined(__GNUC__) || defined(__clang__)
+#define CUOPT_EXPORT __attribute__((visibility("default")))
+#else
+#define CUOPT_EXPORT
+#endif

cpp/include/cuopt/grpc/cython_grpc_client.hpp

@@ -5,6 +5,7 @@
 
 #pragma once
 
+#include <cuopt/export.hpp>
 #include <cuopt/mathematical_optimization/utilities/cython_solve.hpp>
 
 #include <cstddef>
@@ -22,7 +23,8 @@ class data_model_view_t;
 }  // namespace io
 }  // namespace cuopt::mathematical_optimization
 
-namespace cuopt::cython {
+namespace cuopt {
+namespace CUOPT_EXPORT cython {
 
 /** Mirrors cuopt::mathematical_optimization::job_status_t for the Python bindings. */
 enum class grpc_job_status_t : int {
@@ -167,4 +169,5 @@ class grpc_python_client_t {
   std::unique_ptr<impl_t> impl_;
 };
 
-}  // namespace cuopt::cython
+}  // namespace CUOPT_EXPORT cython
+}  // namespace cuopt

cpp/include/cuopt/grpc/grpc_client_env.hpp

@@ -5,9 +5,11 @@
 
 #pragma once
 
+#include <cuopt/export.hpp>
 #include "grpc_client.hpp"
 
-namespace cuopt::mathematical_optimization {
+namespace cuopt {
+namespace CUOPT_EXPORT mathematical_optimization {
 
 /** How TLS is chosen when building a grpc_client_config_t. */
 enum class grpc_tls_mode_t {
@@ -49,4 +51,5 @@ grpc_client_config_t make_grpc_client_config(const std::string& host,
                                              grpc_tls_mode_t tls_mode,
                                              const grpc_explicit_tls_t* explicit_tls = nullptr);
 
-}  // namespace cuopt::mathematical_optimization
+}  // namespace CUOPT_EXPORT mathematical_optimization
+}  // namespace cuopt

cpp/include/cuopt/mathematical_optimization/backend_selection.hpp

@@ -7,7 +7,10 @@
 
 #pragma once
 
-namespace cuopt::mathematical_optimization {
+#include <cuopt/export.hpp>
+
+namespace cuopt {
+namespace CUOPT_EXPORT mathematical_optimization {
 
 /**
  * @brief Enum for execution mode (local vs remote solve)
@@ -51,4 +54,5 @@ execution_mode_t get_execution_mode();
  */
 memory_backend_t get_memory_backend_type();
 
-}  // namespace cuopt::mathematical_optimization
+}  // namespace CUOPT_EXPORT mathematical_optimization
+}  // namespace cuopt

cpp/include/cuopt/mathematical_optimization/cpu_optimization_problem.hpp

@@ -7,6 +7,7 @@
 
 #pragma once
 
+#include <cuopt/export.hpp>
 #include <cuopt/mathematical_optimization/optimization_problem_interface.hpp>
 
 #include <raft/core/handle.hpp>
@@ -18,7 +19,8 @@
 #include <string>
 #include <vector>
 
-namespace cuopt::mathematical_optimization {
+namespace cuopt {
+namespace CUOPT_EXPORT mathematical_optimization {
 
 namespace io {
 template <typename i_t, typename f_t>
@@ -238,4 +240,5 @@ class cpu_optimization_problem_t : public optimization_problem_interface_t<i_t,
   std::vector<std::string> row_names_{};
 };
 
-}  // namespace cuopt::mathematical_optimization
+}  // namespace CUOPT_EXPORT mathematical_optimization
+}  // namespace cuopt

cpp/include/cuopt/mathematical_optimization/cpu_optimization_problem_solution.hpp

@@ -7,6 +7,7 @@
 
 #pragma once
 
+#include <cuopt/export.hpp>
 #include <cuopt/mathematical_optimization/cpu_pdlp_warm_start_data.hpp>
 #include <cuopt/mathematical_optimization/mip/solver_solution.hpp>
 #include <cuopt/mathematical_optimization/mip/solver_stats.hpp>
@@ -18,7 +19,8 @@
 
 #include <vector>
 
-namespace cuopt::mathematical_optimization {
+namespace cuopt {
+namespace CUOPT_EXPORT mathematical_optimization {
 
 /**
  * @brief CPU-backed LP solution (uses std::vector instead of rmm::device_uvector)
@@ -389,4 +391,5 @@ class cpu_mip_solution_t : public mip_solution_interface_t<i_t, f_t> {
   i_t num_simplex_iterations_;
 };
 
-}  // namespace cuopt::mathematical_optimization
+}  // namespace CUOPT_EXPORT mathematical_optimization
+}  // namespace cuopt