Skip to content

Commit 6e1241a

Browse files
fix(build): join EXTRA_CMAKE_ARGS with semicolons for SKBUILD_CMAKE_ARGS (#1588)
\`${arr[*]// /;}\` applies the substitution per-element before joining, so the spaces between array elements are never replaced. Use \`$(IFS=';'; echo "${arr[*]}")\` to join with semicolons directly. Fixes #1587 Authors: - Ramakrishna Prabhu (https://github.com/ramakrishnap-nv) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #1588
1 parent 3e8acd7 commit 6e1241a

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

build.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -416,8 +416,7 @@ fi
416416
if buildAll || hasArg cuopt; then
417417
cd "${REPODIR}"/python/cuopt
418418

419-
# $EXTRA_CMAKE_ARGS gets concatenated into a string with [*] and then we find/replace spaces with semi-colons
420-
SKBUILD_CMAKE_ARGS="-DCMAKE_PREFIX_PATH=${INSTALL_PREFIX};-DCMAKE_LIBRARY_PATH=${LIBCUOPT_BUILD_DIR};-DCMAKE_CUDA_ARCHITECTURES=${CUOPT_CMAKE_CUDA_ARCHITECTURES};${EXTRA_CMAKE_ARGS[*]// /;}" \
419+
SKBUILD_CMAKE_ARGS="-DCMAKE_PREFIX_PATH=${INSTALL_PREFIX};-DCMAKE_LIBRARY_PATH=${LIBCUOPT_BUILD_DIR};-DCMAKE_CUDA_ARCHITECTURES=${CUOPT_CMAKE_CUDA_ARCHITECTURES};$(IFS=';'; echo "${EXTRA_CMAKE_ARGS[*]}")" \
421420
python "${PYTHON_ARGS_FOR_INSTALL[@]}" .
422421
fi
423422

0 commit comments

Comments
 (0)