fix(installer): treat zombie Relay processes as stopped

Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>

Author: bbednarski9

scripts/test-uninstall.sh

@@ -218,10 +218,10 @@ test_force_confirmation_controls_shutdown() {
     run_interactive_uninstaller y "$install_dir"
     assert_success
     [ ! -e "$relay_binary" ] || fail 'accepted confirmation did not remove the Relay binary'
+    wait "$session_pid" 2>/dev/null || true
     if kill -0 "$session_pid" 2>/dev/null; then
         fail 'accepted confirmation did not terminate the Relay process'
     fi
-    wait "$session_pid" 2>/dev/null || true
     active_session_pid=""
     return 0
 }
@@ -274,11 +274,11 @@ EOF
     run_interactive_uninstaller y "$install_dir"
     assert_success
     [ ! -e "$relay_binary" ] || fail 'accepted coding-agent confirmation did not remove the Relay binary'
+    wait "$agent_pid" 2>/dev/null || true
     kill -0 "$agent_pid" 2>/dev/null && fail 'accepted confirmation did not terminate the coding agent owner'
     for child_pid in $active_child_pids; do
         kill -0 "$child_pid" 2>/dev/null && fail "accepted confirmation did not terminate MCP child ${child_pid}"
     done
-    wait "$agent_pid" 2>/dev/null || true
     active_session_pid=""
     active_child_pids=""
     return 0

uninstall.sh

@@ -205,7 +205,7 @@ terminate_process_tree() {
 wait_for_process_exit() {
     wait_pid=$1
     wait_attempt=0
-    while kill -0 "$wait_pid" 2>/dev/null; do
+    while process_is_running "$wait_pid"; do
         if [ "$wait_attempt" -ge 5 ]; then
             error "process ${wait_pid} did not stop after termination was confirmed"
         fi
@@ -214,6 +214,14 @@ wait_for_process_exit() {
     done
 }
 
+process_is_running() {
+    process_state=$(ps -p "$1" -o stat= 2>/dev/null | sed -n '1p' | awk '{$1 = $1; print}')
+    case "$process_state" in
+        ""|Z*) return 1 ;;
+    esac
+    kill -0 "$1" 2>/dev/null
+}
+
 stop_active_relay_processes() {
     active_targets=$(active_shutdown_target_pids)
     [ -n "$active_targets" ] || return 0