Skip to content

Commit b148fd7

Browse files
committed
fix(cli): stabilize daemon tests across platforms
Signed-off-by: Will Killian <wkillian@nvidia.com>
1 parent 06c12d0 commit b148fd7

4 files changed

Lines changed: 30 additions & 14 deletions

File tree

ATTRIBUTIONS-Rust.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18304,7 +18304,7 @@ See the License for the specific language governing permissions and
1830418304
limitations under the License.
1830518305
```
1830618306

18307-
## h2 - 0.4.16
18307+
## h2 - 0.4.19
1830818308
**Repository URL**: https://github.com/hyperium/h2
1830918309
**License Type(s)**: MIT
1831018310
### License: https://spdx.org/licenses/MIT.html

Cargo.lock

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/cli/src/daemon/managed/mod.rs

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -507,12 +507,12 @@ fn render_pi(spec: &ManagedBundleSpec) -> Result<Vec<RenderedArtifact>, CliError
507507
artifact(
508508
ManagedAgent::Pi,
509509
"pi/extension-v1/README.md",
510-
include_bytes!("pi_extension/README.md").to_vec(),
510+
canonical_embedded_text(include_str!("pi_extension/README.md")).into_bytes(),
511511
),
512512
artifact(
513513
ManagedAgent::Pi,
514514
"pi/extension-v1/index.ts",
515-
include_bytes!("pi_extension/index.ts").to_vec(),
515+
canonical_embedded_text(include_str!("pi_extension/index.ts")).into_bytes(),
516516
),
517517
artifact(
518518
ManagedAgent::Pi,
@@ -522,20 +522,20 @@ fn render_pi(spec: &ManagedBundleSpec) -> Result<Vec<RenderedArtifact>, CliError
522522
artifact(
523523
ManagedAgent::Pi,
524524
"pi/extension-v1/package.json",
525-
include_bytes!("pi_extension/package.json").to_vec(),
525+
canonical_embedded_text(include_str!("pi_extension/package.json")).into_bytes(),
526526
),
527527
artifact(
528528
ManagedAgent::Pi,
529529
"pi/extension-v1/tsconfig.json",
530-
include_bytes!("pi_extension/tsconfig.json").to_vec(),
530+
canonical_embedded_text(include_str!("pi_extension/tsconfig.json")).into_bytes(),
531531
),
532532
])
533533
}
534534

535535
fn render_pi_config(spec: &ManagedBundleSpec) -> Result<Vec<u8>, CliError> {
536-
let template = include_str!("pi_extension/managed-config.json");
536+
let template = canonical_embedded_text(include_str!("pi_extension/managed-config.json"));
537537
let rendered = replace_json_string_value(
538-
template,
538+
&template,
539539
PI_DAEMON_ADDRESS_PLACEHOLDER,
540540
&spec.daemon_address,
541541
)?;
@@ -557,6 +557,10 @@ fn render_pi_config(spec: &ManagedBundleSpec) -> Result<Vec<u8>, CliError> {
557557
Ok(rendered.into_bytes())
558558
}
559559

560+
fn canonical_embedded_text(template: &str) -> String {
561+
template.replace("\r\n", "\n")
562+
}
563+
560564
fn replace_json_string_value(
561565
template: &str,
562566
placeholder: &str,

crates/cli/tests/coverage/daemon/managed_tests.rs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,18 @@ fn canonical_v1_bundle_matches_the_release_frozen_golden_digest() {
271271
assert_eq!(rendered_bundle_digest(&rendered).to_string(), GOLDEN_SHA256);
272272
}
273273

274+
#[test]
275+
fn embedded_managed_text_has_platform_independent_line_endings() {
276+
assert_eq!(
277+
canonical_embedded_text("first\r\nsecond\r\n"),
278+
"first\nsecond\n"
279+
);
280+
assert_eq!(
281+
canonical_embedded_text("first\nsecond\n"),
282+
"first\nsecond\n"
283+
);
284+
}
285+
274286
#[test]
275287
fn write_is_create_only_and_existing_exact_bundle_is_not_rewritten() {
276288
let directory = tempdir().unwrap();

0 commit comments

Comments
 (0)