Priority Level
Medium
Task Summary
The PR template suggests that make check should pass locally. However, on a fresh clone of the repo plus make install, running make check does exit with a 0 status code but reports 230 ty error diagnostics.
Technical Details & Implementation Plan
Some of these seem like potentially repo and/or [ty-]environment setup issues. For example:
error[unknown-argument]: Argument `task_status` does not match any known parameter
--> tests/test_telemetry.py:228:17
|
226 | AnonymizerEvent(
227 | task=TaskEnum.BATCH,
228 | task_status=TaskStatusEnum.COMPLETED,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
229 | transformation_type="redact",
230 | )
|
info: rule `unknown-argument` is enabled by default
error[unknown-argument]: Argument `transformation_type` does not match any known parameter
--> tests/test_telemetry.py:229:17
|
227 | task=TaskEnum.BATCH,
228 | task_status=TaskStatusEnum.COMPLETED,
229 | transformation_type="redact",
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
230 | )
|
info: rule `unknown-argument` is enabled by default
These seem reasonable given the AnonymizerEvent pydantic definition (see task_status and transformation_type).
Dependencies
No response
Priority Level
Medium
Task Summary
The PR template suggests that
make checkshould pass locally. However, on a fresh clone of the repo plusmake install, runningmake checkdoes exit with a0status code but reports 230tyerror diagnostics.Technical Details & Implementation Plan
Some of these seem like potentially repo and/or [ty-]environment setup issues. For example:
These seem reasonable given the
AnonymizerEventpydantic definition (see task_status and transformation_type).Dependencies
No response