Skip to content

Recall Entropy miscalculated? #1

Description

@HV-tno

Hi,

First of all, thanks for your unified framework. I am doing a master thesis and I aim to applying your metric to synthetic text data.

In implementing your code by means of 'metrics.py', I came across something what I think is an error:

Image

You only compute the recall entropy of the reference dataset containing the "real features" instead of what you do in the notebook, where you rightly subtract the entropy of "fake features" before returning the value:

Image

If it is indeed a bug, can you fix that in your code?

Update: I now see that the same holds for recall cross entropy and precision cross entropy.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions