Skip to content

Import external "void" from yadmark #17

Description

@alecandido

At the moment, "void" external (i.e. just run myself, leave external empty) is only implemented inside yadmark:

https://github.com/N3PDF/yadism/blob/593a012dc7f4666c2c993dbdd37a6a2d55db0455/benchmarks/yadmark/benchmark/runner.py#L100-L112

This is rather useful (especially thinking about ekobox and yadbox), so I propose:

  • move that code from yadmark to banana
  • replace "void" (meaningful, but a bit random) with just None (it seems natural to me that, if the external is empty, then no external should be used)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    runnersTools for writing benchmarks' runners

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions