fix(publish): drop conditional sign + remove coordinates( comment trap (#117)

The publish workflow's "Discover Modules" step does
`grep 'coordinates(' build.gradle.kts` to extract artifact names. Both
cmp-observe and cmp-observe-koin had comment blocks containing the literal
token (e.g. "// Calling coordinates() here breaks..."). The grep matched the
comment, sed failed to extract a name from a comment line, and the multi-line
comment text became the ARTIFACT value — which broke $GITHUB_OUTPUT's
key=value format with "Invalid format" on the next push.

Aligning all 4 affected modules to the canonical pattern used by
cmp-remote-config + cmp-share + cmp-product-tickets etc.:

  mavenPublishing {
      signAllPublications()
      pom { ... }
  }

## Changes per module

| Module | Before | After |
|---|---|---|
| cmp-observe | comment block + `if (signingInMemoryKey.isPresent) signAllPublications()` | plain `signAllPublications()` |
| cmp-observe-koin | comment block + conditional | plain `signAllPublications()` |
| cmp-network-monitor | conditional (no comment trap) | plain `signAllPublications()` |
| cmp-network-monitor-compose | conditional (no comment trap) | plain `signAllPublications()` |

The `if (providers.gradleProperty("signingInMemoryKey").isPresent)` guard
was a leftover from a transitional period. signAllPublications() is safe to
call unconditionally — vanniktech's plugin no-ops at sign-time when
in-memory key isn't present (logs a warning), so local `assemble` /
`publishToMavenLocal` builds still work. Matches what cmp-remote-config and
21 other cmp-* modules already do.

Post-fix sweep: 21/21 modules with mavenPublishing block use plain
`signAllPublications()`. Zero comment-trap matches remain.

Co-authored-by: Rajan Maurya <therajanmaurya@Rajans-MacBook-Pro.local>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: 3 people

cmp-network-monitor-compose/build.gradle.kts

@@ -113,10 +113,7 @@ kotlin {
 // MAVEN CENTRAL PUBLISHING CONFIGURATION
 // ============================================================================
 mavenPublishing {
-    // Sign only when credentials are present (Maven Central / CI). Skip for local dev builds.
-    if (providers.gradleProperty("signingInMemoryKey").isPresent) {
-        signAllPublications()
-    }
+    signAllPublications()
 
     pom {
         name = "CMP Network Monitor Compose"

cmp-network-monitor/build.gradle.kts

@@ -165,10 +165,7 @@ kotlin {
 // MAVEN CENTRAL PUBLISHING CONFIGURATION
 // ============================================================================
 mavenPublishing {
-    // Sign only when credentials are present (Maven Central / CI). Skip for local dev builds.
-    if (providers.gradleProperty("signingInMemoryKey").isPresent) {
-        signAllPublications()
-    }
+    signAllPublications()
 
     pom {
         name = "CMP Network Monitor"

cmp-observe-koin/build.gradle.kts

@@ -89,17 +89,7 @@ kotlin {
 }
 
 mavenPublishing {
-    // No explicit coordinates() — the vanniktech plugin auto-derives from
-    // project.group / project.name / project.version. Calling coordinates()
-    // here breaks the publish workflow, which pre-finalizes the version
-    // property; a second assignment throws:
-    //   "The value for extension 'mavenPublishing' property 'version$plugin'
-    //    is final and cannot be changed any further."
-
-    // Sign only when credentials are present (Maven Central / CI). Skip for local dev builds.
-    if (providers.gradleProperty("signingInMemoryKey").isPresent) {
-        signAllPublications()
-    }
+    signAllPublications()
 
     pom {
         name = "CMP Observe Koin"

cmp-observe/build.gradle.kts

@@ -167,17 +167,7 @@ kotlin {
 }
 
 mavenPublishing {
-    // No explicit coordinates() — the vanniktech plugin auto-derives from
-    // project.group / project.name / project.version. Calling coordinates()
-    // here breaks the publish workflow, which pre-finalizes the version
-    // property (`-Pversion=X.Y.Z`); a second assignment throws:
-    //   "The value for extension 'mavenPublishing' property 'version$plugin'
-    //    is final and cannot be changed any further."
-
-    // Sign only when credentials are present (Maven Central / CI). Skip for local dev builds.
-    if (providers.gradleProperty("signingInMemoryKey").isPresent) {
-        signAllPublications()
-    }
+    signAllPublications()
 
     pom {
         name = "CMP Observe"