Skip to content

TUI silently swallows every message after a failed session create #241

Description

@robertohluna

create_session sets session_creation_pending = true (handle_actions.rs:1927). The only reset is at handle_backend.rs:1504, inside the Ok arm. The Err arm at handle_backend.rs:1587 only pushes a toast.

After any transient session-create failure, startup_session_pending() stays true forever, so handle_actions.rs:691 enqueues every submitted message and returns, and maybe_dequeue_message (handle_actions.rs:834) early-returns at every turn-completion site. The user types, sees the text accepted as a dim queued line, and nothing is ever sent — no spinner, no response.

The recovery the toast suggests (/new) calls create_session, which re-latches the flag, so a second failure re-locks it.

Found independently by two reviewers.

Fix: set self.session_creation_pending = false; in the Err arm.

Shipped knowingly in v1.0.177.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions