Inconsistency in added tags like "UnhandledException"

[fschwiet]

It's nice that the tag "UnhandledException" gets added sometimes.. but it would be nice if every report that was initiated by Raygun had a tag indicating how the exception was caught..

For example, on on Android we have the UnhandledException tag, but not on Mac. I would hope both platforms would have such a tag:

• raygun4net/Mindscape.Raygun4Net.Xamarin.Android/RaygunClient.cs

  Line 455 in 637422b

  _client.Send(e.Exception, new List<string>() { "UnhandledException" });

• raygun4net/Mindscape.Raygun4Net.Xamarin.Mac.Unified/RaygunClient.cs

  Line 221 in 637422b

  private static void CurrentDomain_UnhandledException(object sender, UnhandledExceptionEventArgs e)

A second example is that in Android we have the same tag used for separate handlers. I would hope both exception sources could have their own name:

• raygun4net/Mindscape.Raygun4Net.Xamarin.Android/RaygunClient.cs

  Line 446 in 637422b

  _client.Send((e.ExceptionObject as Exception), new List<string>(){ "UnhandledException" });

• raygun4net/Mindscape.Raygun4Net.Xamarin.Android/RaygunClient.cs

  Line 455 in 637422b

  _client.Send(e.Exception, new List<string>() { "UnhandledException" });

This seems like a straightforward thing to improve, heck maybe even I could do it. I wanted to get feedback though to find out if the project owners think it is a good idea. It seems adding tags should be safe, there might be more risk in changing tags (I would like to change

raygun4net/Mindscape.Raygun4Net.Xamarin.Android/RaygunClient.cs

Line 455 in 637422b

_client.Send(e.Exception, new List<string>() { "UnhandledException" });

to use "UnhandledExceptionRaiser" instead of "UnhandledException").

[QuantumNightmare]

Hi fscwiet,

Thanks for starting a discussion about this. The tag "UnhandledException" is used by the Raygun service when calculating metrics that distinguish between exceptions that have caused an application crash, vs exceptions that do not crash the application. The thinking here is that exceptions that reach the unhandled exceptions hooks generally mean the application is going to crash, whereas exceptions caught in a try/catch don't.

As such, we wouldn't want these tags to be changed anywhere.

The missing tag in the Mac provider would be good to fix up though. I expect we won't get around to this for a while, so if you need this sooner than later, feel free to add a PR to speed this up.

As for distinguishing the different unhandled exception hooks such as in the Android provider, it shouldn't hurt to add an additional tag of "UnhandledExceptionRaiser", so you can add that too if you like.

-Jason Fauchelle