From 76df0ddd0f81f0d23254cc6c29fa431d9cc9bf47 Mon Sep 17 00:00:00 2001 From: Leonardo Taglialegne Date: Wed, 8 Oct 2025 13:16:22 +0200 Subject: [PATCH 1/8] Add elm-review config --- review/elm.json | 39 +++++++++++++++ review/src/ReviewConfig.elm | 49 +++++++++++++++++++ .../NoMissingTypeAnnotationInLetIn.json | 13 +++++ review/suppressed/NoMissingTypeExpose.json | 8 +++ review/suppressed/NoUnused.Exports.json | 8 +++ 5 files changed, 117 insertions(+) create mode 100644 review/elm.json create mode 100644 review/src/ReviewConfig.elm create mode 100644 review/suppressed/NoMissingTypeAnnotationInLetIn.json create mode 100644 review/suppressed/NoMissingTypeExpose.json create mode 100644 review/suppressed/NoUnused.Exports.json diff --git a/review/elm.json b/review/elm.json new file mode 100644 index 0000000..47c39c0 --- /dev/null +++ b/review/elm.json @@ -0,0 +1,39 @@ +{ + "type": "application", + "source-directories": [ + "src" + ], + "elm-version": "0.19.1", + "dependencies": { + "direct": { + "elm/core": "1.0.5", + "elm/json": "1.1.3", + "jfmengels/elm-review": "2.15.1", + "jfmengels/elm-review-code-style": "1.2.0", + "jfmengels/elm-review-common": "1.3.3", + "jfmengels/elm-review-debug": "1.0.8", + "jfmengels/elm-review-documentation": "2.0.4", + "jfmengels/elm-review-simplify": "2.1.8", + "jfmengels/elm-review-unused": "1.2.4" + }, + "indirect": { + "elm/bytes": "1.0.8", + "elm/html": "1.0.0", + "elm/parser": "1.1.0", + "elm/project-metadata-utils": "1.0.2", + "elm/random": "1.0.0", + "elm/regex": "1.0.0", + "elm/time": "1.0.0", + "elm/virtual-dom": "1.0.3", + "elm-explorations/test": "2.2.0", + "pzp1997/assoc-list": "1.0.0", + "rtfeldman/elm-hex": "1.0.0", + "stil4m/elm-syntax": "7.3.9", + "stil4m/structured-writer": "1.0.3" + } + }, + "test-dependencies": { + "direct": {}, + "indirect": {} + } +} diff --git a/review/src/ReviewConfig.elm b/review/src/ReviewConfig.elm new file mode 100644 index 0000000..74bcd41 --- /dev/null +++ b/review/src/ReviewConfig.elm @@ -0,0 +1,49 @@ +module ReviewConfig exposing (config) + +import Docs.ReviewAtDocs +import NoConfusingPrefixOperator +import NoDebug.Log +import NoDebug.TodoOrToString +import NoExposingEverything +import NoImportingEverything +import NoMissingTypeAnnotation +import NoMissingTypeAnnotationInLetIn +import NoMissingTypeExpose +import NoPrematureLetComputation +import NoSimpleLetBody +import NoUnused.CustomTypeConstructorArgs +import NoUnused.CustomTypeConstructors +import NoUnused.Dependencies +import NoUnused.Exports +import NoUnused.Parameters +import NoUnused.Patterns +import NoUnused.Variables +import Review.Rule as Rule exposing (Rule) +import Simplify + + +config : List Rule +config = + [ Docs.ReviewAtDocs.rule + , NoConfusingPrefixOperator.rule + , NoDebug.Log.rule + , NoDebug.TodoOrToString.rule + |> Rule.ignoreErrorsForDirectories [ "tests/" ] + , NoExposingEverything.rule + , NoImportingEverything.rule [] + , NoMissingTypeAnnotation.rule + , NoMissingTypeAnnotationInLetIn.rule + |> Rule.ignoreErrorsForDirectories [ "tests/" ] + , NoMissingTypeExpose.rule + , NoSimpleLetBody.rule + , NoPrematureLetComputation.rule + , NoUnused.CustomTypeConstructors.rule [] + , NoUnused.CustomTypeConstructorArgs.rule + , NoUnused.Dependencies.rule + , NoUnused.Exports.rule + , NoUnused.Parameters.rule + , NoUnused.Patterns.rule + , NoUnused.Variables.rule + |> Rule.ignoreErrorsForDirectories [ "tests/" ] + , Simplify.rule (Simplify.defaults |> Simplify.expectNaN) + ] diff --git a/review/suppressed/NoMissingTypeAnnotationInLetIn.json b/review/suppressed/NoMissingTypeAnnotationInLetIn.json new file mode 100644 index 0000000..51255f2 --- /dev/null +++ b/review/suppressed/NoMissingTypeAnnotationInLetIn.json @@ -0,0 +1,13 @@ +{ + "version": 1, + "automatically created by": "elm-review suppress", + "learn more": "elm-review suppress --help", + "suppressions": [ + { "count": 12, "filePath": "src/Yaml/Parser.elm" }, + { "count": 7, "filePath": "src/Yaml/Parser/Util.elm" }, + { "count": 4, "filePath": "src/Yaml/Encode.elm" }, + { "count": 1, "filePath": "src/Yaml/Decode.elm" }, + { "count": 1, "filePath": "src/Yaml/Parser/Ast.elm" }, + { "count": 1, "filePath": "src/Yaml/Parser/String.elm" } + ] +} diff --git a/review/suppressed/NoMissingTypeExpose.json b/review/suppressed/NoMissingTypeExpose.json new file mode 100644 index 0000000..93ef7bd --- /dev/null +++ b/review/suppressed/NoMissingTypeExpose.json @@ -0,0 +1,8 @@ +{ + "version": 1, + "automatically created by": "elm-review suppress", + "learn more": "elm-review suppress --help", + "suppressions": [ + { "count": 1, "filePath": "src/Yaml/Encode.elm" } + ] +} diff --git a/review/suppressed/NoUnused.Exports.json b/review/suppressed/NoUnused.Exports.json new file mode 100644 index 0000000..4115560 --- /dev/null +++ b/review/suppressed/NoUnused.Exports.json @@ -0,0 +1,8 @@ +{ + "version": 1, + "automatically created by": "elm-review suppress", + "learn more": "elm-review suppress --help", + "suppressions": [ + { "count": 5, "filePath": "src/Yaml/Parser/Util.elm" } + ] +} From ac7a89f661641d72e07137d9fb921b0d50417e71 Mon Sep 17 00:00:00 2001 From: Leonardo Taglialegne Date: Wed, 8 Oct 2025 13:16:57 +0200 Subject: [PATCH 2/8] Apply elm-review fixes --- src/Yaml/Encode.elm | 13 +++++-------- src/Yaml/Parser.elm | 10 ++-------- src/Yaml/Parser/Ast.elm | 8 ++++---- tests/Expectations.elm | 2 +- tests/TestEncoder.elm | 11 +++++------ 5 files changed, 17 insertions(+), 27 deletions(-) diff --git a/src/Yaml/Encode.elm b/src/Yaml/Encode.elm index eec702c..bc65c4a 100644 --- a/src/Yaml/Encode.elm +++ b/src/Yaml/Encode.elm @@ -169,19 +169,16 @@ int i = float : Float -> Encoder float f = let - sign = - if f < 0 then - "-" - - else - "" - val = if isNaN f then ".nan" else if isInfinite f then - sign ++ ".inf" + if f < 0 then + "-.inf" + + else + ".inf" else String.fromFloat f diff --git a/src/Yaml/Parser.elm b/src/Yaml/Parser.elm index 7df7740..190ae52 100644 --- a/src/Yaml/Parser.elm +++ b/src/Yaml/Parser.elm @@ -1,4 +1,4 @@ -module Yaml.Parser exposing (Value, fromString, parser, toString) +module Yaml.Parser exposing (Value, fromString, parser) import Dict exposing (Dict) import Parser as P exposing ((|.), (|=)) @@ -14,12 +14,6 @@ type alias Value = Ast.Value -{-| -} -toString : Value -> String -toString = - Ast.toString - - -- ERROR REPORTING @@ -479,7 +473,7 @@ duplicatedPropertyKeysCheck properties = duplicates = duplicatedPropertyKeys properties in - if List.length duplicates == 0 then + if List.isEmpty duplicates then P.succeed properties else diff --git a/src/Yaml/Parser/Ast.elm b/src/Yaml/Parser/Ast.elm index 9135fcd..76e8f05 100644 --- a/src/Yaml/Parser/Ast.elm +++ b/src/Yaml/Parser/Ast.elm @@ -140,13 +140,13 @@ fromString string = Float_ (0 / 0) ( mult, ".inf" ) -> - Float_ (mult * 1 / 0) + Float_ (mult / 0) ( mult, ".Inf" ) -> - Float_ (mult * 1 / 0) + Float_ (mult / 0) ( mult, ".INF" ) -> - Float_ (mult * 1 / 0) + Float_ (mult / 0) _ -> case String.toInt trimmed of @@ -233,7 +233,7 @@ fold f value z = Record_ r -> f value (List.foldl (fold f) z (Dict.values r)) - Anchor_ nm a -> + Anchor_ _ a -> f value (fold f a z) diff --git a/tests/Expectations.elm b/tests/Expectations.elm index 04345b1..9eae68d 100644 --- a/tests/Expectations.elm +++ b/tests/Expectations.elm @@ -27,7 +27,7 @@ expectFail expected got = -} expectOneOf : List comparable -> comparable -> Expect.Expectation expectOneOf expected got = - if List.any (\x -> x == got) expected then + if List.member got expected then Expect.pass else diff --git a/tests/TestEncoder.elm b/tests/TestEncoder.elm index f6c3ef1..eada423 100644 --- a/tests/TestEncoder.elm +++ b/tests/TestEncoder.elm @@ -2,7 +2,7 @@ module TestEncoder exposing (suite) import Dict import Expect -import Format exposing (formatFloat, formatFloatOutput) +import Format exposing (formatFloatOutput) import Fuzz exposing (bool, float, int, list, map2, string) import Test import Yaml.Decode as Decode @@ -323,12 +323,11 @@ suite = let boolToString : Bool -> String boolToString b = - case b of - True -> - "true" + if b then + "true" - False -> - "false" + else + "false" in Expect.equal ("{x: " From 31192c4e1afb0958921c827155cee84a0b5c1d3a Mon Sep 17 00:00:00 2001 From: Leonardo Taglialegne Date: Wed, 8 Oct 2025 13:26:14 +0200 Subject: [PATCH 3/8] Add check for broken parser functions --- review/elm.json | 3 ++- review/src/ReviewConfig.elm | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/review/elm.json b/review/elm.json index 47c39c0..ad1429a 100644 --- a/review/elm.json +++ b/review/elm.json @@ -14,7 +14,8 @@ "jfmengels/elm-review-debug": "1.0.8", "jfmengels/elm-review-documentation": "2.0.4", "jfmengels/elm-review-simplify": "2.1.8", - "jfmengels/elm-review-unused": "1.2.4" + "jfmengels/elm-review-unused": "1.2.4", + "miniBill/elm-review-no-broken-elm-parser-functions": "1.0.0" }, "indirect": { "elm/bytes": "1.0.8", diff --git a/review/src/ReviewConfig.elm b/review/src/ReviewConfig.elm index 74bcd41..ed2e9b9 100644 --- a/review/src/ReviewConfig.elm +++ b/review/src/ReviewConfig.elm @@ -1,6 +1,7 @@ module ReviewConfig exposing (config) import Docs.ReviewAtDocs +import NoBrokenParserFunctions import NoConfusingPrefixOperator import NoDebug.Log import NoDebug.TodoOrToString @@ -46,4 +47,5 @@ config = , NoUnused.Variables.rule |> Rule.ignoreErrorsForDirectories [ "tests/" ] , Simplify.rule (Simplify.defaults |> Simplify.expectNaN) + , NoBrokenParserFunctions.rule ] From a2962e93b4d25550e7753e36d88ef5196413421c Mon Sep 17 00:00:00 2001 From: Leonardo Taglialegne Date: Fri, 10 Oct 2025 13:19:59 +0200 Subject: [PATCH 4/8] Add elm-review to workflow --- .github/workflows/tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 5724103..6785bbd 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -17,3 +17,5 @@ jobs: run: elm make --docs=docs.json - name: Verify documentation run: npx elm-verify-examples --run-tests + - name: elm-review + run: npx elm-review \ No newline at end of file From ec302f5baae88d78ef4b9eebe2e0cd403ba75bd0 Mon Sep 17 00:00:00 2001 From: Leonardo Taglialegne Date: Fri, 10 Oct 2025 13:22:35 +0200 Subject: [PATCH 5/8] elm-review needs to run before elm-verify-examples, because the latter generates code which doesn't pass validation --- .github/workflows/tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 6785bbd..7213d92 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -15,7 +15,7 @@ jobs: run: npx elm-test - name: Check documentation run: elm make --docs=docs.json - - name: Verify documentation - run: npx elm-verify-examples --run-tests - name: elm-review - run: npx elm-review \ No newline at end of file + run: npx elm-review + - name: Verify documentation + run: npx elm-verify-examples --run-tests \ No newline at end of file From 23979d2c337ed8050bcfbd08dbdc439849599701 Mon Sep 17 00:00:00 2001 From: Leonardo Taglialegne Date: Fri, 10 Oct 2025 13:27:55 +0200 Subject: [PATCH 6/8] Add extra rules for packages --- review/elm.json | 4 +--- review/src/ReviewConfig.elm | 11 ++++++++++- review/suppressed/Docs.ReviewLinksAndSections.json | 8 ++++++++ 3 files changed, 19 insertions(+), 4 deletions(-) create mode 100644 review/suppressed/Docs.ReviewLinksAndSections.json diff --git a/review/elm.json b/review/elm.json index ad1429a..b40ab29 100644 --- a/review/elm.json +++ b/review/elm.json @@ -1,8 +1,6 @@ { "type": "application", - "source-directories": [ - "src" - ], + "source-directories": ["src"], "elm-version": "0.19.1", "dependencies": { "direct": { diff --git a/review/src/ReviewConfig.elm b/review/src/ReviewConfig.elm index ed2e9b9..836e352 100644 --- a/review/src/ReviewConfig.elm +++ b/review/src/ReviewConfig.elm @@ -1,6 +1,9 @@ module ReviewConfig exposing (config) +import Docs.NoMissing exposing (exposedModules, onlyExposed) import Docs.ReviewAtDocs +import Docs.ReviewLinksAndSections +import Docs.UpToDateReadmeLinks import NoBrokenParserFunctions import NoConfusingPrefixOperator import NoDebug.Log @@ -25,7 +28,13 @@ import Simplify config : List Rule config = - [ Docs.ReviewAtDocs.rule + [ Docs.NoMissing.rule + { document = onlyExposed + , from = exposedModules + } + , Docs.ReviewLinksAndSections.rule + |> Rule.ignoreErrorsForFiles [ "README.md" ] + , Docs.ReviewAtDocs.rule , NoConfusingPrefixOperator.rule , NoDebug.Log.rule , NoDebug.TodoOrToString.rule diff --git a/review/suppressed/Docs.ReviewLinksAndSections.json b/review/suppressed/Docs.ReviewLinksAndSections.json new file mode 100644 index 0000000..429daaa --- /dev/null +++ b/review/suppressed/Docs.ReviewLinksAndSections.json @@ -0,0 +1,8 @@ +{ + "version": 1, + "automatically created by": "elm-review suppress", + "learn more": "elm-review suppress --help", + "suppressions": [ + { "count": 1, "filePath": "src/Yaml/Decode.elm" } + ] +} From b232e7c9001a5f65c6dbbde0fc41066ec5e8191f Mon Sep 17 00:00:00 2001 From: Leonardo Taglialegne Date: Fri, 10 Oct 2025 13:31:53 +0200 Subject: [PATCH 7/8] Add missing type annotations in let/in --- .../suppressed/NoMissingTypeAnnotationInLetIn.json | 13 ------------- src/Yaml/Decode.elm | 1 + src/Yaml/Encode.elm | 4 ++++ src/Yaml/Parser.elm | 12 ++++++++++++ src/Yaml/Parser/Ast.elm | 1 + src/Yaml/Parser/String.elm | 1 + src/Yaml/Parser/Util.elm | 7 +++++++ 7 files changed, 26 insertions(+), 13 deletions(-) delete mode 100644 review/suppressed/NoMissingTypeAnnotationInLetIn.json diff --git a/review/suppressed/NoMissingTypeAnnotationInLetIn.json b/review/suppressed/NoMissingTypeAnnotationInLetIn.json deleted file mode 100644 index 51255f2..0000000 --- a/review/suppressed/NoMissingTypeAnnotationInLetIn.json +++ /dev/null @@ -1,13 +0,0 @@ -{ - "version": 1, - "automatically created by": "elm-review suppress", - "learn more": "elm-review suppress --help", - "suppressions": [ - { "count": 12, "filePath": "src/Yaml/Parser.elm" }, - { "count": 7, "filePath": "src/Yaml/Parser/Util.elm" }, - { "count": 4, "filePath": "src/Yaml/Encode.elm" }, - { "count": 1, "filePath": "src/Yaml/Decode.elm" }, - { "count": 1, "filePath": "src/Yaml/Parser/Ast.elm" }, - { "count": 1, "filePath": "src/Yaml/Parser/String.elm" } - ] -} diff --git a/src/Yaml/Decode.elm b/src/Yaml/Decode.elm index 5e5f92d..cc9af22 100644 --- a/src/Yaml/Decode.elm +++ b/src/Yaml/Decode.elm @@ -1023,6 +1023,7 @@ fromMaybe err mby = singleResult : List (Result Error a) -> Result Error (List a) singleResult = let + each : Result error value -> Result error (List value) -> Result error (List value) each v r = case r of Err _ -> diff --git a/src/Yaml/Encode.elm b/src/Yaml/Encode.elm index bc65c4a..8389d79 100644 --- a/src/Yaml/Encode.elm +++ b/src/Yaml/Encode.elm @@ -169,6 +169,7 @@ int i = float : Float -> Encoder float f = let + val : String val = if isNaN f then ".nan" @@ -371,6 +372,7 @@ encodeDict key val state r = recordElement : ( k, v ) -> String recordElement ( key_, val_ ) = let + newState : EncoderState newState = { state | inRecord = True, col = state.col + state.indent } in @@ -435,9 +437,11 @@ encodeRecord state r = recordElement : ( String, Encoder ) -> String recordElement ( key, val ) = let + newState : EncoderState newState = { state | inRecord = True, col = state.col + state.indent } + encodedValue : String encodedValue = internalConvertToString newState val in diff --git a/src/Yaml/Parser.elm b/src/Yaml/Parser.elm index 190ae52..60e409e 100644 --- a/src/Yaml/Parser.elm +++ b/src/Yaml/Parser.elm @@ -122,6 +122,7 @@ value = list : Int -> P.Parser Ast.Value list indent = let + confirmed : Ast.Value -> P.Parser Ast.Value confirmed value_ = P.succeed Ast.List_ |= P.loop [ value_ ] (listStep indent) @@ -133,9 +134,11 @@ list indent = listStep : Int -> List Ast.Value -> P.Parser (P.Step (List Ast.Value) (List Ast.Value)) listStep indent values = let + finish : P.Step state (List Ast.Value) finish = P.Done (List.reverse values) + next : Ast.Value -> P.Step (List Ast.Value) a next value_ = P.Loop (value_ :: values) in @@ -291,6 +294,7 @@ listInlineOnDone elements element = recordOrString : Int -> Int -> P.Parser Ast.Value recordOrString indent indent_ = let + withString : String -> P.Parser Ast.Value withString string = P.oneOf [ P.succeed (Ast.fromString string) @@ -305,9 +309,11 @@ recordOrString indent indent_ = ) ] + addRemaining : String -> String -> Ast.Value addRemaining string remaining = Ast.fromString <| U.postProcessString (removeComment string ++ remaining) + removeComment : String -> String removeComment string = string |> String.split "#" @@ -331,6 +337,7 @@ recordOrString indent indent_ = quotedString : Int -> P.Parser Ast.Value quotedString indent = let + withQuote : String -> P.Parser Ast.Value withQuote quote = P.oneOf [ recordProperty indent quote @@ -357,6 +364,7 @@ recordProperty indent name = record : Int -> String -> P.Parser Ast.Value record indent property = let + confirmed : Ast.Value -> P.Parser Ast.Value confirmed value_ = P.succeed identity |= P.loop [ ( property, value_ ) ] (recordStep indent) @@ -370,9 +378,11 @@ record indent property = recordStep : Int -> List Ast.Property -> P.Parser (P.Step (List Ast.Property) (List Ast.Property)) recordStep indent values = let + finish : P.Step state (List Ast.Property) finish = P.Done (List.reverse values) + next : Ast.Property -> P.Step (List Ast.Property) a next value_ = P.Loop (value_ :: values) in @@ -393,6 +403,7 @@ recordStep indent values = recordElement : Int -> P.Parser Ast.Property recordElement indent = let + property : P.Parser String property = P.oneOf [ U.singleQuotes @@ -556,6 +567,7 @@ recordInlinePropertyNameString = recordInlinePropertyValue : P.Parser Ast.Value recordInlinePropertyValue = let + propVal : P.Parser Ast.Value propVal = P.oneOf [ listInline diff --git a/src/Yaml/Parser/Ast.elm b/src/Yaml/Parser/Ast.elm index 76e8f05..fa5f385 100644 --- a/src/Yaml/Parser/Ast.elm +++ b/src/Yaml/Parser/Ast.elm @@ -29,6 +29,7 @@ type alias Property = fromString : String -> Value fromString string = let + trimmed : String trimmed = String.trim string diff --git a/src/Yaml/Parser/String.elm b/src/Yaml/Parser/String.elm index b58470d..0fddb4e 100644 --- a/src/Yaml/Parser/String.elm +++ b/src/Yaml/Parser/String.elm @@ -9,6 +9,7 @@ import Yaml.Parser.Util as U exceptions : P.Parser Ast.Value exceptions = let + dashed : String -> String dashed s = "---" ++ s in diff --git a/src/Yaml/Parser/Util.elm b/src/Yaml/Parser/Util.elm index 2b542c9..14c289a 100644 --- a/src/Yaml/Parser/Util.elm +++ b/src/Yaml/Parser/Util.elm @@ -164,6 +164,7 @@ spaces = whitespace : P.Parser () whitespace = let + step : a -> P.Parser (P.Step () ()) step _ = P.oneOf [ P.succeed (P.Loop ()) @@ -201,6 +202,7 @@ multilineStep indent lines = multilineString lines_ = String.join "\n" (List.reverse lines_) + conclusion : String -> Maybe ( Int, Int ) -> P.Step (List String) String conclusion line next = case next of Just ( emptyLineCount, indent_ ) -> @@ -251,17 +253,20 @@ emptyLinesStep count = characters : (Char -> Bool) -> P.Parser String characters isOk = let + done : List String -> P.Step state String done chars = chars |> List.reverse |> String.concat |> P.Done + more : List b -> b -> P.Step (List b) a more chars char = char :: chars |> P.Loop + step : List String -> P.Parser (P.Step (List String) String) step chars = P.oneOf [ P.succeed (done chars) @@ -354,6 +359,7 @@ postProcessLiteralString str = case String.left 2 str of "|\n" -> let + content : String content = String.dropLeft 2 str in @@ -405,6 +411,7 @@ countLeadingSpacesInString str = indented : Int -> { smaller : P.Parser a, exactly : P.Parser a, larger : Int -> P.Parser a, ending : P.Parser a } -> P.Parser a indented indent next = let + check : Int -> P.Parser a check actual = P.oneOf [ P.andThen (\_ -> next.ending) P.end From a8d359c1fff2081ff1cbf95a02e63fb880237676 Mon Sep 17 00:00:00 2001 From: Leonardo Taglialegne Date: Fri, 10 Oct 2025 13:32:33 +0200 Subject: [PATCH 8/8] Remove unused functions --- review/suppressed/NoUnused.Exports.json | 8 ------- src/Yaml/Parser/Util.elm | 29 ------------------------- 2 files changed, 37 deletions(-) delete mode 100644 review/suppressed/NoUnused.Exports.json diff --git a/review/suppressed/NoUnused.Exports.json b/review/suppressed/NoUnused.Exports.json deleted file mode 100644 index 4115560..0000000 --- a/review/suppressed/NoUnused.Exports.json +++ /dev/null @@ -1,8 +0,0 @@ -{ - "version": 1, - "automatically created by": "elm-review suppress", - "learn more": "elm-review suppress --help", - "suppressions": [ - { "count": 5, "filePath": "src/Yaml/Parser/Util.elm" } - ] -} diff --git a/src/Yaml/Parser/Util.elm b/src/Yaml/Parser/Util.elm index 14c289a..24df365 100644 --- a/src/Yaml/Parser/Util.elm +++ b/src/Yaml/Parser/Util.elm @@ -1,12 +1,8 @@ module Yaml.Parser.Util exposing ( doubleQuotes - , either , indented , isColon , isComma - , isDash - , isDot - , isHash , isListEnd , isListStart , isNewLine @@ -17,7 +13,6 @@ module Yaml.Parser.Util exposing , neither , neither3 , postProcessFoldedString - , postProcessLiteralString , postProcessString , remaining , singleQuotes @@ -48,24 +43,6 @@ isComma = is ',' -{-| -} -isDot : Char -> Bool -isDot = - is '.' - - -{-| -} -isDash : Char -> Bool -isDash = - is '-' - - -{-| -} -isHash : Char -> Bool -isHash = - is '#' - - {-| -} isSpace : Char -> Bool isSpace = @@ -114,12 +91,6 @@ isDoubleQuote = is '"' -{-| -} -either : (Char -> Bool) -> (Char -> Bool) -> Char -> Bool -either f1 f2 char = - f1 char || f2 char - - {-| -} neither : (Char -> Bool) -> (Char -> Bool) -> Char -> Bool neither f1 f2 char =