Skip to content

Cell value return changed #336

Description

@c-git

Hi,

Sorry to only report a problem without a cause or solution but don't have the bandwidth to dig into it right now but wanted to at least make you aware of it.

TLDR between this commit and the current head of master something caused the returned value of the cell to no longer be the same. I knocked together a small test to show the change but haven't had time to investigate more than what I've already shared.

Previously returned value (which matches what I see when I open the file in LibreOffice): "{\"year_month\":{\"year\":2024,\"month\":11},\"period_number\":1}"
Currently returned value: ":1}"

Sample file used in the test temp.xlsx

Sample test code:

#[test]
fn debug_cell_value_change() {
    let path = std::path::Path::new("./tests/test_files/temp.xlsx");
    let mut book = umya_spreadsheet::reader::xlsx::read(path).unwrap();
    let sheet = book.sheet_by_name("Sheet1").unwrap();
    let value = sheet.cell((1, 2)).unwrap().value();
    assert_eq!(
        value,
        "{\"year_month\":{\"year\":2024,\"month\":11},\"period_number\":1}"
    );
}

Test output:

 1  failed: debug_cell_value_change
 thread 'debug_cell_value_change' (213485) panicked at tests/integration_test.rs:2946:5:
 assertion `left == right` failed
   left: ":1}"
  right: "{\"year_month\":{\"year\":2024,\"month\":11},\"period_number\":1}"

Ephemeral branch with sample code and file https://github.com/c-git/umya-spreadsheet/tree/debug_after (Not planning to keep this branch long term but it only has the code and file above)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions