added gfx preference to enable debug/trace pipelines

Author: i-make-robots

src/main/java/com/marginallyclever/convenience/helpers/OpenGLHelper.java

@@ -7,7 +7,6 @@
 import java.nio.FloatBuffer;
 import java.nio.IntBuffer;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 
 /**
@@ -33,7 +32,8 @@ public static void checkGLError(GL3 gl3,org.slf4j.Logger logger) {
 			logger.error("GL error {}: {}", err, glu.gluErrorString(err));
 			if(!errorCodes.contains(err)) {
 				errorCodes.add(err);
-				logger.error("Stack trace: {}", Arrays.toString(Thread.currentThread().getStackTrace()));
+				var error = new Exception("GL error %s: %s".formatted(err, glu.gluErrorString(err)));
+				logger.error(error.getMessage(), error);
 			}
 		}
 	}

src/main/java/com/marginallyclever/makelangelo/applicationsettings/GFXPreferences.java

@@ -16,6 +16,8 @@
  * @author Dan Royer
  */
 public class GFXPreferences {
+	static private SelectBoolean activateDebugGL;
+	static private SelectBoolean activateTraceGL;
 	static private SelectBoolean showPenUp;
 	static private SelectBoolean antialias;
 	static private SelectBoolean speedOverQuality;
@@ -37,20 +39,28 @@ static protected void firePropertyChange(PropertyChangeEvent e) {
 		}
 	}
 
-	static private Preferences getMyNode() {
+	/**
+	 * Get the preferences node for this class
+	 * @return Preferences node
+	 */
+	static private Preferences getPreferences() {
 		return PreferencesHelper.getPreferenceNode(PreferencesHelper.MakelangeloPreferenceKey.GRAPHICS);
 	}
 
 	static public SelectPanel buildPanel() {
-		Preferences prefs = getMyNode();
+		Preferences prefs = getPreferences();
 
 		SelectPanel panel = new SelectPanel();
+		activateDebugGL = new SelectBoolean("debugGL",Translator.get("GFXPreferences.debugGL"),prefs.getBoolean("debug GL", prefs.getBoolean("debugGL",false)));
+		activateTraceGL = new SelectBoolean("traceGL",Translator.get("GFXPreferences.traceGL"),prefs.getBoolean("trace GL", prefs.getBoolean("traceGL",false)));
 		showPenUp = new SelectBoolean("penup",Translator.get("GFXPreferences.showPenUp"),prefs.getBoolean("show pen up", false));
 		antialias = new SelectBoolean("antialias",Translator.get("GFXPreferences.antialias"),prefs.getBoolean("antialias", true));
 		speedOverQuality = new SelectBoolean("SpeedVSQuality",Translator.get("GFXPreferences.speedVSQuality"),prefs.getBoolean("speed over quality", true));
 		showAllWhileDrawing = new SelectBoolean("drawWhileRunning",Translator.get("GFXPreferences.showAllWhileDrawing"),prefs.getBoolean("Draw all while running", true));
 		dragSpeed = new SelectSpinner("dragSpeed", Translator.get("GFXPreferences.dragSpeed"), 1, 5, prefs.getInt("dragSpeed", 1));
 
+		panel.add(activateDebugGL);
+		panel.add(activateTraceGL);
 		panel.add(showPenUp);
 		panel.add(showAllWhileDrawing);
 		panel.add(antialias);
@@ -68,7 +78,9 @@ static public SelectPanel buildPanel() {
 	}
 
 	static public void save() {
-		Preferences prefs = getMyNode();
+		Preferences prefs = getPreferences();
+		prefs.putBoolean("debug GL", activateDebugGL.isSelected());
+		prefs.putBoolean("trace GL", activateTraceGL.isSelected());
 		prefs.putBoolean("show pen up", showPenUp.isSelected());
 		prefs.putBoolean("antialias", antialias.isSelected());
 		prefs.putBoolean("speed over quality", speedOverQuality.isSelected());
@@ -77,14 +89,14 @@ static public void save() {
 	}
 
 	static public boolean getShowPenUp() {
-		Preferences prefs = getMyNode();
+		Preferences prefs = getPreferences();
 		return prefs.getBoolean("show pen up",false);
 	}
 
 	static public void setShowPenUp(boolean state) {
 		boolean old = getShowPenUp();
 		if(old != state) {
-			Preferences prefs = getMyNode();
+			Preferences prefs = getPreferences();
 			prefs.putBoolean("show pen up", state);
 			firePropertyChange(new PropertyChangeEvent(prefs,"show pen up",old,state));
 		}

src/main/java/com/marginallyclever/makelangelo/preview/OpenGLPanel.java

@@ -31,8 +31,8 @@ public class OpenGLPanel extends JPanel implements GLEventListener, MouseWheelLi
 	private static final Logger logger = LoggerFactory.getLogger(OpenGLPanel.class);
 
 	// Use debug pipeline?
-	private static final boolean DEBUG_GL_ON = false;
-	private static final boolean TRACE_GL_ON = false;
+	private static boolean DEBUG_GL_ON = true;
+	private static boolean TRACE_GL_ON = true;
 	private GLJPanel glCanvas;
 	private int canvasWidth,canvasHeight;
 
@@ -219,6 +219,13 @@ private void setTipXY() {
 	public void init(GLAutoDrawable glAutoDrawable) {
 		logger.debug("init");
 		glAutoDrawable.getGL().getGL3();
+
+		Preferences prefs = PreferencesHelper.getPreferenceNode(PreferencesHelper.MakelangeloPreferenceKey.GRAPHICS);
+		if(prefs != null) {
+			DEBUG_GL_ON = prefs.getBoolean("debug GL", false);
+			TRACE_GL_ON = prefs.getBoolean("trace GL", false);
+		}
+
 		activatePipelines(glAutoDrawable);
 
 		var gl = glAutoDrawable.getGL().getGL3();

src/main/resources/messages.properties

@@ -96,10 +96,12 @@ FlipV=Missing FlipV
 FontFace=Missing FontFace
 GFXPreferences.Title=Missing GFXPreferences.Title
 GFXPreferences.antialias=Missing GFXPreferences.antialias
+GFXPreferences.debugGL=Missing GFXPreferences.debugGL
 GFXPreferences.dragSpeed=Missing GFXPreferences.dragSpeed
 GFXPreferences.showAllWhileDrawing=Missing GFXPreferences.showAllWhileDrawing
 GFXPreferences.showPenUp=Missing GFXPreferences.showPenUp
 GFXPreferences.speedVSQuality=Missing GFXPreferences.speedVSQuality
+GFXPreferences.traceGL=Missing GFXPreferences.traceGL
 Generator.randomSeed=Missing Generator.randomSeed
 Generator_AnalogClock.name=Missing Generaltor_AnalogClock.name
 Generator_FlowField.fromEdge=Missing Generator_FlowField.fromEdge

src/main/resources/messages_en.properties

@@ -96,10 +96,12 @@ FlipV=Flip vertical
 FontFace=Typeface
 GFXPreferences.Title=Graphics
 GFXPreferences.antialias=Antialias lines
+GFXPreferences.debugGL=Activate debug (requires restart)
 GFXPreferences.dragSpeed=camera travel speed
 GFXPreferences.showAllWhileDrawing=Show entire image while drawing
 GFXPreferences.showPenUp=Show travel moves
 GFXPreferences.speedVSQuality=Speed over quality
+GFXPreferences.traceGL=Activate tracing (requires restart)
 Generator.randomSeed=Random seed value
 Generator_AnalogClock.name=Analog clock
 Generator_FlowField.fromEdge=Continuous