Improper col setting for bsseq?

[knokknok]

wg-blimp/snakemake_wrapper/scripts/bsseq.R

Line 29 in b63eaba

pData$col <- c(rep("red", length(group1Samples)), rep("blue", length(group2Samples)))

1/ if length(group1Samples)+length(group2Samples) is different than nrow(pData), the call will fail
2/ sampleNames is not necessarily c(group1Samples, group2Samples) (order might be different) ?

Something like the following would therefore be safer?:

pData$col <- "black"
pData$col[rownames(pData) %in% group1Samples] <- "red"
pData$col[rownames(pData) %in% group2Samples] <- "blue"