Fix test minor issues

Author: NicoLaval

src/Editor.tsx

@@ -22,10 +22,10 @@ export type EditorHandle = {
     focus(): void;
 };
 
-// Check if we're in a test environment
-const isTestEnvironment =
-    typeof globalThis !== "undefined" &&
-    (globalThis as { process?: { env?: { NODE_ENV?: string } } }).process?.env?.NODE_ENV === "test";
+// Vitest sets process.env.VITEST; NODE_ENV alone is unreliable in CI (e.g. production).
+const processEnv = (globalThis as { process?: { env?: { NODE_ENV?: string; VITEST?: string } } })
+    .process?.env;
+const isTestEnvironment = processEnv?.VITEST === "true" || processEnv?.NODE_ENV === "test";
 
 // Import Monaco Editor components directly
 import MonacoEditorComponent from "@monaco-editor/react";
@@ -180,6 +180,10 @@ function Editor({
 
     // Handle Monaco disposal errors gracefully without global monkey patches.
     useEffect(() => {
+        if (typeof window === "undefined") {
+            return;
+        }
+
         const handleMonacoError = (event: ErrorEvent) => {
             if (shouldSuppressMonacoError(event.error ?? event.message)) {
                 // Suppress Monaco cleanup errors - they're harmless during layout changes
@@ -462,22 +466,39 @@ function Editor({
     );
 
     useEffect(() => {
-        if (!Array.isArray(variablesInputURLs) || variablesInputURLs.length === 0) setReady(true);
+        if (!Array.isArray(variablesInputURLs) || variablesInputURLs.length === 0) {
+            setReady(true);
+            return;
+        }
+
+        if (ready) {
+            return;
+        }
+
+        let cancelled = false;
         const f = customFetcher || fetch;
-        if (variablesInputURLs && variablesInputURLs.length > 0 && !ready) {
-            Promise.all(variablesInputURLs.map(v => f(v)))
-                .then(res =>
-                    Promise.all(res.map(r => r.json())).then(res => {
-                        const uniqueVars = buildUniqueVariables(res);
-                        setVars(v => [...v, ...uniqueVars]);
-                        setReady(true);
-                    })
-                )
-                .catch(() => {
+
+        Promise.all(variablesInputURLs.map(v => f(v)))
+            .then(res =>
+                Promise.all(res.map(r => r.json())).then(res => {
+                    if (cancelled) {
+                        return;
+                    }
+                    const uniqueVars = buildUniqueVariables(res);
+                    setVars(v => [...v, ...uniqueVars]);
                     setReady(true);
-                });
-        }
-    }, [variablesInputURLs]);
+                })
+            )
+            .catch(() => {
+                if (!cancelled) {
+                    setReady(true);
+                }
+            });
+
+        return () => {
+            cancelled = true;
+        };
+    }, [variablesInputURLs, customFetcher, ready]);
 
     useEffect(() => {
         if (isEditorReady) {

src/__tests__/setup.ts

@@ -126,31 +126,29 @@ vi.mock("@monaco-editor/react", () => ({
     default: vi.fn(({ onMount }) => {
         // Simulate component mounting
         if (onMount) {
-            setTimeout(() => {
-                const mockEditor = {
-                    dispose: vi.fn(),
-                    getValue: vi.fn(() => ""),
-                    setValue: vi.fn(),
-                    focus: vi.fn(),
-                    setPosition: vi.fn(),
-                    revealPosition: vi.fn(),
-                    onDidChangeModelContent: vi.fn(() => ({ dispose: vi.fn() })),
-                    onDidChangeCursorPosition: vi.fn(() => ({ dispose: vi.fn() })),
-                    onDidChangeCursorSelection: vi.fn(() => ({ dispose: vi.fn() })),
-                    addCommand: vi.fn(),
-                    onKeyDown: vi.fn(() => ({ dispose: vi.fn() })),
-                    getModel: vi.fn(() => ({ dispose: vi.fn() }))
-                };
-                const mockMonaco = {
-                    editor: {
-                        setModelMarkers: vi.fn(),
-                        MarkerSeverity: { Error: 1, Warning: 2, Info: 3, Hint: 4 }
-                    },
-                    KeyMod: { CtrlCmd: 1, Shift: 2, Alt: 4 },
-                    KeyCode: { KeyS: 1, Enter: 2, KeyZ: 3, KeyY: 4 }
-                };
-                onMount(mockEditor, mockMonaco);
-            }, 0);
+            const mockEditor = {
+                dispose: vi.fn(),
+                getValue: vi.fn(() => ""),
+                setValue: vi.fn(),
+                focus: vi.fn(),
+                setPosition: vi.fn(),
+                revealPosition: vi.fn(),
+                onDidChangeModelContent: vi.fn(() => ({ dispose: vi.fn() })),
+                onDidChangeCursorPosition: vi.fn(() => ({ dispose: vi.fn() })),
+                onDidChangeCursorSelection: vi.fn(() => ({ dispose: vi.fn() })),
+                addCommand: vi.fn(),
+                onKeyDown: vi.fn(() => ({ dispose: vi.fn() })),
+                getModel: vi.fn(() => ({ dispose: vi.fn() }))
+            };
+            const mockMonaco = {
+                editor: {
+                    setModelMarkers: vi.fn(),
+                    MarkerSeverity: { Error: 1, Warning: 2, Info: 3, Hint: 4 }
+                },
+                KeyMod: { CtrlCmd: 1, Shift: 2, Alt: 4 },
+                KeyCode: { KeyS: 1, Enter: 2, KeyZ: 3, KeyY: 4 }
+            };
+            onMount(mockEditor, mockMonaco);
         }
         return null;
     }),

src/monaco-patch.ts

@@ -3,6 +3,10 @@ import { shouldSuppressMonacoError } from "./utils/monaco-errors";
 let isPatchApplied = false;
 
 export const applyMonacoPatch = (): (() => void) => {
+    if (typeof window === "undefined") {
+        return () => undefined;
+    }
+
     if (isPatchApplied) {
         return () => undefined;
     }