Skip to content

Docker image not published with semantic versioning #76

Description

@ThibaultNocchi

EDIT: please read my comment bringing some updates, as this issue described here doesn't seem to be the real problem.

Hi,

The Docker image doesn't have a tag with the semantic versioning, even though you are making releases with a version.

I tried to track down if this was an issue or just a missing feature, and I think it is an issue with the workflow.

In the extract metadata action of the Docker publish job, these tags suggest there should be a semver tag:

type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}

Reading the action v5 doc here, the semver type should be triggered on a tag push.

As you are publishing tags, I've checked the action triggers (as I couldn't find a run of a tag trigger):

on:
  push:
    branches: ["main"]
    tags: ["v*.*.*"]

At first look it could seem OK, but reading the glob pattern doc:

*: Matches zero or more characters, but does not match the / character. For example, Octo* matches Octocat.

I think that it means that a single * should match the rest of the string (except for /), hence this pattern not matching the semvers. I think either v* or v[0-9].[0-9].[0-9] should be applied.

What do you think? It'd greatly help my Renovate to show me the changelogs and I'd have a better image tag in my IAC (instead of me targeting latest@sha256:xxxxxxx ^^).

Thanks for maintaining immich-stack, it's really helpful!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions